From nobody Tue Apr 18 06:12:51 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q0trS0gHjz45pMt; Tue, 18 Apr 2023 06:12:56 +0000 (UTC) (envelope-from gbe@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q0trS05cKz4KSQ; Tue, 18 Apr 2023 06:12:56 +0000 (UTC) (envelope-from gbe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681798376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Gq/g1aZ89YlWxTt9DQ7FA6xKcDQeEIzZNrMdYDTBsA=; b=A6en3I2SLI38P8y3CLTfQeS1OmHcYYsM06D01z3f9DAZBX86EitKvjzSTlGg9ObInQ7pL1 sIN9a8dve8Ba0aIZ+C4CHF4/GgRhbZvDqk4MlAa2TWdsfD8P4d+Qo7MqJcN6jWeCKZvckV Nuvyw3gqKICOBfMyu7udO6WsZsjNDdAKjvxIte/OEvkghrO5YIl25WUksKqWHLemD7chOY izOrfXMKj50v8PQUpO0RRTCuOSBkbNUSTWeEJumEoTUCjCsjHW8F5KfBi08NiL2T+QkNE5 /EdxQLk6fhpryqG4/9CN/jTzo8VkHJFu20c33Zy9JsBKeZaXoX8tR2mvpdLR0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681798376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Gq/g1aZ89YlWxTt9DQ7FA6xKcDQeEIzZNrMdYDTBsA=; b=JC8gLvohrbiM7KKlGXzz0mNpaoKpdqI6cpIa/PmhzGesBX0ohxvEP8yCaopzx/0N4GUwXH zK8nbAVv33nW0CdZJgqIcxhBlgFwHIinrlfECwCfVZJlLtbzEnqfQot0R7tv2acKkVkGKd c6FfLWmPy2oPVZjs85pGwr9k7t4Xq2ZdV3BFlr+4X+HSea64VQ5+bv+3siPZ6Vd/t9QvY5 XBFr0Gex/dfVqCt4Am6dRwVFBczQa10QQHoi1v3DHV8/Mj8Xrmdm07ZgwxRwIVFpukcEDa WA7AvyAN8Sy+Sy2SNLEJ+0tadElslhIeO8nol7s2LpjU7ZL0ZbmBfvDNpvaOgg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681798376; a=rsa-sha256; cv=none; b=AvH/JeAWGaBB1aQ8TNUao4hMaDsHMKhamjMGnPtcLVulOGWD0Ry7KYIXiYQN0vBbvufP+L XpvH/3pxeM8YkHuBlPVjK4fGntLTCost+/+24vnrCH/AWwMv3ArGCCq3ihpZ2nfaWUwiTd NnQRuOGaOzLywmmhyeDobJqANzgAMEpu3fIoagWPBoTrL4Cb9edZpRi1KdCBGVdo/9EhSM t+x0pzlcjDlS0m4U7sVUcEEK7NhFzANiiug7jQH6driopOBU77w58MDt3xJSPkCnu9bPR0 IYqZn4izY79/kurtpvLnmeI7nMOxPba1IsTw/aVARsR5nOoL8P6iOMOJIcwjQg== Received: from localhost (p200300cb8725f51bc4cf95b8c2c1c625.dip0.t-ipconnect.de [IPv6:2003:cb:8725:f51b:c4cf:95b8:c2c1:c625]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gbe) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Q0trR1ZKJzwyB; Tue, 18 Apr 2023 06:12:55 +0000 (UTC) (envelope-from gbe@freebsd.org) Date: Tue, 18 Apr 2023 08:12:51 +0200 From: Gordon Bergling To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: b12ccd0bb1b3 - main - stand: Remove double words in source code comments Message-ID: References: <202304180515.33I5FKdK006761@gitrepo.freebsd.org> <5B4D966A-896A-4C77-97CD-1594B9C79B42@freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5B4D966A-896A-4C77-97CD-1594B9C79B42@freebsd.org> X-Url: X-Operating-System: FreeBSD 13.2-STABLE amd64 X-Host-Uptime: 8:09AM up 18:53, 3 users, load averages: 0.32, 0.24, 0.18 X-ThisMailContainsUnwantedMimeParts: N Hi Jess, On Tue, Apr 18, 2023 at 06:31:28AM +0100, Jessica Clarke wrote: > On 18 Apr 2023, at 06:15, Gordon Bergling wrote: [...] > > --- a/stand/i386/boot0/Makefile > > +++ b/stand/i386/boot0/Makefile > > @@ -36,7 +36,7 @@ BOOT_BOOT0_FLAGS?= 0x8f > > # 0xb6 (182d) corresponds to 10 seconds. > > BOOT_BOOT0_TICKS?= 0xb6 > > > > -# The base address that we the boot0 code to to run it. Don't change this > > +# The base address that we the boot0 code to run it. Don't change this > > This was correct and is now incorrect; read as “that we [load] the > boot0 code to in order to run it”. > > Jess I just reverted the change. Sorry, not a native speaker on this side and the sentence was a little hard to understand. --Gordon > > # unless you are glutton for punishment. > > BOOT_BOOT0_ORG?= 0x600 > > ORG=${BOOT_BOOT0_ORG} > > diff --git a/stand/libsa/zfs/zfsimpl.c b/stand/libsa/zfs/zfsimpl.c > > index 76063e76225f..4a285470642e 100644 > > --- a/stand/libsa/zfs/zfsimpl.c > > +++ b/stand/libsa/zfs/zfsimpl.c > > @@ -447,7 +447,7 @@ vdev_indirect_mapping_entry(vdev_indirect_mapping_t *vim, uint64_t index) > > * > > * It's possible that the given offset will not be in the mapping table > > * (i.e. no mapping entries contain this offset), in which case, the > > - * return value value depends on the "next_if_missing" parameter. > > + * return value depends on the "next_if_missing" parameter. > > * > > * If the offset is not found in the table and "next_if_missing" is > > * B_FALSE, then NULL will always be returned. The behavior is intended