git: a5d82b55fe76 - main - Remove an impossible condition from unionfs_lock()

From: Jason A. Harmening <jah_at_FreeBSD.org>
Date: Tue, 18 Apr 2023 01:35:43 UTC
The branch main has been updated by jah:

URL: https://cgit.FreeBSD.org/src/commit/?id=a5d82b55fe76307df5277caa4bb1b7963a405e34

commit a5d82b55fe76307df5277caa4bb1b7963a405e34
Author:     Jason A. Harmening <jah@FreeBSD.org>
AuthorDate: 2023-01-16 21:48:11 +0000
Commit:     Jason A. Harmening <jah@FreeBSD.org>
CommitDate: 2023-04-18 01:31:40 +0000

    Remove an impossible condition from unionfs_lock()
    
    We hold the vnode interlock, so vnode private data cannot suddenly
    become NULL.
    
    Tested by:      pho
    Reviewed by:    kib, markj
    Differential Revision:  https://reviews.freebsd.org/D39272
---
 sys/fs/unionfs/union_vnops.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/sys/fs/unionfs/union_vnops.c b/sys/fs/unionfs/union_vnops.c
index f78e653280a4..a0ff5c140e82 100644
--- a/sys/fs/unionfs/union_vnops.c
+++ b/sys/fs/unionfs/union_vnops.c
@@ -1982,14 +1982,6 @@ unionfs_lock(struct vop_lock1_args *ap)
 			vholdnz(uvp);
 			uhold = 1;
 			VOP_UNLOCK(uvp);
-			unp = VTOUNIONFS(vp);
-			if (unp == NULL) {
-				/* vnode is released. */
-				VI_UNLOCK(vp);
-				VOP_UNLOCK(lvp);
-				vdrop(uvp);
-				return (EBUSY);
-			}
 		}
 		VI_LOCK_FLAGS(lvp, MTX_DUPOK);
 		flags |= LK_INTERLOCK;