From nobody Wed Apr 12 16:27:46 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PxSnW1072z453Vr; Wed, 12 Apr 2023 16:28:31 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Received: from smtp6.goneo.de (smtp6.goneo.de [85.220.129.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PxSnV0zFkz43f9; Wed, 12 Apr 2023 16:28:29 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Authentication-Results: mx1.freebsd.org; none Received: from hub1.goneo.de (hub1.goneo.de [85.220.129.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by smtp6.goneo.de (Postfix) with ESMTPS id DE17B10A32CE; Wed, 12 Apr 2023 18:28:25 +0200 (CEST) Received: from hub1.goneo.de (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by hub1.goneo.de (Postfix) with ESMTPS id A4B9510A1E83; Wed, 12 Apr 2023 18:28:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walstatt-de.de; s=DKIM001; t=1681316901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s6dbn25biUkXhWZ6eDSE9vLUQRnJTvK2K3njZ1XueBM=; b=qoN4IBBSLchgEQ63gqXQ5TLfb2TaqYHwZVsHzisaDrzJq1BdX8XgBmen21tPFaRFPiRfYp GLQ2ekI/lOvjoYycKjL/NQnw2zSbtn1d6hhUy6Whgh/RSpTsBB08GItyf6VPJHjqzJ0/0r RePgtPO0aI+NsFlXOSXXnAmPXSaxUQzkcBJM9clrw2j1yjn/wYAQS1P11zO05xgNCnVTl4 hsiNnd4Iy7rDFoq1Bc/ssET0vIaPvCTzTccv7uv142WQIJV2JQi8S/wRjzyNK5vml/I9AL sGxINhZEgRTrRxQaESAnL/vCVm0YwR4ufYUbYTOBaia8R2y+tVF2fNOS0MGYzw== Received: from thor.intern.walstatt.dynvpn.de (dynamic-077-183-141-152.77.183.pool.telefonica.de [77.183.141.152]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hub1.goneo.de (Postfix) with ESMTPSA id 1C8C010A32F4; Wed, 12 Apr 2023 18:28:21 +0200 (CEST) Date: Wed, 12 Apr 2023 18:27:46 +0200 From: FreeBSD User To: Charlie Li Cc: Cy Schubert , Rick Macklem , Martin Matuska , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 Message-ID: <20230412182813.63180c6a@thor.intern.walstatt.dynvpn.de> In-Reply-To: <70739834-4eea-db30-63be-556bcfd881a1@freebsd.org> References: <202304031513.333FD6qw014903@gitrepo.freebsd.org> <20230403231444.CF48911F@slippy.cwsent.com> <20230403232549.73E331A2@slippy.cwsent.com> <20230403235851.84C0467@slippy.cwsent.com> <20230404052811.DA2172C1@slippy.cwsent.com> <7c75b934-cb0a-b32e-bc19-b1e15e8cf3aa@freebsd.org> <20230409154042.0685a273@cschubert.com> <707e4671-d746-aa23-e340-6eb8f50f78c6@freebsd.org> <20230409205826.7802259d@cschubert.com> <4e85eb84-f0cc-2f8c-d3d9-1e016ede042a@freebsd.org> <20230410165406.51bcd958@cschubert.com> <70739834-4eea-db30-63be-556bcfd881a1@freebsd.org> Organization: walstatt-de.de List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/w.usAa90GXCQmikF=8jfs4L"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Rspamd-UID: caa3b5 X-Rspamd-UID: c46c0c X-Rspamd-Queue-Id: 4PxSnV0zFkz43f9 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_RCPT(0.00)[]; ASN(0.00)[asn:25394, ipnet:85.220.128.0/17, country:DE] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --Sig_/w.usAa90GXCQmikF=8jfs4L Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Wed, 12 Apr 2023 11:51:09 -0400 Charlie Li schrieb: > Cy Schubert wrote: > > I have a "sandhbox" pool, called t, used for /usr/obj and ports wrkdirs= , and other writes > > I can easily recreate on my laptop. Here are the results of my tests. > >=20 > > Method: > >=20 > > Initially I copied my /usr/obj from my two build machines (one amd64.am= d64 and an > > i386.i386) to my "sandbox" zpool. > >=20 > > Next, with block_cloning disabled I did cp -R of the /usr/obj test file= s. Then a diff -qr. > > They source and target directories were the same. > >=20 > > Next, I cleaned up (rm -rf) the target directory to prepare for the > > block_clone enabled test. > >=20 > > Next, I did zpool checkpoint t. After this, zpool upgrade t. Pool t now= has block_cloning > > enabled. > >=20 > > I repeated the cp -R test from above followed by a diff -qr. Almost > > every file was different. The pool was corrupted. > >=20 > > I restored the pool by the following removing the corruption: > >=20 > >=20 > > slippy# zpool export t > > slippy# zpool import --rewind-to-checkpoint t > > slippy# > >=20 > > It is recommended that people avoid upgrading their zpools until the > > problem is fixed. > > =20 > As of af7624ed3145, I just did this with an md(4)-backed test pool,=20 > though with the second `cp -R` landing in a separate dataset, created=20 > and destroyed for each test. No corruption either way. However, my=20 > poudriere builds still output/package corrupted files (particularly=20 > those with null characters), probably after install(1) invocations (not=20 > cp(1)). >=20 I still have corrupt files on the /usr/ports tree (located on ZFS, with fea= ture@block_cloning active): [...] Installing man pages and online manual mkdir /usr/ports/www/apache24/work/stage/usr/local/share/doc/apache24 cd /usr/ports/www/apache24/work/httpd-2.4.57/docs/manual && cp -rp * /usr/ports/www/apache24/work/stage/usr/local/share/doc/apache24 install -m= 0644 /usr/ports/www/apache24/files/no-accf.conf /usr/ports/www/apache24/work/stage/usr/local/etc/apache24/Includes/ install= -m 0644 /usr/ports/www/apache24/files/README_modules.d /usr/ports/www/apache24/work/stage/usr/local/etc/apache24/modules.d/ /usr/b= in/strip /usr/ports/www/apache24/work/stage/usr/local/libexec/apache24/mod_*.so /bin= /rm -f /usr/ports/www/apache24/work/stage/usr/local/share/apache24/build/ecp.?????= ??? 2>/dev/null install -m 555 /usr/ports/www/apache24/work/httpd-2.4.57/support/check_for= ensic /usr/ports/www/apache24/work/stage/usr/local/sbin =3D=3D=3D=3D> Compressing= man pages (compress-man) =3D=3D=3D> Staging rc.d startup script(s) =3D=3D=3D> Installing for apache= 24-2.4.57 =3D=3D=3D> Registering installation for apache24-2.4.57 pkg-static: pkg_checksum_hash_sha256_file(= read failed): Input/output error pkg-static: pkg_checksum_hash_sha256_file(read failed): = Input/output error pkg-static: pkg_checksum_hash_sha256_file(read failed): Input/output error = pkg-static: pkg_checksum_hash_sha256_file(read failed): Input/output error pkg-static: pkg_checksum_hash_sha256_file(read failed): Input/output error pkg-static: pkg_checksum_hash_sha256_file(read failed): Input/output error www/apache24 is now ALWAYS droping this corruption, even after scrubbing th= e pool. This one is the same in my case: [...] cd /usr/ports/devel/ruby-gems/work/stage/usr/local/ && /usr/bin/find -ds lib/ruby/gems/3.1/doc/ ! -type d >> /usr/ports/devel/ruby-gems/work/.PLIST.= mktmp =3D=3D=3D=3D> Compressing man pages (compress-man) =3D=3D=3D>>> Starting check for runtim= e dependencies =3D=3D=3D>>> Gathering dependency list for devel/ruby-gems from ports =3D=3D=3D>>> Dependency check complete for devel/ruby-gems =3D=3D=3D>>> All >> rubygem-addressable-2.8.1 >> devel/ruby-gems (3/27) =3D=3D=3D> Installing for ruby31-gems-3.4.10 =3D=3D=3D> Registering installation for ruby31-gems-3.4.10 as automatic pkg-static: pkg_checksum_hash_sha256_file(read failed): Input/output error pkg-static: pkg_checksum_hash_sha256_file(read failed): Input/output error pkg-static: pkg_checksum_hash_sha256_file(read failed): Input/output error pkg-static: pkg_checksum_hash_sha256_file(read failed): Input/output error *** Error code 1 Stop. make[1]: stopped in /usr/ports/devel/ruby-gems Pool is then marked corrupt (was scrubbed after the last corruption): [...] pool: POOL00 state: ONLINE status: One or more devices has experienced an error resulting in data corruption. Applications may be affected. action: Restore the file in question if possible. Otherwise restore the entire pool from backup. see: https://openzfs.github.io/openzfs-docs/msg/ZFS-8000-8A scan: scrub in progress since Wed Apr 12 18:07:02 2023 1.45T scanned at 2.01G/s, 139G issued at 193M/s, 13.2T total 0B repaired, 1.02% done, 19:49:53 to go config: NAME STATE READ WRITE CKSUM POOL00 ONLINE 0 0 0 raidz1-0 ONLINE 0 0 0 gpt/pool00 ONLINE 0 0 0 gpt/pool01 ONLINE 0 0 0 gpt/pool02 ONLINE 0 0 0 gpt/pool03 ONLINE 0 0 0 errors: 22 data errors, use '-v' for a list [...] errors: Permanent errors have been detected in the following files: /usr/ports/devel/ruby-gems/work/stage/usr/local/lib/ruby/site_ruby/= 3.1/rubygems/optparse/lib/optionparser.rb /usr/ports/devel/ruby-gems/work/stage/usr/local/lib/ruby/site_ruby/= 3.1/rubygems/optparse.rb /usr/ports/www/apache24/work/stage/usr/local/www/apache24/icons/sma= ll/blank.gif /usr/ports/devel/ruby-gems/work/stage/usr/local/lib/ruby/site_ruby/= 3.1/rubygems/resolver/molinillo.rb /usr/ports/www/apache24/work/stage/usr/local/share/doc/apache24/ima= ges/left.gif /usr/ports/www/apache24/work/stage/usr/local/share/doc/apache24/ima= ges/right.gif /usr/ports/www/apache24/work/stage/usr/local/share/doc/apache24/ima= ges/down.gif /usr/ports/www/apache24/work/stage/usr/local/share/doc/apache24/ima= ges/pixel.gif /usr/ports/devel/ruby-gems/work/stage/usr/local/lib/ruby/site_ruby/= 3.1/rubygems/tsort.rb /usr/ports/www/apache24/work/stage/usr/local/share/doc/apache24/ima= ges/up.gif --=20 O. Hartmann --Sig_/w.usAa90GXCQmikF=8jfs4L Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRQheDybVktG5eW/1Kxzvs8OqokrwUCZDbcHQAKCRCxzvs8Oqok rzgJAQCeJ5RPOot/JL7dkZbcErVOnFXtHHnPQJju+ASYCiZHbAEAiXGs7hYK942f +5OlJ+YnxizbV2VhPZYJFg4wWPGl8gc= =6R+z -----END PGP SIGNATURE----- --Sig_/w.usAa90GXCQmikF=8jfs4L--