From nobody Tue Apr 04 19:30:54 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PrdCm2PK6z444T2; Tue, 4 Apr 2023 19:31:00 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PrdCl5hsjz4JPy; Tue, 4 Apr 2023 19:30:59 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4001a.ext.cloudfilter.net ([10.228.9.142]) by cmsmtp with ESMTP id jhGPpqNGRuZMSjmMspyBBu; Tue, 04 Apr 2023 19:30:59 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id jmMppO2KAHFsOjmMrpB361; Tue, 04 Apr 2023 19:30:58 +0000 X-Authority-Analysis: v=2.4 cv=XZqaca15 c=1 sm=1 tr=0 ts=642c7af2 a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=dKHAf1wccvYA:10 a=cOLrLDMxAAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=pGLkceISAAAA:8 a=-t4MIqo7Bv5vLsJ1li8A:9 a=QEXdDO2ut3YA:10 a=P0s3qUPvOpV5zndjNR8V:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id B018B38A; Tue, 4 Apr 2023 12:30:54 -0700 (PDT) Received: from slippy (localhost [IPv6:::1]) by slippy.cwsent.com (Postfix) with ESMTP id 89B8E1BD; Tue, 4 Apr 2023 12:30:54 -0700 (PDT) Date: Tue, 4 Apr 2023 12:30:54 -0700 From: Cy Schubert To: "Pokala, Ravi" Cc: Martin Matuska , Rick Macklem , Mateusz Guzik , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: 8ee579abe09e - main - zfs: fall back if block_cloning feature is disabled Message-ID: <20230404123054.6cf5fb6b@slippy> In-Reply-To: <5B7F71CC-5BE6-4938-A29E-E10B01A4E4ED@panasas.com> References: <202304041145.334Bjx6l035872@gitrepo.freebsd.org> <20230404141717.B976D31C@slippy.cwsent.com> <98c71e6f-5b48-79f3-e7b0-95d674949624@FreeBSD.org> <20230404091844.639cb1c1@slippy> <5B7F71CC-5BE6-4938-A29E-E10B01A4E4ED@panasas.com> Organization: KOMQUATS X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CMAE-Envelope: MS4xfCYPi+mQSqNrbALfbI/4qoJHAcIJPygV0Q/uJRLHs10JB22BC03ZPv6Bsh3VBym6Bp9veztAunXDza0NlFR2oP7eNTt8BbVR1nyrXISmJHVr7D9IPyZw H3Vkg3OosDEGdzUYApZCwuC1L/yoF2DJpK777wA6NjhCHhCn0lU2SAyDoDpnlmU9tDECP0Xto/KblD+0gK4AaKohwPCLextgAZBvajkrC66WrpIvIn3f5ymI pXkF/G/3MDbuNwPkm8dUW/RmmefEBzbdE4MY2rpwp2jqY3xLQrd6330UBX5XqsA7LHr5w/UeKX4uS5buH+eAjYMAJOylF9+oWN5pDjavXFzW3U+NUDxtR3nl LOuzgISshucOJ8D+mao9ZHGJ7vgfXogTsXT+73WuQ5Uqf8BiVifQNkRDNOljPSiJBWyld+VT X-Rspamd-Queue-Id: 4PrdCl5hsjz4JPy X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US]; TAGGED_RCPT(0.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Tue, 4 Apr 2023 17:54:28 +0000 "Pokala, Ravi" wrote: > Cy, >=20 > The patch adds 'bool done_outvp', unconditionally sets it to 'true', and = then later has a check for 'if (!done_outvp)'. Since there is no intervenin= g place where 'done_outvp' could be set to 'false', that check will never s= ucceed and that branch is unreachable. It's set to false at line 6454, in the loop locking vnodes. >=20 > Or am I mis-reading something? Maybe Rick can explain but all we're doing is ensuring that the first part of the loop is executed only first time through. We could invert it and save setting it to false every loop. >=20 > Thanks, >=20 > Ravi (rpokala@) >=20 --=20 Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=3D0 > =EF=BB=BF-----Original Message----- > From: > on behalf of Cy Schubert > > Organization: KOMQUATS > Date: Tuesday, April 4, 2023 at 09:18 > To: Martin Matuska > > Cc: Rick Macklem >= , Mateusz Guzik >, >, >, > > Subject: Re: git: 8ee579abe09e - main - zfs: fall back if block_cloning f= eature is disabled >=20 >=20 > On Tue, 4 Apr 2023 17:30:25 +0200 > Martin Matuska > wrote: >=20 >=20 > > So I am now a little bit confused - what is the consensus? :-) =20 >=20 >=20 > My exmh email client made a mess of that. Let's try this again. >=20 >=20 > Rick has posted a patch. Your patch should also be incorporated to work=20 > around other EXDEV errors, but a few lines earlier so it is protected by= =20 > the lock. >=20 >=20 > There were a couple of typos in Rick's patch (a missing keystroke;=20 > s/ojset/objset/). >=20 >=20 > The patch (Rick's null pointer dereference fix, Rick's copy file range=20 > patch plus your copy file range patch) builds fine on amd64 and i386.=20 > Installing and testing it now. >=20 >=20 > A combination of all three patches is attached. It's compile tested but i= s=20 > currently being installed and will be tested when install is completed. >=20 >=20