Re: git: 8ee579abe09e - main - zfs: fall back if block_cloning feature is disabled

In message <CAGudoHHe3FJmW_cEddozQScJcwfbdbbfEn=y+m6wwmzmvEMb-w@mail.gmail.c
om>
, Mateusz Guzik writes:
> can you please post a review

I could but I didn't write any of it. Rick Macklem and Martin Matuska wrote 
it. My patch was for discussion only.

Martin and Rick, do you mind if I post this as a review. It should probably 
be two, maybe three separate commits, fixing two different problems.


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy@nwtime.org>    Web:  https://nwtime.org

			e^(i*pi)+1=0


>
> On 4/4/23, Cy Schubert <Cy.Schubert@cschubert.com> wrote:
> > The previously posted patch containing the following fixes all
> > regressions discussed so far:
> >
> > - Rick's fix null ap->a_fsizetd NULL pointer derefernce
> > - Rick's call vn_generic_copy_file_range() when block_cloning is
> >   disabled
> > - Martin's call vn_generic_copy_file_range() when any other error
> >   resulting in EXDEV
> >
> >
> > --
> > Cheers,
> > Cy Schubert <Cy.Schubert@cschubert.com>
> > FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
> > NTP:           <cy@nwtime.org>    Web:  https://nwtime.org
> >
> > 			e^(i*pi)+1=0
> >
> >
> > On Tue, 4 Apr 2023 09:18:44 -0700
> > Cy Schubert <Cy.Schubert@cschubert.com> wrote:
> >
> >> On Tue, 4 Apr 2023 17:30:25 +0200
> >> Martin Matuska <mm@FreeBSD.org> wrote:
> >>
> >> > So I am now a little bit confused - what is the consensus? :-)
> >>
> >> My exmh email client made a mess of that. Let's try this again.
> >>
> >> Rick has posted a patch. Your patch should also be incorporated to work
> >> around other EXDEV errors, but a few lines earlier so it is protected by
> >> the lock.
> >>
> >> There were a couple of typos in Rick's patch (a missing keystroke;
> >> s/ojset/objset/).
> >>
> >> The patch (Rick's null pointer dereference fix, Rick's copy file range
> >> patch plus your copy file range patch) builds fine on amd64 and i386.
> >> Installing and testing it now.
> >>
> >> A combination of all three patches is attached. It's compile tested but is
> >>
> >> currently being installed and will be tested when install is completed.
> >>
> >
> >
>
>
> -- 
> Mateusz Guzik <mjguzik gmail.com>