From nobody Sun Apr 02 14:58:00 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PqHFy4J9Qz43lM0; Sun, 2 Apr 2023 14:58:14 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PqHFx4dFQz3nYs; Sun, 2 Apr 2023 14:58:13 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1680447485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cbx93UVVCbm4OnRMVe88Z17JSd+1yO4cujSv5Tqxnmc=; b=X2keEws0CiwRF0yTB5NDyNMMxMLu9aEyGQFfdg840N2UQBpe50JGB28T2szb6LmOSBLlI9 ezrWBuH6fu0aECwZUcNLe+YLGDfJTx6OX1xX0a3152vOIIO8qPJ+BdPKE4YxKmrcGeUUTt BsrMwwxI8dFkpAer5JybfGfzgcBltdo= Received: from skull.home.blih.net (lfbn-lyo-1-2174-135.w90-66.abo.wanadoo.fr [90.66.97.135]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 2cddb4f6 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 2 Apr 2023 14:58:04 +0000 (UTC) Date: Sun, 2 Apr 2023 16:58:00 +0200 From: Emmanuel Vadot To: Alastair Hogge Cc: Emmanuel Vadot , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: f1d7ae31d4aa - main - linuxkpi: Add hdmi helpers Message-Id: <20230402165800.47188c41ebf5d9b8c120758c@bidouilliste.com> In-Reply-To: <818d6db4dfaf420427d38f0491ec29b7@riseup.net> References: <202303280725.32S7P5eF036507@gitrepo.freebsd.org> <818d6db4dfaf420427d38f0491ec29b7@riseup.net> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4PqHFx4dFQz3nYs X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Sat, 01 Apr 2023 23:34:37 +0000 Alastair Hogge wrote: > On 2023-03-28 07:25, Emmanuel Vadot wrote: > > Hello manu, > > > The branch main has been updated by manu: > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=f1d7ae31d4aa7b352611c43a9fb3b04986cff622 > > > > commit f1d7ae31d4aa7b352611c43a9fb3b04986cff622 > > Author: Emmanuel Vadot > > AuthorDate: 2023-03-16 15:12:12 +0000 > > Commit: Emmanuel Vadot > > CommitDate: 2023-03-28 07:11:06 +0000 > > > > linuxkpi: Add hdmi helpers > > > > This is a direct port of the Linux code as the licence allows it, so > > style(9) isn't respected to allow applying directly the upstream commits. > > Do not add it to linuxkpi directly but add a new linuxkpi_hdmi module > > that drm modules will require later, no need to bloat linuxkpi more. > > > > Sponsored by: Beckhoff Automation GmbH & Co. KG > > Differential Revision: https://reviews.freebsd.org/D39122 > > --- > > sys/compat/linuxkpi/common/include/linux/hdmi.h | 440 ++++++ > > sys/compat/linuxkpi/common/src/linux_hdmi.c | 1922 +++++++++++++++++++++++ > > sys/modules/Makefile | 1 + > > sys/modules/linuxkpi_hdmi/Makefile | 13 + > > 4 files changed, 2376 insertions(+) > > [leading diff removed] > > diff --git a/sys/compat/linuxkpi/common/src/linux_hdmi.c > b/sys/compat/linuxkpi/common/src/linux_hdmi.c > new file mode 100644 > index 000000000000..5a9b5c552e49 > --- /dev/null > +++ b/sys/compat/linuxkpi/common/src/linux_hdmi.c > @@ -0,0 +1,1922 @@ > > [most of module removed] > > +} > +EXPORT_SYMBOL(hdmi_infoframe_unpack); > + > + > +MODULE_VERSION(linuxkpi_hdmi, 1); > +MODULE_DEPEND(linuxkpi_hdmi, linuxkpi, 1, 1, 1); > +MODULE_DEPEND(linuxkpi_hdmi, wlan, 1, 1, 1); > > Is this module meant to depend on wlan? I was unable to boot a working X > after updating past this commit; upon booting the kernel, it did not > load linuxkpi_hdmi because wlan was missing. I did not want to rebuild > world and kernel WITH_WIRELESS and with the wlan device, so I removed > the MODULE_DEPEND declaration on wlan. Not sure what is going on, and if > linuxkpi will depend on the networking stack in future? > > Thanks for the amazing work on continuing FreeBSD work on the desktop > for the 14 or so of us users ;-) > Alastair Oops, fixed now, thanks for reporting :) -- Emmanuel Vadot