Re: git: d3f96f661050 - main - Fix O(n^2) behavior in sysctl
Date: Tue, 27 Sep 2022 13:33:07 UTC
This change has resulted in some external breakage: > drm_sysctl_freebsd.c:93:2: error: no member named 'sle_next' in 'struct sysctl_oid::(unnamed at /usr/src/sys/sys/sysctl.h:189:2)' > SLIST_FOREACH(oid, SYSCTL_CHILDREN(drioid), oid_link) { > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/src/sys/sys/queue.h:236:14: note: expanded from macro 'SLIST_FOREACH' > (var) = SLIST_NEXT((var), field)) > ^~~~~~~~~~~~~~~~~~~~~~~~ > /usr/src/sys/sys/queue.h:272:46: note: expanded from macro 'SLIST_NEXT' > #define SLIST_NEXT(elm, field) ((elm)->field.sle_next) Maybe we should have a SYSCTL_FOREACH() macro? --HPS