Re: git: 7ae99f80b666 - main - pmap_unmapdev/bios: Accept a pointer instead of a vm_offset_t.
Date: Fri, 23 Sep 2022 16:34:52 UTC
On 9/22/22 11:40 PM, FreeBSD User wrote: > Am Thu, 22 Sep 2022 22:10:49 GMT > John Baldwin <jhb@FreeBSD.org> schrieb: > >> The branch main has been updated by jhb: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=7ae99f80b6661760c5de3edd330b279f04b092a2 >> >> commit 7ae99f80b6661760c5de3edd330b279f04b092a2 >> Author: John Baldwin <jhb@FreeBSD.org> >> AuthorDate: 2022-09-22 22:08:52 +0000 >> Commit: John Baldwin <jhb@FreeBSD.org> >> CommitDate: 2022-09-22 22:08:52 +0000 >> >> pmap_unmapdev/bios: Accept a pointer instead of a vm_offset_t. >> >> This matches the return type of pmap_mapdev/bios. >> >> Reviewed by: kib, markj >> Sponsored by: DARPA >> Differential Revision: https://reviews.freebsd.org/D36548 >> --- >> [ Quote trimmed, please trim quotes in the future ] > This commit breaks compiling x11/nvidia-driver on CURRENT: > > [...] > --- nvidia_os.o --- > nvidia_os.c:283:19: error: incompatible integer to pointer conversion passing 'vm_offset_t' > (aka 'unsigned long') to parameter of type 'void *' [-Werror,-Wint-conversion] > pmap_unmapdev((vm_offset_t)address, size); ^~~~~~~~~~~~~~~~~~~~ > ./machine/pmap.h:511:26: note: passing argument to parameter here > void pmap_unmapdev(void *, vm_size_t); > [...] > > I took the liberty to file a bug for the port x11/nvidia-driver here: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266561 I uploaded reviews for both nvidia-driver and isboot-kmod yesterday immediately after the commit. I couldn't do them beforehand as they needed the new __FreeBSD_version value. https://reviews.freebsd.org/D36670 https://reviews.freebsd.org/D36671 -- John Baldwin