From nobody Wed Sep 21 20:09:43 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MXqJS17Tcz4cC6B; Wed, 21 Sep 2022 20:09:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MXqJS0kNSz3jT9; Wed, 21 Sep 2022 20:09:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663790984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZGn9FrtjMlHZNpeYGpouMpH9yD/pRP5hXItzjwh9oP4=; b=PIUPVjhhXAS5nLvIpcTFZNYJQlDcKfAmPfSvJwBwGqOXAChlCfT2xbfObqZa+2d0zdCEp1 wFzq8WlkHzmtLmuFbx2Qk2YdCvA4WvHnXM+/EfJ3iftRXnZ0wvYXmgvbKQqpDC8+c6ua6G FJeOCmY+ETob+O87yVk1fuIbK9DP+fRrhbtTYEnkiD5Rtv8cJTSOfSWaI6eQZ8jjyiLxxr BijiyyCW8LK/wL/kswEy+cUU229VUEzV9bbPLLArKcZM6SGKC0/j5uvo7j4OoFQA+YyzTM WIPEDOOE+uyzTQnLRfW8VZsuMoafiT8owm1nwGJ1SPStqpoGJhQasRGW2TgLiw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MXqJR6vyLz19GP; Wed, 21 Sep 2022 20:09:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 28LK9ho9050254; Wed, 21 Sep 2022 20:09:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 28LK9hOG050253; Wed, 21 Sep 2022 20:09:43 GMT (envelope-from git) Date: Wed, 21 Sep 2022 20:09:43 GMT Message-Id: <202209212009.28LK9hOG050253@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 22ea3be839ed - stable/13 - devstat: Remove DTrace io probes lacking a BIO reference List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 22ea3be839edcc877c4199081147499065595d09 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663790984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZGn9FrtjMlHZNpeYGpouMpH9yD/pRP5hXItzjwh9oP4=; b=AsT2Q+5OTszgF3Yh8TWNY8FKVxp2u4lnD9z4Y8KCBxeXp8BZf3JXXCQ3JzFFdRs6xrGBtD 9w+QjDEmbYh2y44RUCY+vYWeZ6JOEF6oOCMAEdBIzDGi4oempgwCCztgJbAxdwpveLH1NE cLx3/Rmoyln6THrDWLwtWU0r3M5w2qRH51Rfl3f3bMXrEX7K90x5xzul4paHSPOhxmujWb SMDZMdohAKXYPphGeB+0pXy2V6Gvkem+arYYM5U4tSmF830YZaa1wTPWUlqkaJWg1kwTnU eL2QGHaDwtOOWWSs3d4m+JVHLuBlheAhVN9wG0uJgwjFDuN5kfeDyK4yt6Bmeg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1663790984; a=rsa-sha256; cv=none; b=w9SdocWSrJWl8TpJiNVMcWHmfu0OUqfZWEpKLlgnAn/NKQlBsT1JI4aPCO64zMa0LQQOBq aFTI23Ly4dQcDid10K+j60offdZtB9lwbC1ab/gQscRKZ1hPz75RxXiBs3p9T+f9fBXj6B hyc5V1cRiRf7YhFyV5skj0Adhv+JIrTaU2xFstUY3pErk+J9n5Alk55JylUVcmUlTnKsY/ oY+E6Hhc/3CaEZXrw8BYcitONA72FAacxgW5PKNtG8PZ+29gEwgh+0g4pdN0H77dJYEtGh E8+OHTorSAix6iwjnThvKcEaLerlve0MS619PUeaUagGBdOlYI9KSP68rrXBZQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=22ea3be839edcc877c4199081147499065595d09 commit 22ea3be839edcc877c4199081147499065595d09 Author: Mark Johnston AuthorDate: 2022-08-29 17:22:36 +0000 Commit: Mark Johnston CommitDate: 2022-09-21 20:09:25 +0000 devstat: Remove DTrace io probes lacking a BIO reference The io:::start and end probes trace individual I/O requests. Also remove the unimplemented wait-start and wait-done probes. PR: 266098 (cherry picked from commit 32faf071bd54c0e2e1ac07700f7ea5a3d6fa8d51) --- sys/kern/subr_devstat.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/sys/kern/subr_devstat.c b/sys/kern/subr_devstat.c index 98a41fd179c2..7b6e778a327f 100644 --- a/sys/kern/subr_devstat.c +++ b/sys/kern/subr_devstat.c @@ -52,17 +52,9 @@ SDT_PROVIDER_DEFINE(io); SDT_PROBE_DEFINE2(io, , , start, "struct bio *", "struct devstat *"); SDT_PROBE_DEFINE2(io, , , done, "struct bio *", "struct devstat *"); -SDT_PROBE_DEFINE2(io, , , wait__start, "struct bio *", - "struct devstat *"); -SDT_PROBE_DEFINE2(io, , , wait__done, "struct bio *", - "struct devstat *"); -#define DTRACE_DEVSTAT_START() SDT_PROBE2(io, , , start, NULL, ds) #define DTRACE_DEVSTAT_BIO_START() SDT_PROBE2(io, , , start, bp, ds) -#define DTRACE_DEVSTAT_DONE() SDT_PROBE2(io, , , done, NULL, ds) #define DTRACE_DEVSTAT_BIO_DONE() SDT_PROBE2(io, , , done, bp, ds) -#define DTRACE_DEVSTAT_WAIT_START() SDT_PROBE2(io, , , wait__start, NULL, ds) -#define DTRACE_DEVSTAT_WAIT_DONE() SDT_PROBE2(io, , , wait__done, NULL, ds) static int devstat_num_devs; static long devstat_generation = 1; @@ -245,7 +237,6 @@ devstat_start_transaction(struct devstat *ds, const struct bintime *now) binuptime(&ds->busy_from); } atomic_add_rel_int(&ds->sequence0, 1); - DTRACE_DEVSTAT_START(); } void @@ -341,7 +332,6 @@ devstat_end_transaction(struct devstat *ds, uint32_t bytes, ds->end_count++; atomic_add_rel_int(&ds->sequence0, 1); - DTRACE_DEVSTAT_DONE(); } void