Re: git: 2c2ef670a79b - main - pseudofs: use the vget_prep/vget_finish idiom
Date: Mon, 19 Sep 2022 20:41:19 UTC
On Mon, Sep 19, 2022 at 1:09 PM Mateusz Guzik <mjg@freebsd.org> wrote: > The branch main has been updated by mjg: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=2c2ef670a79b7f8fa84796a04885a3f76c914762 > > commit 2c2ef670a79b7f8fa84796a04885a3f76c914762 > Author: Mateusz Guzik <mjg@FreeBSD.org> > AuthorDate: 2022-09-19 20:07:10 +0000 > Commit: Mateusz Guzik <mjg@FreeBSD.org> > CommitDate: 2022-09-19 20:08:40 +0000 > > pseudofs: use the vget_prep/vget_finish idiom > > Picking an arbitrary commit to reply to: could you please add a bit more detail about the "why" to commit messages in the future? Having looked a little bit, it seems that this would be "as part of the broader effort to remove the vnode interlock [from a specific class of operations?]". A pointer to a bigger-picture doc would be great as well. I co-maintain an out-of-tree filesystem and commit messages like this make it really hard for me to get a handle on whether I need to do anything and, if so, where to start looking to find out what to do. An overall project page would be a great reference, or even comment around the implementations that points to a key differential revision that implemented the core behavior. One of the things that's been really nice about developing for the FreeBSD VFS in the past is how easy it is to determine what a filesystem implementation needs to provide, and I'd love to see us continue that tradition. Thanks, Ben