From nobody Fri Sep 16 22:24:13 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MTpWx37qJz4cGq0; Fri, 16 Sep 2022 22:24:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MTpWx2cPkz3k7p; Fri, 16 Sep 2022 22:24:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663367053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1iQF+SN/x4fi9cHY3aoHWweLtCqsaE41fsXDxdrsKwI=; b=iT9+QhnFUEyayN3la0XIwIu5CR27raKLph3Z3rrO4GDEYnicedK3mC/d9WXOtuuklyNgAq pDvNFykVl0SY8yqKQBJsFhmKDhQoTSsM/1MQwjUIa2UitbYalSgIPSaWIUriyT0a+13rWk xF7vUUxrABY6lMNuiux85V2upQYHfVRvMwZ5gp+PwYa+kpM6L+kVPUYfPNsi8DDM3g9pzG gavt6089ctYbTvbjBKyx952njG0g/0dilltm8/4nU6b9T1EeL2eZQ/d7keEaGgZ43rLkOU 5ygyTJmwHIAw5JtA8JYNdYW43mLu9e9ttnTc4F1bpb4WPI1Bljb3wEGyjUFDng== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MTpWx1gTJzW04; Fri, 16 Sep 2022 22:24:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 28GMODbf075624; Fri, 16 Sep 2022 22:24:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 28GMODvY075623; Fri, 16 Sep 2022 22:24:13 GMT (envelope-from git) Date: Fri, 16 Sep 2022 22:24:13 GMT Message-Id: <202209162224.28GMODvY075623@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Rick Macklem Subject: git: 9432f23197d8 - stable/13 - nfscl: Add a console message for session recovery List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 9432f23197d8feac68f42066059638db27a2864c Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663367053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1iQF+SN/x4fi9cHY3aoHWweLtCqsaE41fsXDxdrsKwI=; b=Oc+hXwVGa5ymxIqcJniVzrxRLWwM96v40cc4nTkMHRKTDQjZRGWi7mb2bhR6rCjFhS5zsi WT1UKb7gIZZ/q0VqxcMNIEjf17h6H2iA83mV9vVxNjajB+uwqXJoHao9HjBvbXgf4rLWKM 484hejlM4MHJ2PgpY5eFhbGn96O6MBmX89lMOxqoWlWVEKH/sal7u85PrfFFjpV6vLmdlX luLCg+xRFSFQ5FMotjxfeAIyorUZXvByYS06Wv+slMVPPmQsKFdhwEYZQizscvsyyHygkN O5uUGxn8tsaUPHajsyNXf+pbtF5zZZztRgzEOgHMXwxXStr7DBs3JuEwuN8xnQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1663367053; a=rsa-sha256; cv=none; b=jPWMEi/tE1ODSwwdpcZJNqgYwXHYqV6ieXWkcpUV0FoXw+lqLy/ldNGvjsW8+R3BE+MLFC Y2O9Eo8LtQ6UkRsv1pmjWvLMnYTEQYiPFAoui9NVaHAdlF4KgTgsFLBk/hWHP5lgBUPNz4 7SJyGBTX2u7uKiFx6tmGwjzZvsjthauy/4VBtyYOrkMx561z/zQZrbhvlSxaHGiK6bVOQP NU6NUhsu/wtE7s7ug6LRosVnIpJswbn7PjxGrci6MaLRYZxqasFaAejN1Q5wtDZpPsJ9j7 PmaQq3zXPdYpM8lz3wsmlzDtQtPdG+sfldAtXmvX4DlbDMQ6UNUG8KhdKabGSw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=9432f23197d8feac68f42066059638db27a2864c commit 9432f23197d8feac68f42066059638db27a2864c Author: Rick Macklem AuthorDate: 2022-08-28 21:24:39 +0000 Commit: Rick Macklem CommitDate: 2022-09-16 22:21:11 +0000 nfscl: Add a console message for session recovery The NFSv4.1/4.2 client does recovery when it receives a NFSERR_BADSESSION reply from the server. If the server has not rebooted, this is often caused by multiple clients using the same /etc/hostid and, as such, not being recognized as different clients by the server. This trivial patch adds a console message to suggest that client's /etc/hostid's need to be checked for uniqueness. (cherry picked from commit 0685c73cfe88b94d60b1b2ddfdb36c684a008006) --- sys/fs/nfs/nfs_commonkrpc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/fs/nfs/nfs_commonkrpc.c b/sys/fs/nfs/nfs_commonkrpc.c index 91ebd84fabd0..9badd8be47d4 100644 --- a/sys/fs/nfs/nfs_commonkrpc.c +++ b/sys/fs/nfs/nfs_commonkrpc.c @@ -1131,6 +1131,10 @@ tryagain: sep = NFSMNT_MDSSESSION(nmp); if (bcmp(sep->nfsess_sessionid, nd->nd_sequence, NFSX_V4SESSIONID) == 0) { + printf("Initiate recovery. If server " + "has not rebooted, " + "check NFS clients for unique " + "/etc/hostid's\n"); /* Initiate recovery. */ sep->nfsess_defunct = 1; NFSCL_DEBUG(1, "Marked defunct\n");