From nobody Fri Sep 16 22:20:52 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MTpS45xXcz4cFwT; Fri, 16 Sep 2022 22:20:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MTpS45PQ1z3hdg; Fri, 16 Sep 2022 22:20:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663366852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CYZKABDEwdt4RbOzVevT6vMXdtqvMm2oyjnpG8cugfQ=; b=bok/O1CL9WKRHJJG2FndMCqQ6Cx9pcKGhA7ma6lqeXkvRCVaSlzY6oKkr1sNa8NW/e/+bD meDq7Z2VeoWmSfAoPLe6+cdzfHmflA/hVLXVjiLxpbH/nX9ZI5ejyt7oZPb6ZYFd6HAWqJ xf7ZqLGH/6Iql0ozgmEYtB08bEhpAxFOyLuzqddEDdpyHR2xmdXkTofiUhqlZxGH1x6UoI VuODUaogWyJadfvb8KnPpO37M1d3SKyq8zMajf1ybypSbSoRrSzzYiK+QmXR52xytiKrpd 2Seb4gVVZCImjgojKZH9fixSmfA1OAdPwVjlZfwyTd5LBL+5qlFrkNFX5wt7OA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MTpS44TYPzVws; Fri, 16 Sep 2022 22:20:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 28GMKqiI071630; Fri, 16 Sep 2022 22:20:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 28GMKqAd071629; Fri, 16 Sep 2022 22:20:52 GMT (envelope-from git) Date: Fri, 16 Sep 2022 22:20:52 GMT Message-Id: <202209162220.28GMKqAd071629@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Rick Macklem Subject: git: aa5a54d5a738 - stable/13 - nfsd: Update console message for no session found List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: aa5a54d5a73865bc76a70b14baa319e6307d07f0 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663366852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CYZKABDEwdt4RbOzVevT6vMXdtqvMm2oyjnpG8cugfQ=; b=UxS4t3MeWm3ayr4OeJLVOaq21RnvrQM/K5xdKTS0duuMl467JNgHt6x0fG+W4YZ/BLw5WU JkyWHZJYZJvFf9sYsdfwUF/PUinS16RyKYUGYWQkpb4GLAn3m5qta/eTa7Q5l5SdrQxoQo 2J64hsoo5ElYaJPLAy0njDp62g6nQjplMS/ddbVDWJbcEkgJ/XwJhBpXgshauqaqM1Zw9h gmTKXVSE/mlM1Ak5PIdcs4J/VMHXXD+NITr4zyW9wSEcUL6NKeLP1Hk/XSowo8hF4Dtf8i OXDo9E+G6LfZcYdiPz17KQ6gys7Bg1lL7oo36jxSuyftZ7C626UA9Fe+FPobJg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1663366852; a=rsa-sha256; cv=none; b=FWTa2gn2cF49N4SDXEu4WBAPONS/jJdoa2TNwYE04pe+5M9afpsZ/s7LZcsmt04ylmbVrw QXhPVSzickaK+xHqSMltc5iCzsNrXXoT2oBbmACBG3DbCEixCeOXS8DIwXEPXBunkDheGS dG0MY0L6tP7Q0nVFR6fRsZyPH5BN2r4s1g+6BQXHJZBLmoYl5BKaxMUzUnH5OpWNSx0ni8 /mC+hlSC6yJRMsY+7onDLn+GWBOa3eyYrLTwCcaZ4C2ewhPskjcMrawPTEIaVf0Xf66Wpn UvEV+00pydM3keyXdFmouUTfM+n131vXu8EjjffVK18VmhwjtIBkp8VDWAS7bA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=aa5a54d5a73865bc76a70b14baa319e6307d07f0 commit aa5a54d5a73865bc76a70b14baa319e6307d07f0 Author: Rick Macklem AuthorDate: 2022-08-28 01:31:20 +0000 Commit: Rick Macklem CommitDate: 2022-09-16 22:17:34 +0000 nfsd: Update console message for no session found The NFSv4.1/4.2 server generates a console message that indicates that there is no session. I was until recently perplexed w.r.t. how this could occur. It turns out that the common cause is multiple NFS clients with the same /etc/hostid. The host uuid is used by the FreeBSD NFSv4.1/4.2 client as a unique identifier for the client. If multiple clients use the same host uuid, this indicates to the NFSv4.1/4.2 server that they are the same client and confusion occurs. This trivial patch modifies the console message to suggest that the client's /etc/hostid needs to be checked for uniqueness. (cherry picked from commit b875d4f5ddcbe0ce06f22650dd471b7518546dd6) --- sys/fs/nfsserver/nfs_nfsdstate.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sys/fs/nfsserver/nfs_nfsdstate.c b/sys/fs/nfsserver/nfs_nfsdstate.c index 6b2a6e56795d..d7dd69dad9d7 100644 --- a/sys/fs/nfsserver/nfs_nfsdstate.c +++ b/sys/fs/nfsserver/nfs_nfsdstate.c @@ -6383,9 +6383,12 @@ nfsrv_cache_session(struct nfsrv_descript *nd, struct mbuf **m) } if (cp != NULL) printf("nfsrv_cache_session: no session " - "IPaddr=%s\n", cp); + "IPaddr=%s, check NFS clients for unique " + "/etc/hostid's\n", cp); else - printf("nfsrv_cache_session: no session\n"); + printf("nfsrv_cache_session: no session, " + "check NFS clients for unique " + "/etc/hostid's\n"); free(buf, M_TEMP); } m_freem(*m);