From nobody Tue Sep 13 14:34:45 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MRmFh1QKkz4cWK2 for ; Tue, 13 Sep 2022 14:34:48 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MRmFh0ys6z3ysj for ; Tue, 13 Sep 2022 14:34:48 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wm1-f42.google.com with SMTP id o5so5555290wms.1 for ; Tue, 13 Sep 2022 07:34:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=B5lewg5pmvUAu8balzjjpJGwIsYoRIcozv5KVD9inew=; b=vpvHeray6uSFJ3mdpXmlxz4YojQ6EbxHL63wXbT5JdB2HGd+rapasfpAM4+X6Rd9TW 5PbNYN1x09LSoTQK4kaUmejkmHTO6JJs7p3+gfNZTUywzBq35XIkQ4RVdzFgm5logmwW VS420i6zkBXeN1+8nZR0k8aYgNf2LyCgRfZO/OOzL1bhYdydxBE6OlkL/hLZPg9RD5ad MYhUXAr2FRrot9E/1JDVAxkmGFUMmJ5x1asvSVGN5mR9BGnfxL/VsyhRsZ9Xd7B6Krgn ZXKErNj3mj7/ZJxti7WSdZY93whyRZRn8/n98mLgTiY9j1US6RjhVeeDLCN0EaBhLilo 4CxA== X-Gm-Message-State: ACgBeo3nNXcN62/uyAQNx6Q5p9QXj++9JRkb5ClXSLYzeCNU0P55eXAm J4WMK4FSfcA7b1Z+G9HB4XKLBw== X-Google-Smtp-Source: AA6agR5etC9j7OhkpplJKDhZeF6KMvgchgr8tPVF7MwLLYwpbJbwxHi4YH2XN+m1Div3vyGAbbakfA== X-Received: by 2002:a05:600c:348c:b0:3b4:85b6:e7c5 with SMTP id a12-20020a05600c348c00b003b485b6e7c5mr2740396wmq.45.1663079686834; Tue, 13 Sep 2022 07:34:46 -0700 (PDT) Received: from smtpclient.apple (global-5-141.n-2.net.cam.ac.uk. [131.111.5.141]) by smtp.gmail.com with ESMTPSA id l1-20020a05600002a100b00228d183f9c2sm11903998wry.89.2022.09.13.07.34.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Sep 2022 07:34:46 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: git: 10c6af344108 - main - bhyve: Fix build when BHYVE_SNAPSHOT is set From: Jessica Clarke In-Reply-To: <20220913163250.199f7ae9cf021249846a9133@bidouilliste.com> Date: Tue, 13 Sep 2022 15:34:45 +0100 Cc: Mitchell Horne , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , John Baldwin Content-Transfer-Encoding: quoted-printable Message-Id: <526E3D8E-895C-476E-BB7C-F2EE61DA456E@freebsd.org> References: <202209130632.28D6WdW9021176@gitrepo.freebsd.org> <9903ef54-80a9-67e6-f9ab-1371c42916ff@freebsd.org> <20220913163250.199f7ae9cf021249846a9133@bidouilliste.com> To: Emmanuel Vadot X-Mailer: Apple Mail (2.3696.80.82.1.1) X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4MRmFh0ys6z3ysj X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On 13 Sept 2022, at 15:32, Emmanuel Vadot wrote: >=20 > On Tue, 13 Sep 2022 10:49:46 -0300 > Mitchell Horne wrote: >=20 >>=20 >>=20 >> On 9/13/22 03:32, Emmanuel Vadot wrote: >>> The branch main has been updated by manu: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D10c6af344108a8cfdc431b5b304de9c0= fddcec47 >>>=20 >>> commit 10c6af344108a8cfdc431b5b304de9c0fddcec47 >>> Author: Filipe da Silva Santos >>> AuthorDate: 2022-09-13 06:30:41 +0000 >>> Commit: Emmanuel Vadot >>> CommitDate: 2022-09-13 06:32:09 +0000 >>>=20 >>> bhyve: Fix build when BHYVE_SNAPSHOT is set >>>=20 >>=20 >> Can this option be added to LINT? >>=20 >> Mitchell >=20 > Probably should as it would have prevent this, but I'm not sure of why > this is an option currently, John ? It disables capsicum support as the two aren=E2=80=99t currently = compatible. Also, LINT wouldn=E2=80=99t help, this is userspace not the kernel. Jess >>=20 >>> Fixes: 9cc9abf409cc ("bhyve: create all vcpus on startup") >>> Sponsored by: Beckhoff Automation GmbH & Co. KG >>> X-MFC-With: 9cc9abf409cc >>> --- >>> usr.sbin/bhyve/bhyverun.c | 1 - >>> 1 file changed, 1 deletion(-) >>>=20 >>> diff --git a/usr.sbin/bhyve/bhyverun.c b/usr.sbin/bhyve/bhyverun.c >>> index 550cc9d15477..27f1d8ea8892 100644 >>> --- a/usr.sbin/bhyve/bhyverun.c >>> +++ b/usr.sbin/bhyve/bhyverun.c >>> @@ -1244,7 +1244,6 @@ main(int argc, char *argv[]) >>> #ifdef BHYVE_SNAPSHOT >>> char *restore_file; >>> struct restore_state rstate; >>> - int vcpu; >>>=20 >>> restore_file =3D NULL; >>> #endif >=20 >=20 > --=20 > Emmanuel Vadot