From nobody Tue Sep 13 03:10:53 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MRT4Y32JSz4cB5l; Tue, 13 Sep 2022 03:10:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MRT4Y2Xvsz4Hkv; Tue, 13 Sep 2022 03:10:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663038653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=z0hL1aGXd0aKDVYdW+a+rygdxBxd1RVKttOGt4BzKH4=; b=uVspUaKYw8C/k1BQVQMwrS6YbwWOHlgzOECXHEuINpvymJrnTtEWgmUuTeha2/i7JSMZGg FzQCDk50Vkx+bBJQPN3uyJ6ZKiqs/Yj4AfcMaJJQtU/DNfybarY2mK3ZB7hlnDOcgmcmLg V9ht/jcpWD5F0UU0aYagMQhiXEM+1BNu3zbgLkk+sQjPSgysjy+W78ep+jfUcGexe9s1KC ccyAWcChQEHD39R+a2qooAzmdMwUIKDunTas+ix0IS9RWBXlGg+5gNWJxttrmT/wd3whu7 NoRS4E6kzYm7O/0Vx/TEY6rRD5CuymOYD9ZOOQ8J+u9fGdeiQFutXPg/0Jl04w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MRT4Y1dD9z1BWW; Tue, 13 Sep 2022 03:10:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 28D3Ar2R069804; Tue, 13 Sep 2022 03:10:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 28D3ArH6069803; Tue, 13 Sep 2022 03:10:53 GMT (envelope-from git) Date: Tue, 13 Sep 2022 03:10:53 GMT Message-Id: <202209130310.28D3ArH6069803@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Adrian Chadd Subject: git: 82302a49fde3 - main - qcom_tlmm: use return code instead of always returning true. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 82302a49fde3ff063e4f8187fc3ddf355084f786 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663038653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=z0hL1aGXd0aKDVYdW+a+rygdxBxd1RVKttOGt4BzKH4=; b=ANS4rQ1Gc7eauI5aBo8Fq4I1u7XyROwldD+oHwByF1BRXhuVbQ8WDeaxX1vk/ZkiLNL6jX EzSi/LhloNPAiVucHhUChl6w5ryAZhIDztWzS9HueHyBon+5WM3jtaVfrbLCIroHFjRo6F fOv6dIK0COaxmhj0bUWn5jz0JdGNr+YPlrL1dcqxiku86K7/SVNwXv5uPW2mVeiL7ExvGo xVPpW3Z6n172pBDPPW/q4aXyY3TSpnyRzB2eB3PSxIlao4WO7VUVWIxxceGL0TNIHdaKgs fhbTeqxf4mUK1UsGjxPRmMOtzhQox1EFaF4Yw9t48NEnGYtaR1M+hGciiGaABQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1663038653; a=rsa-sha256; cv=none; b=IwCXUIMmZ8jKyobKc91k3eu8ltUzPoNFhFKV0egCmrwOcgvLSabMIHPYppbkBOCH4QKWu+ 2ZSQThb126Z4Zx+PcLbtC4edSATwxcm/9WREq7d1ZF0AfibIbwneeQzTfF/rMUVNd8UG4w gkzdsuJNdqutW7I25v6S7YkpxwdlpyNsVAUy4HsWtOC5HzgyonA9R9fikZQ5WC4mmNYLUm JrmIF8w9WiyWlXgusdSygnZS4bnS1tchfEUJxr689fQtmpSgtifdJyklgLEfdcJY4hjgy3 0W/sTQc4NDYlj0Y0JT5oyWQMxl4C/FcMKSb1nCcXmrlrQEyHRUessx7KO+4TGA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=82302a49fde3ff063e4f8187fc3ddf355084f786 commit 82302a49fde3ff063e4f8187fc3ddf355084f786 Author: Adrian Chadd AuthorDate: 2022-09-12 02:33:48 +0000 Commit: Adrian Chadd CommitDate: 2022-09-13 03:10:25 +0000 qcom_tlmm: use return code instead of always returning true. This was failing due to unused/ignored return values; so just use them. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D36534 --- sys/dev/qcom_tlmm/qcom_tlmm_pin.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/qcom_tlmm/qcom_tlmm_pin.c b/sys/dev/qcom_tlmm/qcom_tlmm_pin.c index 0d35908a58a6..6974041fe0d9 100644 --- a/sys/dev/qcom_tlmm/qcom_tlmm_pin.c +++ b/sys/dev/qcom_tlmm/qcom_tlmm_pin.c @@ -257,7 +257,7 @@ qcom_tlmm_pin_set(device_t dev, uint32_t pin, unsigned int value) ret = qcom_tlmm_ipq4018_hw_pin_set_output_value(sc, pin, value); GPIO_UNLOCK(sc); - return (0); + return (ret); } int @@ -273,7 +273,7 @@ qcom_tlmm_pin_get(device_t dev, uint32_t pin, unsigned int *val) ret = qcom_tlmm_ipq4018_hw_pin_get_input_value(sc, pin, val); GPIO_UNLOCK(sc); - return (0); + return (ret); } int @@ -289,7 +289,7 @@ qcom_tlmm_pin_toggle(device_t dev, uint32_t pin) ret = qcom_tlmm_ipq4018_hw_pin_toggle_output_value(sc, pin); GPIO_UNLOCK(sc); - return (0); + return (ret); } int