From nobody Fri Sep 09 09:14:52 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MP9LR1w93z4cBNl; Fri, 9 Sep 2022 09:14:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MP9LR1L2Gz3Pp6; Fri, 9 Sep 2022 09:14:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662714895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dCGZVy304SJRJJgbjl3Bv+NUO31EzkkRtXyM+JXm+Rs=; b=B3ROhhOWMDxW/7xTQggzkOPUZIq5yOtbR6PLbVvt4YEL/3d9qPUnvWJjFBt7M9Xo9YqZD2 2qY6mcUC2OmxoJZNkpgPVznXflZLlFfBeOhU+fy1TU+fxpNfH3C8pl+otz6f6SyAumkQP5 RGrq88YczWRH4nptRqGrsBVo7m2ERXgznn2GYACptmLOk/44PxrYc78NsEE+xTXGfSGwPy DjUVX0lFKf2qYXhYQuemqnajoY1VizUKBTNfuIrMpno2UnwwGLioxL6atJQY0h51qx2dqy WdHvRw6ZjrBQBkmuwYGmns6coKA5Plf2M4XkhUBnNnF49r2g7kQKHHX7Lp22Jg== Received: from [10.248.121.120] (global-5-144.n-2.net.cam.ac.uk [131.111.5.144]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MP9LQ3vYyz1DDC; Fri, 9 Sep 2022 09:14:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Fri, 9 Sep 2022 10:14:52 +0100 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: git: f0d4c2afd65f - main - pmc(3): Correct some typos in event descriptions Content-Language: en-US To: Gordon Bergling , Ed Maste Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202209041052.284Aqvu2007702@gitrepo.freebsd.org> <05b97d9c-ff1d-0da2-ee22-0c054e853a77@FreeBSD.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662714895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dCGZVy304SJRJJgbjl3Bv+NUO31EzkkRtXyM+JXm+Rs=; b=DsIeaozafxrmT/XriS4FcE1lvH2oPu/H3NU4CzzSWVk929+7M4Ri6pQASX6HyMkzPkshtd Z4kJC34pqW1WGuqOVrb7OIBVMXV/AsGm0dWAJcproh4CaAPZ8ltcxGYd7L2yO1jb89icgZ /nsZlxRoQ9f3/MMp+w9fHrEH2DJeWHVtSIe20uCLIUnC3OvHCpXjcN28DAWOq0GpvUO7NU 4nfm/phuVw5CWvEzsukwZdpHGAdPdI7FlimFAUYL1/8HIdO1rr8jQVFw6qB4ik8StffdjK YLcuPnZeeYEiHRFIqpGKqe2tqYKGzBUJ1MmB42ys2gXYRxlKgP8EZHpy3q+2jw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662714895; a=rsa-sha256; cv=none; b=bjxGL2FhWXpaEui0XwpwxVBNsO6x1TtYpEVhiKxaoZIOB4yqM6xK+xWXv1CA2wN+zirMQ0 cGDXFkMW5rBYUlLy/vKRdtKQGAgRdbr2yxhmZZsl0e71La12C9mja2aII2MCnPL0AtmjBh TzAKVHkt2qu5Q/1UiC6B0wVhqCXbnHVKC/JZDoulspTTG9H8CfawHDkMaKWOo/qICJSf8F ySVirEJYv/FUHTEXnqMmcRuempd8msSAaNisHwYlO0U3qpLufDpx1XW8qK0uuiXoioN12u Vk75L+2IVKXY/KXsddfxA1NYGK3qv7/hjzRRq5Hlp0offv2m+Y+VbjIn+u71/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 9/9/22 8:03 AM, Gordon Bergling wrote: > On Thu, Sep 08, 2022 at 09:32:32AM -0400, Ed Maste wrote: >> On Wed, 7 Sept 2022 at 13:41, John Baldwin wrote: >>>> --- >>>> lib/libpmc/pmu-events/arch/x86/broadwell/pipeline.json | 4 ++-- >>>> lib/libpmc/pmu-events/arch/x86/broadwellde/pipeline.json | 4 ++-- >>>> lib/libpmc/pmu-events/arch/x86/broadwellx/pipeline.json | 4 ++-- >>>> lib/libpmc/pmu-events/arch/x86/cascadelakex/uncore-other.json | 2 +- >>>> lib/libpmc/pmu-events/arch/x86/silvermont/pipeline.json | 4 ++-- >>>> lib/libpmc/pmu-events/arch/x86/skylakex/uncore-other.json | 2 +- >>> >>> I think these files are actually 3rd party (and should really be under >>> contrib/ in that case?) so probably shouldn't be changed. Maybe you can >>> send the changes upstream to Linux instead? >> >> Yes, these come from Linux and the fixes should be sent there. The >> process is a bit cumbersome but at least well documented; I've done it >> for a couple of pmu-events files before, e.g. >> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=28396b7df09b9565f404591c9945eac43526cb3f >> >> The process is documented in the Linux source tree at >> Documentation/process/submitting-patches.rst > > I wasn't aware that those event files come from Linux. I will submit the fixes upstream. > If I remember correctly I have done some more spelling fixes, so I diff the > whole directory against recent Linux sources. > > About the move to contrib, I could do that, but before I invest work in that > direction, a decision should be made before that. Oh, the contrib/ comment was meant more for Ed perhaps or whoever has done previous imports from Linux and is thus the more active maintainer of these files. -- John Baldwin