From nobody Wed Sep 07 20:11:28 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MND0w4t63z4c2Bx; Wed, 7 Sep 2022 20:11:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MND0w443cz3MCC; Wed, 7 Sep 2022 20:11:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662581488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bVdpB1+YpZyPUs9WzxHyL/BR8761g1YCzJEAWkMVcN4=; b=ciFGooYou1KEG0dnc3D3628rASFPcOExIzCAv8q+l0wExvaOwzme5bOTObbwaAqXE3ggD0 89HbPEp5N9fyURikCAWgmSWj2iu3xSl3Ui4ui0Jz1/klnCGMs57usAw3ozJ4bgwxiD2SSj 1sbBYWtEMY1nDGh4mvvvdZTGVZxe1iF3dqc3faOqofikh5c5POB45s7EqHsUCWzDwMP5Rk fdsb8qjwGApvALw48uKIqT0bhb1Yh8W2m9PfA8HL68h5xv6Kqunfnfesar5pdZgmHmn2j5 QW5mOfHmg0PM0Fpn13rmVzAYdL/+CLRbiVbzG2f8DqNVWKc17x4V2yibSy1nxw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MND0w37bVzdpy; Wed, 7 Sep 2022 20:11:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 287KBSUg002565; Wed, 7 Sep 2022 20:11:28 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 287KBSF5002564; Wed, 7 Sep 2022 20:11:28 GMT (envelope-from git) Date: Wed, 7 Sep 2022 20:11:28 GMT Message-Id: <202209072011.287KBSF5002564@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mateusz Guzik Subject: git: 3e0b4868869d - main - vfs: flip a condition around in kern_statat List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3e0b4868869d4373aeebae01ad777def318ce14f Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662581488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bVdpB1+YpZyPUs9WzxHyL/BR8761g1YCzJEAWkMVcN4=; b=upSbw4TkobkGZIjP6eKmPREhzOP/33SkCtJKX1ZjGE47iKhWl5ZRI7b3jJT30a40RRNMFQ EZAhleNPK3cpRAhAF4QWywtNyCiupADufAprvEUsZTDm4cWe8Pb874yJhJl7zMSs0lbJ8o 8mLcls7ICXTgnxQ7wjrMrJLawHOL9CViFAgUflBeaxPh19L5vxEteeCKZFbVmsuPLPZ3qI dDCoXPJjlTnN4e3tD8XivVxuN+BOoP0d/CwpIuCsDsZE2HEiz3eP0LJjQoTuGeoWfAVkYY 4cNdUjH5BkJIZnJ3fwzPtFpz3SAWSzoo3iT0NOgdSfXFcHI3pBeKpE1gsZ1pQw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662581488; a=rsa-sha256; cv=none; b=o9ZrSZyqiMuu+UQHtUf8cEAkd9tdABPFGOkX2dgrEL2cgVN+Qet5CW7Rd3CcCNj2Y7+yOg PGqrxBO/vAHQvzwziwM/3kMTywNa3JfnG9h1+5vbNXzyMvok4DlDjFwVW+vXp3+EUR56ki TVhMrbhH3moTHSyj8yGfuTK9/Fdh3Jzbr8FpZokgXjgC0vaiBJ9nS7xBFhsaiDQKdmOSQU Aq1+urA5hBnKDQy0wYGg2PYFGfxFmrMfgcI+1Xmg0vbN7cXmny+3isvP5+iBTKplgUqmZV NXKPOIdN9E8YnicpA34eU+3OX6wHPQtt8LKwv6+2bgQFyJ/RYz/lKFQ+BdZHXA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=3e0b4868869d4373aeebae01ad777def318ce14f commit 3e0b4868869d4373aeebae01ad777def318ce14f Author: Mateusz Guzik AuthorDate: 2022-09-07 20:05:32 +0000 Commit: Mateusz Guzik CommitDate: 2022-09-07 20:06:24 +0000 vfs: flip a condition around in kern_statat error tends to be 0. --- sys/kern/vfs_syscalls.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/kern/vfs_syscalls.c b/sys/kern/vfs_syscalls.c index c40d1092574e..85f85c5f1a99 100644 --- a/sys/kern/vfs_syscalls.c +++ b/sys/kern/vfs_syscalls.c @@ -2450,9 +2450,10 @@ kern_statat(struct thread *td, int flag, int fd, const char *path, return (error); } error = VOP_STAT(nd.ni_vp, sbp, td->td_ucred, NOCRED); - if (error == 0) { - if (__predict_false(hook != NULL)) + if (__predict_false(hook != NULL)) { + if (error == 0) { hook(nd.ni_vp, sbp); + } } NDFREE_NOTHING(&nd); vput(nd.ni_vp);