From nobody Mon Sep 05 13:48:19 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MLqbq1CWBz4cRfn; Mon, 5 Sep 2022 13:48:23 +0000 (UTC) (envelope-from gbe@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MLqbq0fncz3nHv; Mon, 5 Sep 2022 13:48:23 +0000 (UTC) (envelope-from gbe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662385703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HN6Vx+bgFf2hOhqeEZJnk130X6c5QhNK+mgqaMNwRTI=; b=bmttjynRI2FWI/6dRXUo64gK0knSRNhwz4Q9MBVQlNV5zmG5udeCAdl2alhSe9vWUnLrNf fN2gEczxUG0G4Utxxtodp9VSEhJkB7Pg2mv4wiwTb4Lhwzpkz02tACVvvHCszvmu5kWM0c 53U9IbXnoSUyuMpopolYKxmDGGDqRBQMshwIuxbt91WEamkCSVlVtVkLxnHKelH1tBUlK+ Qoc2Z69GY49+iFKhAENssBo+uwjB5Z+d0h1vZLMMuqxGBZljT6CqWQ/pi+IcILOstRGDs1 z6T7KiPYfuMpe5sBwEyF0IRpRqxvYCZym2JNRw1EdjNatzupif+loqIobSVYeA== Received: from localhost (p200300cb870da548b1a0edc0d06c0512.dip0.t-ipconnect.de [IPv6:2003:cb:870d:a548:b1a0:edc0:d06c:512]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gbe) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MLqbp3flKztls; Mon, 5 Sep 2022 13:48:22 +0000 (UTC) (envelope-from gbe@freebsd.org) Date: Mon, 5 Sep 2022 15:48:19 +0200 From: Gordon Bergling To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 8ca67bf1273a - main - usb: Remove a double words in a source code comments Message-ID: References: <202209041540.284FeabC070627@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: X-Operating-System: FreeBSD 13.1-STABLE amd64 X-Host-Uptime: 3:46PM up 6 days, 2:10, 2 users, load averages: 0.41, 0.25, 0.18 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662385703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HN6Vx+bgFf2hOhqeEZJnk130X6c5QhNK+mgqaMNwRTI=; b=Ydx/moizZnnRswCjAlqeIPeDCdmMUkgXb53TvVE3IfUoff5SFe4oG5MnBz4ZSCAb+jH59g OepjLcHV7wFZ1UYF2Rpey8y8fCc1TE6+CFpfzS6ZVRXeyekzyekySD59888rYQScjEyasa X2YPDLg/Lp9CaaRVcVRtkZhSZL1EgHIrUHSDqYNGFFon7/MxPgLm3rzamJnEIhDcXCCBxR pVtvxSruTpiloZGIKEKUHpmVTjjmXzN1e0SnS9PaCj5wM0HUlEG62sLBXVs3CO7TsgS8V2 w2Lg2h1RfekyTvze+dKMkM3zCF0cYUQEqhxaQDChZgqPDUHiW6EL47yvkITDVA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662385703; a=rsa-sha256; cv=none; b=w60pySfS6B2XHPMUjDLvScrPJb1zDua9laGK2iQZ85l66zq8WkyxmNGu4fDXreNwBRNzo+ aHKH3CtD4U0oS2pYaVFMFEYWj3tV3KY7JZC3cGWxraJLHCggBwngTzDi7+QbOrhL365CeG NnNT413syUp8kW1MJjPoD2wFcCaMsVoFQX0ylloiALOeCbneojxmx22V7RTwPfmscOZmla MSeffwih3WYFJ/XB2YDDB0if5SJcJ+1j4PmXmmGEtMUDKI5kDtlsY2fFGkw9mjhbG5hvIr PNjl3yTGwMXG2Uv6snEatY0loyNSfuD8i0jXWg2YfIeD4kj0sQZnEMP8bXPtgg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Thanks for the feedback, corrected in 94466c432ed611a49cacae7ff99b224b37c906bb. --Gordon On Sun, Sep 04, 2022 at 10:36:47PM +0100, Jessica Clarke wrote: > On 4 Sept 2022, at 16:40, Gordon Bergling wrote: > > > > The branch main has been updated by gbe (doc committer): > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=8ca67bf1273a5168f8a3787183159c477632e582 > > > > commit 8ca67bf1273a5168f8a3787183159c477632e582 > > Author: Gordon Bergling > > AuthorDate: 2022-09-04 15:40:25 +0000 > > Commit: Gordon Bergling > > CommitDate: 2022-09-04 15:40:25 +0000 > > > > usb: Remove a double words in a source code comments > > > > - s/that that/that/ > > > > MFC after: 3 days > > --- > > sys/dev/usb/net/if_muge.c | 2 +- > > sys/dev/usb/net/if_smsc.c | 2 +- > > sys/dev/usb/usb_busdma.c | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/sys/dev/usb/net/if_muge.c b/sys/dev/usb/net/if_muge.c > > index 3087eb40b40a..c705fcd56eed 100644 > > --- a/sys/dev/usb/net/if_muge.c > > +++ b/sys/dev/usb/net/if_muge.c > > @@ -1556,7 +1556,7 @@ muge_set_leds(struct usb_ether *ue) > > * @ue: the USB ethernet device > > * > > * This is where the chip is intialised for the first time. This is > > - * different from the muge_init() function in that that one is designed to > > + * different from the muge_init() function in that one is designed to > > The original comment was correct; changing it loses a key part. > > > * setup the H/W to match the UE settings and can be called after a reset. > > * > > */ > > diff --git a/sys/dev/usb/net/if_smsc.c b/sys/dev/usb/net/if_smsc.c > > index e3b4ae9a5cbd..c34cc85269cc 100644 > > --- a/sys/dev/usb/net/if_smsc.c > > +++ b/sys/dev/usb/net/if_smsc.c > > @@ -1545,7 +1545,7 @@ smsc_ioctl(struct ifnet *ifp, u_long cmd, caddr_t data) > > * @ue: the USB ethernet device > > * > > * This is where the chip is intialised for the first time. This is different > > - * from the smsc_init() function in that that one is designed to setup the > > + * from the smsc_init() function in that one is designed to setup the > > Ditto. > > Jess > > > * H/W to match the UE settings and can be called after a reset. > > * > > * > > diff --git a/sys/dev/usb/usb_busdma.c b/sys/dev/usb/usb_busdma.c > > index 62e22805b39c..69d9ea292523 100644 > > --- a/sys/dev/usb/usb_busdma.c > > +++ b/sys/dev/usb/usb_busdma.c > > @@ -546,7 +546,7 @@ usb_pc_alloc_mem(struct usb_page_cache *pc, struct usb_page *pg, > > /* > > * XXX BUS-DMA workaround - FIXME later: > > * > > - * We assume that that the alignment at this point of > > + * We assume that the alignment at this point of > > * the code is greater than or equal to the size and > > * less than two times the size, so that if we double > > * the size, the size will be greater than the > --