From nobody Sun Sep 04 06:39:53 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ML27y3f2Vz4bgbt; Sun, 4 Sep 2022 06:39:58 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ML27y2wd5z3s4t; Sun, 4 Sep 2022 06:39:58 +0000 (UTC) (envelope-from bz@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662273598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NvqlgOV4VsAS/u5ROxzYjDbvspC6SY/CyuleF6zY8ik=; b=DjiMqS+naO7wZMpxBZzfaLjOEVsp+SgddwCzUtOXYFJbFWFM5pf/UswKj7Yzc2BRrjrmH2 FMyxgxT3wdYlC2HS2RqaYCw+6zjbiSxH94QfeV41X3gTgAg/E0jvUiRQVHzlzNBSdsNbag g8w7pfbWlJPBC44xQy9GDX/vHTAhje+hSnKTkibl/aY8dwngQ54ujtELbx7ZRQAW1vCfUe yRknc45b5NpTd5Za7daP1M4184bb5kFEN4GqbLquD/CkSwh0nPGPjkMctgcKQnKF2WiwS+ ULCgQQ9N5ceEPWp6u0QfHmByfbCcquamOxZylDH7AdFjpstHAYt6JRoP/Kx1VQ== Received: from mx1.sbone.de (cross.sbone.de [195.201.62.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ML27y16VpznWH; Sun, 4 Sep 2022 06:39:58 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id E0CD38D4A142; Sun, 4 Sep 2022 06:39:56 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 0034A5C3A831; Sun, 4 Sep 2022 06:39:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id UoWdpcE_hcZb; Sun, 4 Sep 2022 06:39:54 +0000 (UTC) Received: from strong-iwl0.sbone.de (strong-iwl0.sbone.de [IPv6:fde9:577b:c1a9:4902:b66b:fcff:fef3:e3d2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 3BA7F5C3A82F; Sun, 4 Sep 2022 06:39:54 +0000 (UTC) Date: Sun, 4 Sep 2022 06:39:53 +0000 (UTC) From: "Bjoern A. Zeeb" To: Gleb Smirnoff cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: e72c522858cb - main - divert(4): make it compilable and working without INET In-Reply-To: Message-ID: <15on1poo-pnpq-3pos-qs7s-673pp1q0s83@serrofq.bet> References: <202208302249.27UMnSwI022109@gitrepo.freebsd.org> <6q6n8553-2143-n24p-4816-406549997s@mnoonqbm.arg> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662273598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NvqlgOV4VsAS/u5ROxzYjDbvspC6SY/CyuleF6zY8ik=; b=EJBsZiVwDe0qQMxZYJKHnOkWQeZ+IBNKAcb+0Je1mTQwAmj1RP0SpH3Q5mCx3LvKvp2HCO D0Ew/hkGwQlMSMP4GnEqFyShrIIN8GjglcBqx2Xs/zecvVbIsObDPI+htcwB1SAgYHhE12 HTHCqXAm2GbE70Z5k1ntsyyKQWfaqM8bHGWgcEOWwlBngMWKlyFYIoFDouibmD7x5kXjQT mOnDGxsJmxaohssZD2Zx6iiFW7QhOzxwsUHGii2ilgR5ZgVJZhNJoUAOR+BtwZDkUsx8au zGWGlpzhQ2Wbuf61yMbv7kgDtAk0F80nwLB0BXQQmZbVcioIMVK0z3FshKRppA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662273598; a=rsa-sha256; cv=none; b=YS3ou3xLDpQnrxJy/9RibXqZF7M6WBzMgV2KYvHInJP8+XIyOvqBCsV6rwsBOM3nn+OmvQ Lc+b5g6M6r0yU0JsRPlbJckPrDeupoLO3JoUiQ+Lk5CUF6hAfgyp3yrE317HRx+zfS2c+v CMOiEDnzv8IjFEi/t6MAL1p4q1NyUYDvt9QtEEY6353Gzyc/A+1c3Vh1bx0PwcStGLXZuu S2GzFNWMlsgA8E3jKUo1/TZKN6Q/wiAoZSnCN3OnkPGwLtEezdlBZ4EmRycjQDYHdjisOI sGrWYPz0QTNGBo9rcwKScByB+BsVtogMBcJSexqkq1NbPtlNYSIRhqjOkag5aA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Sat, 3 Sep 2022, Gleb Smirnoff wrote: > On Sat, Sep 03, 2022 at 10:44:26PM +0000, Bjoern A. Zeeb wrote: > B> On Tue, 30 Aug 2022, Gleb Smirnoff wrote: > B> > B> > The branch main has been updated by glebius: > B> > > B> > URL: https://cgit.FreeBSD.org/src/commit/?id=e72c522858cb3fe179b8ec5700cdbf46c45e917e > B> > > B> > commit e72c522858cb3fe179b8ec5700cdbf46c45e917e > B> > Author: Gleb Smirnoff > B> > AuthorDate: 2022-08-30 22:09:21 +0000 > B> > Commit: Gleb Smirnoff > B> > CommitDate: 2022-08-30 22:09:21 +0000 > B> > > B> > divert(4): make it compilable and working without INET > B> > > B> > Differential revision: https://reviews.freebsd.org/D36383 > B> > B> Well, almost at least.... > > I wonder why LINT-NOINET builds without this?? I wondered the same last night.. I would be good to find out? > B> - sysctls require INET > > The sysctls, I believe, need to be moved out of the inet namespace. > > B> - ip_divert_ptr still requires INET or INET6 (raw_ip.c) > > This dependency is fine as it is. Packet filters also require either. Also, > I don't expect that through my lifetime we would ever need a kernel with > network stack features, but without both INET and INET6. There are people who build kernels w/o networking (hence LINT-NOIP) which is what found this one. > B> - one of the SCTP blocks has a early-ended #ifdef INET which can just be > B> fixed easily compared to the two above. > > Thanks! > > I'll post a review soon. Cool. Thank you! Blessed Sunday. /bz -- Bjoern A. Zeeb r15:7