From nobody Thu Sep 01 16:42:22 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MJRfQ3qjqz4Ztx4; Thu, 1 Sep 2022 16:42:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MJRfQ3KNdz3Ps6; Thu, 1 Sep 2022 16:42:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662050542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QYuGdcIwYnWiVC9vxJcdn91dNNG7BGPu8dzzI5S6Z0U=; b=Rj9mTu84y3jycSpZ75jsLP7x3tjq2SsH1wxX9Xh5QRXMvMVhXUhaHxltNxgVp+ty/emD4T sEuSE0SSSmdiuWQIRCC44vrlQba2u+hMeHPgKj+hMNHkAjRx6/ZgFcCWEO05Le11vccOo3 b+TPEzOBu9e9KVJ/gUy4sxg2bjr2WtFKYe+5cE4iNTsQdMLiSDbLcGbxCkdQ1K9vYNzvvd sUzQsIB0xhOQkbAgKIk3R9G60LoX5Sb2OwJ/R+df/CV3jBYLucQi6jiHhwEO2jobumve2X NiO71jkbjCo9sodHXRhAWG+MpSqBuKZb1yC/2RKN+m6qU2ZMYRsdJVGRLHEvww== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MJRfQ2Q5ZzXb0; Thu, 1 Sep 2022 16:42:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 281GgMtm067724; Thu, 1 Sep 2022 16:42:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 281GgMnZ067723; Thu, 1 Sep 2022 16:42:22 GMT (envelope-from git) Date: Thu, 1 Sep 2022 16:42:22 GMT Message-Id: <202209011642.281GgMnZ067723@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 991aef97957d - main - acpi: Move some errors with RSDP and XSLT out from under bootverbose List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 991aef97957da8cb1fe5bf6ae4bbce4f8098a734 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662050542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QYuGdcIwYnWiVC9vxJcdn91dNNG7BGPu8dzzI5S6Z0U=; b=ktGXMnteAzjzdB0rsSOmVsjOJO5mQWP/TnMkO1M6TsGA/eu1X2wnY4r8wyvuFZZepal04S d35DpkamS2Yj3tH0uFbAEsBfzSQJ2pE84Q9gKky8HLz/RS0l0jNSI0uAf4oT9X9C/y6q33 HbtIWahB/pe11ESWaLmwAQYs1So83bQX0g4+18fEuRYTZmL2rO2Tc9Wj8Yfa/molsEdZCz xs9idYhMjQNuunMOtXCTPxARtn7li/3y0+eklqQcIh3PB3ChYSjUrbSoy0ZPwoeptIMlxe 3AAm+iEUlEGGOWg6RUo7sgX/ImXrfVMfwma3y3Ugs2VoP7mjGaX5iHM2PkTjgw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662050542; a=rsa-sha256; cv=none; b=SJkTI6w+ZHjJDoJbt7iXQopzW5rwFPPfuRm8BTZJ7iIgUD2YOJoNtOMETWVA6f1c3SjnTJ fVkXIM0PwXfafzLQUX4u/bUgh/AM9moJv6+vOD2tAYRZ3Y+SknURao1908qiRjKj4ZRVCH Q3a87oGmiE5owwawLIOgG6yymwELTKML/V61+LUvPBss8DwXv7N2oaMs054ZVS++JmFXzr WUqexA/OmdpOvrE47u901AwXYu9ySwhzDeHF6t3wZ0BWUEuI6o+KbA+q10HAC+IFG5qqcn aa6NBI7WDobHmDhJIJgaz3FnGQg1lODJNurx1bnAdoBr9cJ6H42698L3lXBOdw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=991aef97957da8cb1fe5bf6ae4bbce4f8098a734 commit 991aef97957da8cb1fe5bf6ae4bbce4f8098a734 Author: Warner Losh AuthorDate: 2022-09-01 16:39:34 +0000 Commit: Warner Losh CommitDate: 2022-09-01 16:40:15 +0000 acpi: Move some errors with RSDP and XSLT out from under bootverbose Failure to map RSDP, XSLT and checksum failures are events that can't happen unless something has gone wrong. As such, they should be reported always, and not in bootverbose. This has been this way since it was originally brought in to parse APIC tables. Sponsored by: Netflix Reviewed by: andrew Differential Revision: https://reviews.freebsd.org/D36406 --- sys/amd64/acpica/acpi_machdep.c | 12 ++++-------- sys/arm64/acpica/acpi_machdep.c | 9 +++------ 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/sys/amd64/acpica/acpi_machdep.c b/sys/amd64/acpica/acpi_machdep.c index 1a9f44969d03..41ec1554147f 100644 --- a/sys/amd64/acpica/acpi_machdep.c +++ b/sys/amd64/acpica/acpi_machdep.c @@ -184,8 +184,7 @@ acpi_find_table(const char *sig) return (0); rsdp = pmap_mapbios(rsdp_ptr, sizeof(ACPI_TABLE_RSDP)); if (rsdp == NULL) { - if (bootverbose) - printf("ACPI: Failed to map RSDP\n"); + printf("ACPI: Failed to map RSDP\n"); return (0); } @@ -201,16 +200,14 @@ acpi_find_table(const char *sig) * an additional checksum that we verify first. */ if (AcpiTbChecksum((UINT8 *)rsdp, ACPI_RSDP_XCHECKSUM_LENGTH)) { - if (bootverbose) - printf("ACPI: RSDP failed extended checksum\n"); + printf("ACPI: RSDP failed extended checksum\n"); pmap_unmapbios((vm_offset_t)rsdp, sizeof(ACPI_TABLE_RSDP)); return (0); } xsdt = map_table(rsdp->XsdtPhysicalAddress, ACPI_SIG_XSDT); if (xsdt == NULL) { - if (bootverbose) - printf("ACPI: Failed to map XSDT\n"); + printf("ACPI: Failed to map XSDT\n"); pmap_unmapbios((vm_offset_t)rsdp, sizeof(ACPI_TABLE_RSDP)); return (0); @@ -226,8 +223,7 @@ acpi_find_table(const char *sig) } else { rsdt = map_table(rsdp->RsdtPhysicalAddress, ACPI_SIG_RSDT); if (rsdt == NULL) { - if (bootverbose) - printf("ACPI: Failed to map RSDT\n"); + printf("ACPI: Failed to map RSDT\n"); pmap_unmapbios((vm_offset_t)rsdp, sizeof(ACPI_TABLE_RSDP)); return (0); diff --git a/sys/arm64/acpica/acpi_machdep.c b/sys/arm64/acpica/acpi_machdep.c index 6145dfbbc78b..c9de53852549 100644 --- a/sys/arm64/acpica/acpi_machdep.c +++ b/sys/arm64/acpica/acpi_machdep.c @@ -161,8 +161,7 @@ acpi_find_table(const char *sig) return (0); rsdp = pmap_mapbios(rsdp_ptr, sizeof(ACPI_TABLE_RSDP)); if (rsdp == NULL) { - if (bootverbose) - printf("ACPI: Failed to map RSDP\n"); + printf("ACPI: Failed to map RSDP\n"); return (0); } @@ -174,16 +173,14 @@ acpi_find_table(const char *sig) * an additional checksum that we verify first. */ if (AcpiTbChecksum((UINT8 *)rsdp, ACPI_RSDP_XCHECKSUM_LENGTH)) { - if (bootverbose) - printf("ACPI: RSDP failed extended checksum\n"); + printf("ACPI: RSDP failed extended checksum\n"); pmap_unmapbios((vm_offset_t)rsdp, sizeof(ACPI_TABLE_RSDP)); return (0); } xsdt = map_table(rsdp->XsdtPhysicalAddress, ACPI_SIG_XSDT); if (xsdt == NULL) { - if (bootverbose) - printf("ACPI: Failed to map XSDT\n"); + printf("ACPI: Failed to map XSDT\n"); pmap_unmapbios((vm_offset_t)rsdp, sizeof(ACPI_TABLE_RSDP)); return (0);