From nobody Fri Nov 25 11:21:12 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NJXVp1F3sz4hck4 for ; Fri, 25 Nov 2022 11:21:22 +0000 (UTC) (envelope-from bT.bdfpmbuc30=129qi2ildi85=cc5w82e1n7@em790814.fubar.geek.nz) Received: from e2i342.smtp2go.com (e2i342.smtp2go.com [103.2.141.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4NJXVm0s2qz3lGj for ; Fri, 25 Nov 2022 11:21:19 +0000 (UTC) (envelope-from bT.bdfpmbuc30=129qi2ildi85=cc5w82e1n7@em790814.fubar.geek.nz) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=smtpservice.net header.s=mgy720.a1-4.dyn header.b=qjz62Vkh; dkim=pass header.d=fubar.geek.nz header.s=s790814 header.b=VONiGISR; spf=pass (mx1.freebsd.org: domain of "bT.bdfpmbuc30=129qi2ildi85=cc5w82e1n7@em790814.fubar.geek.nz" designates 103.2.141.86 as permitted sender) smtp.mailfrom="bT.bdfpmbuc30=129qi2ildi85=cc5w82e1n7@em790814.fubar.geek.nz"; dmarc=pass (policy=none) header.from=fubar.geek.nz DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpservice.net; s=mgy720.a1-4.dyn; x=1669376179; h=Feedback-ID: X-Smtpcorp-Track:To:Message-Id:Date:From:Subject:Reply-To:Sender: List-Unsubscribe; bh=F9ylduieGp8w7J50Ye20mY/wiGEw6MkF9PUDP1ly0g8=; b=qjz62Vkh Ab6s8f49P5lpcs9gNAGSiVYLlOPLIDptBHH45ZvQgmze3V3osWtGZPcAqI2giUKo93d0x1gZLtn48 sdNq9AbdCRmLMH7lezzbYGsI3bWsBhWswDvG00ljmRmOZPRqkHjO2F1vbS3kKe1ADNcXZHIF55tIX D1SG4bMvWS8KP0JGxTbgFjRwdgrXMgldJiZiODubdvAiN77ZX7oesF9NivJEgdMgioaOE07cZhCLT +3V6XTqhNhJF1mS7OkFY8fJcjuvSXgv1+9duZM5i1tFwXOQgjDH0IMy0fS7v0B42XyInwrnh8eTks nZNMmhT6/4SENJrBnECNEexnEQ==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fubar.geek.nz; i=@fubar.geek.nz; q=dns/txt; s=s790814; t=1669375279; h=from : subject : to : message-id : date; bh=F9ylduieGp8w7J50Ye20mY/wiGEw6MkF9PUDP1ly0g8=; b=VONiGISR6kBtY5xNEO27G7PHiRgXVwVHLNlvfeBOlzLz+0u9BdnemkyWKMYdKMIpD/hs4 uKr+zj6B85JmxXE0qZrg3od+o8nK46vpimzmt0LaZBFETwVxhhdBXiYNQOeHctKZyRKxZ8c 6+obMVkdwuCFas2QJNwEaTnKAgdpQ5RaHMNVMiPDd5VsWhKXj0zZntoN+pkyfA6v65QM+mB BnW4xRl4nPvHbRfKKd9MorvoAQO1jyEhaZCEz/KbvxlCpaJ34Qal3uCzyP50GAS3QNtzWmu fwcO7RKbb1AC9mLQzjinv3heq/HdG9XpusFX4CJ+XyyFM0WSMWP6357aFCfQ== Received: from [10.176.58.103] (helo=SmtpCorp) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2-S2G) (envelope-from ) id 1oyWlg-TRk59s-FT; Fri, 25 Nov 2022 11:21:16 +0000 Received: from [10.162.55.164] (helo=morbo.fubar.geek.nz) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96-S2G) (envelope-from ) id 1oyWlg-9EI8iX-0k; Fri, 25 Nov 2022 11:21:16 +0000 Received: from smtpclient.apple (cpc91214-cmbg18-2-0-cust234.5-4.cable.virginm.net [81.102.75.235]) by morbo.fubar.geek.nz (Postfix) with ESMTPSA id 469AFFF62; Fri, 25 Nov 2022 11:21:13 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: d8be3d523dd5 - main - vmm: Use struct vcpu in the rendezvous code. From: Andrew Turner In-Reply-To: <202211181826.2AIIQioj030460@gitrepo.freebsd.org> Date: Fri, 25 Nov 2022 11:21:12 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202211181826.2AIIQioj030460@gitrepo.freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Smtpcorp-Track: 1oyW_g9Em8ib0k.gHltMLQybPU1A Feedback-ID: 790814m:790814amQcrys:790814sceiQzqitI X-Report-Abuse: Please forward a copy of this message, including all headers, to X-Spamd-Result: default: False [-3.90 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[fubar.geek.nz,none]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; FORGED_SENDER(0.30)[andrew@fubar.geek.nz,bT.bdfpmbuc30=129qi2ildi85=cc5w82e1n7@em790814.fubar.geek.nz]; RCVD_IN_DNSWL_MED(-0.20)[103.2.141.86:from]; R_SPF_ALLOW(-0.20)[+ip4:103.2.140.0/22]; R_DKIM_ALLOW(-0.20)[smtpservice.net:s=mgy720.a1-4.dyn,fubar.geek.nz:s=s790814]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_NEQ_ENVFROM(0.00)[andrew@fubar.geek.nz,bT.bdfpmbuc30=129qi2ildi85=cc5w82e1n7@em790814.fubar.geek.nz]; RCVD_COUNT_THREE(0.00)[4]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org]; DKIM_TRACE(0.00)[smtpservice.net:+,fubar.geek.nz:+]; ASN(0.00)[asn:23352, ipnet:103.2.140.0/22, country:US]; RCVD_TLS_ALL(0.00)[] X-Rspamd-Queue-Id: 4NJXVm0s2qz3lGj X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N > On 18 Nov 2022, at 18:26, John Baldwin wrote: >=20 > The branch main has been updated by jhb: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dd8be3d523dd50a17f48957c1bb2e0cd7= bbf02cab >=20 > commit d8be3d523dd50a17f48957c1bb2e0cd7bbf02cab > Author: John Baldwin > AuthorDate: 2022-11-18 18:03:34 +0000 > Commit: John Baldwin > CommitDate: 2022-11-18 18:25:37 +0000 >=20 > vmm: Use struct vcpu in the rendezvous code. >=20 > Reviewed by: corvink, markj > Differential Revision: https://reviews.freebsd.org/D37165 > --- > sys/amd64/include/vmm.h | 4 ++-- > sys/amd64/vmm/io/vioapic.c | 11 +++++------ > sys/amd64/vmm/io/vlapic.c | 10 +++++----- > sys/amd64/vmm/io/vlapic.h | 2 +- > sys/amd64/vmm/vmm.c | 36 +++++++++++++++++------------------- > 5 files changed, 30 insertions(+), 33 deletions(-) >=20 > diff --git a/sys/amd64/include/vmm.h b/sys/amd64/include/vmm.h > index 2f9a8776bb39..1c68181f5ff4 100644 > --- a/sys/amd64/include/vmm.h > +++ b/sys/amd64/include/vmm.h > @@ -313,8 +313,8 @@ int vm_restore_time(struct vm *vm); > * by 'dest' to be stalled. The caller should not rely on any vcpus = making > * forward progress when the rendezvous is in progress. > */ > -typedef void (*vm_rendezvous_func_t)(struct vm *vm, int vcpuid, void = *arg); > -int vm_smp_rendezvous(struct vm *vm, int vcpuid, cpuset_t dest, > +typedef void (*vm_rendezvous_func_t)(struct vcpu *vcpu, void *arg); > +int vm_smp_rendezvous(struct vcpu *vcpu, cpuset_t dest, > vm_rendezvous_func_t func, void *arg); The comment above vm_rendezvous_func_t should be updated for the removal = of vcpuid. Andrew