From nobody Thu Nov 17 21:50:49 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NCtrn5Ykhz4hFfs; Thu, 17 Nov 2022 21:50:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NCtrn3xYBz3JL4; Thu, 17 Nov 2022 21:50:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668721849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1nooBDh8Iv97ES7rohwF+qNaMxSkNj3On/1JL8ex8Zw=; b=c69HCBvkQQXvQR0AQcKhgJKJca+koZav0uDJfyyN7CRbPeYcsEG9L4K9YhDsA3s9656jmG i8A2S8YdAHnFcKU+lKVaVp4mZybl7Riw5e94y+jnFg8E/8O4Rs1vocxopn14DeUO/jKVuU Sq4wb1gGfV+PTjdCRHzJKEMyEcC7+8icSXCWbawUs/1i1nWaKvnoZDqaPRnDFUVTOolv+6 zGPMgfVs325wkHxRqF3odUPxFTOEi1vjqjj1Nxq1ty0ITQvSKgJ/QrPy3Ak0l5UAt6VteJ 9/UsjBE6VBXy0ejtP4AUdpLPzKYJUlPR0E2V6/aBVbj0Qk8MgLbKKxWspsC0UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668721849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1nooBDh8Iv97ES7rohwF+qNaMxSkNj3On/1JL8ex8Zw=; b=xlOw/vjaL68eAEC9V6xDLXSYtqgxNRuP/y9DQ6lOQ905y5DX1J7mC7ey1/O2VTRPTALKAn nuX3l6EJmgyGlEh/g2s/YK0lOKNtUXHEHvJEr2Qnt6gTVVdSMI9GiR412kmOSvbhLn8sfp Xsi0t8AkzWaFyhb++S/eVW4WnigrWtCDkAb3nH0Vpo1De0IYQFmhJjF+F+2LNHWcfslUs3 wxJNGACx4p14FgFmbr5zPix/6wUB1CTSCGR/N/xPULpX61G3iV5VsFnU1adVQN8lsXJSd/ 2Rtee9CwzFxYMI0BmFfeRalWBQxEW8qe1o2CQmeIG3/iTjeH0TVHVwcJts9J6Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1668721849; a=rsa-sha256; cv=none; b=i/Kpmp8U0Bi92+Z7OB+kcXL+IzCUUW9gEdqIfA/Xbm4Wve1F0+pcvmuSCoj13cpFWf0s77 Pr8IzHFvStIGqTIlwf1blzmJ248gj27Huvmq6m9i4WCIo0aCRiDwjBXUr3CIvpc7mgHwjC sGJZE4n8RKHt/DjNko34X27oXaA6p3/2YZsa1z19wbxdFopCMXe2j0tGA4Of8GN6SUP24m kCst9FuX1sZ1xBP5VdyaKuuAmzPt1NCIBZYwD5jUzW9QiG4FJTBWIzuHydfst2mNeinDT8 LuyRJlEUirnXJYREzunSVNh4KAXeV35kNTU+DiQYH7/GpYWWTRf+bvp0JS/YUA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NCtrn31lszx0R; Thu, 17 Nov 2022 21:50:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2AHLonJg076005; Thu, 17 Nov 2022 21:50:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2AHLonIY076004; Thu, 17 Nov 2022 21:50:49 GMT (envelope-from git) Date: Thu, 17 Nov 2022 21:50:49 GMT Message-Id: <202211172150.2AHLonIY076004@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Vladimir Kondratyev Subject: git: 4a0db5e2920c - main - evdev: Extend EVIOCGRAB ioctl scope to cover sysmouse interface List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: wulf X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4a0db5e2920c0e0df52d6888bdd732df95706dfc Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by wulf: URL: https://cgit.FreeBSD.org/src/commit/?id=4a0db5e2920c0e0df52d6888bdd732df95706dfc commit 4a0db5e2920c0e0df52d6888bdd732df95706dfc Author: Vladimir Kondratyev AuthorDate: 2022-11-17 21:48:42 +0000 Commit: Vladimir Kondratyev CommitDate: 2022-11-17 21:48:42 +0000 evdev: Extend EVIOCGRAB ioctl scope to cover sysmouse interface of psm(4), ums(4) and sysmouse(4) drivers. EVIOCGRAB ioctl execution on /dev/input/event# device node gains exclusive access to this device to caller. It is used mostly for development purposes and remote control software. See e.g. https://reviews.freebsd.org/D30020 which is the reason of creation of this change. MFC after: 2 weeks Tested by: corvink Differential revision: https://reviews.freebsd.org/D30542 --- sys/dev/atkbdc/psm.c | 12 ++++++++---- sys/dev/evdev/evdev.c | 11 +++++++++++ sys/dev/evdev/evdev.h | 1 + sys/dev/syscons/sysmouse.c | 2 ++ sys/dev/usb/input/ums.c | 4 ++++ sys/dev/vt/vt_sysmouse.c | 2 ++ 6 files changed, 28 insertions(+), 4 deletions(-) diff --git a/sys/dev/atkbdc/psm.c b/sys/dev/atkbdc/psm.c index b3e036ebc134..97bf1b859dd2 100644 --- a/sys/dev/atkbdc/psm.c +++ b/sys/dev/atkbdc/psm.c @@ -5111,6 +5111,10 @@ psmsoftintr(void *arg) break; } + /* Store last packet for reinjection if it has not been set already */ + if (timevalisset(&sc->idletimeout) && sc->idlepacket.inputbytes == 0) + sc->idlepacket = *pb; + #ifdef EVDEV_SUPPORT if (evdev_rcpt_mask & EVDEV_RCPT_HW_MOUSE && sc->hw.model != MOUSE_MODEL_ELANTECH && @@ -5144,6 +5148,10 @@ psmsoftintr(void *arg) evdev_push_mouse_btn(sc->evdev_r, ms.button); evdev_sync(sc->evdev_r); } + + if ((sc->evdev_a != NULL && evdev_is_grabbed(sc->evdev_a)) || + (sc->evdev_r != NULL && evdev_is_grabbed(sc->evdev_r))) + goto next; #endif /* scale values */ @@ -5164,10 +5172,6 @@ psmsoftintr(void *arg) } } - /* Store last packet for reinjection if it has not been set already */ - if (timevalisset(&sc->idletimeout) && sc->idlepacket.inputbytes == 0) - sc->idlepacket = *pb; - ms.dx = x; ms.dy = y; ms.dz = z; diff --git a/sys/dev/evdev/evdev.c b/sys/dev/evdev/evdev.c index 2fd7c2e201ea..a0a039f0b691 100644 --- a/sys/dev/evdev/evdev.c +++ b/sys/dev/evdev/evdev.c @@ -1094,6 +1094,17 @@ evdev_release_client(struct evdev_dev *evdev, struct evdev_client *client) return (0); } +bool +evdev_is_grabbed(struct evdev_dev *evdev) +{ + /* + * The function is intended to be called from evdev-unrelated parts of + * code like syscons-compatible parts of mouse and keyboard drivers. + * That makes unlocked read-only access acceptable. + */ + return (evdev->ev_grabber != NULL); +} + static void evdev_repeat_callout(void *arg) { diff --git a/sys/dev/evdev/evdev.h b/sys/dev/evdev/evdev.h index 90bea09b70c9..892e6b1bc071 100644 --- a/sys/dev/evdev/evdev.h +++ b/sys/dev/evdev/evdev.h @@ -154,6 +154,7 @@ void evdev_set_repeat_params(struct evdev_dev *, uint16_t, int); int evdev_set_report_size(struct evdev_dev *, size_t); void evdev_set_flag(struct evdev_dev *, uint16_t); void *evdev_get_softc(struct evdev_dev *); +bool evdev_is_grabbed(struct evdev_dev *); /* Multitouch related functions: */ int evdev_mt_id_to_slot(struct evdev_dev *, int32_t); diff --git a/sys/dev/syscons/sysmouse.c b/sys/dev/syscons/sysmouse.c index ef851058a6ef..73167bdb34f8 100644 --- a/sys/dev/syscons/sysmouse.c +++ b/sys/dev/syscons/sysmouse.c @@ -295,6 +295,8 @@ sysmouse_event(mouse_info_t *info) #ifdef EVDEV_SUPPORT smdev_evdev_write(x, y, z, mouse_status.button); + if (evdev_is_grabbed(sysmouse_evdev)) + goto done; #endif if (!tty_opened(sysmouse_tty)) diff --git a/sys/dev/usb/input/ums.c b/sys/dev/usb/input/ums.c index 5b3ac2af4cd0..987c4b9d1309 100644 --- a/sys/dev/usb/input/ums.c +++ b/sys/dev/usb/input/ums.c @@ -875,6 +875,10 @@ ums_put_queue(struct ums_softc *sc, int32_t dx, int32_t dy, { uint8_t buf[8]; +#ifdef EVDEV_SUPPORT + if (evdev_is_grabbed(sc->sc_evdev)) + return; +#endif if (1) { if (dx > 254) dx = 254; diff --git a/sys/dev/vt/vt_sysmouse.c b/sys/dev/vt/vt_sysmouse.c index e10ac829abf3..c6426f3a8f17 100644 --- a/sys/dev/vt/vt_sysmouse.c +++ b/sys/dev/vt/vt_sysmouse.c @@ -249,6 +249,8 @@ sysmouse_process_event(mouse_info_t *mi) #ifdef EVDEV_SUPPORT sysmouse_evdev_store(x, y, z, sysmouse_status.button); + if (evdev_is_grabbed(sysmouse_evdev)) + goto done; #endif /* The first five bytes are compatible with MouseSystems. */