From nobody Thu Nov 17 20:16:52 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NCrmN4g3jz4dGrt; Thu, 17 Nov 2022 20:16:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NCrmN48w9z4P33; Thu, 17 Nov 2022 20:16:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668716212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=es8whgpyOjo/5yysrUOJzLJcXIVM4wDSlBOtyLM0mBg=; b=eLvRQyuEtHkOS4l57nbg1Tmp8g9c1l/2kA2GFYdV2PfJeV5YZNOiDuLMqm8NWZLFKgSRci tlwoSymsNymg9IqBgbeYfsRzjuqcS/t4KKJmRQPGACuwbOoHTz5p0DwyLrNNp1teCaWUAv 73eVezGbxhGj0S5XoGJsdCdwowB0hM52kRAazvUP6XXLajcWWjHHvQ+YUL9iaYA6FDOXzq CCcRsv9N/GzY6B73kfn9f528cQ95UYDLx/Iyamsq4ycgwQ99Cw8zJq7SvQHYL7SsDL2gN7 79klRJBAvyM5oMJuUfV4KdpRrD1NX8wX9zMLkDVPVAc4uLDPW1rTznvlG0PHVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668716212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=es8whgpyOjo/5yysrUOJzLJcXIVM4wDSlBOtyLM0mBg=; b=K4h+JMHX4hm2tx8SfLuMmAd+xx9Ht4iKX3r+Zsux9N2JTSGJQcpJlY+81ramWoqjDbp2pZ N8JGODii0avRVFFZBAW/35JUboeDypBNddubXpE4IRE+oIJ/Gl3Z+EG96g0gUR8ugkqI11 tZDz0v8a4hC79lOFtg5jF17y+Hko3d6j4QnleMDsU3oMt/qUP0ihCYtD2JOdTitOIcBkgG rJK1nyr30ZVTTsJSnrCE2L9UsK6yqOELGJzxhgDXb+dvoIYS22nqesc0eSFPzdMD8eHEGx 6pl9EIRjGnTHwblGKgJ+5+142IDlPU1HZZoQTsjJaZQ1c94DVTk5lKN2MgD3XQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1668716212; a=rsa-sha256; cv=none; b=a5Sqf8VWEO+OfcCvOOQ8z3LrUG9SXvEEcvySMBMZJPU2pzL3Z5iRt5uTFrAka8xLO9mjCR DrHx3XxqF5B+AN3YP0xfBEM/Q0GBb9y2A4tyg870vxQHmjtu0ZgkLPx4VTjzZI+wvyBkbf H9TwjKdGldgBACFC2WEzdohezEvR0bmLAfuEmXcsk9s2nCJ6r9gVt9KNtu4iARswWERy4Y neA46gbzfH9bwrqR545PCkinEHBp6/+C3Ta6y7aHphY2LcmxlWz1UXg2BN3JTryWoCcVeY CXSZnXfkAwqipunZxXaqJax/klLzU8oumOjAbkVO3E745OhG7wryIlQBa05zlA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NCrmN3CVkzvcZ; Thu, 17 Nov 2022 20:16:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2AHKGqMT038772; Thu, 17 Nov 2022 20:16:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2AHKGqY8038771; Thu, 17 Nov 2022 20:16:52 GMT (envelope-from git) Date: Thu, 17 Nov 2022 20:16:52 GMT Message-Id: <202211172016.2AHKGqY8038771@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: "Andrey V. Elsukov" Subject: git: fe9c4deda9d4 - stable/12 - ixgbe: workaround errata about UDP frames with zero checksum List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ae X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: fe9c4deda9d4aa2c5bed75071f8006bd2a0734a2 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by ae: URL: https://cgit.FreeBSD.org/src/commit/?id=fe9c4deda9d4aa2c5bed75071f8006bd2a0734a2 commit fe9c4deda9d4aa2c5bed75071f8006bd2a0734a2 Author: Andrey V. Elsukov AuthorDate: 2022-11-10 09:34:40 +0000 Commit: Andrey V. Elsukov CommitDate: 2022-11-17 20:16:15 +0000 ixgbe: workaround errata about UDP frames with zero checksum Intel 82599 has errata related to IPv4 UDP frames with zero checksum. It reports such datagrams with L4 integrity errors in IXGBE_XEC register. And after afb1aa4e6df2 commit such errors are reported via IFCOUNTER_IERRORS. This confuses users, since actually all frames are handled correctly by the system. To workaround the problem, let's ignore the XEC register value for 82599 cards for now. PR: 266048 Discussed with: erj Sponsored by: Yandex LLC (cherry picked from commit 8526120ad41ca47367b43f8f4459e0fa61285571) --- sys/dev/ixgbe/if_ix.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index a361645d3b9f..47f3918fd8ee 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -1574,8 +1574,12 @@ ixgbe_update_stats_counters(struct ixgbe_softc *sc) * - fragmented packets count, * - oversized packets count, * - jabber count. + * + * Ignore XEC errors for 82599 to workaround errata about + * UDP frames with zero checksum. */ - IXGBE_SET_IERRORS(sc, stats->crcerrs + stats->illerrc + stats->xec + + IXGBE_SET_IERRORS(sc, stats->crcerrs + stats->illerrc + + (hw->mac.type != ixgbe_mac_82599EB ? stats->xec : 0) + stats->mpc[0] + stats->rlec + stats->ruc + stats->rfc + stats->roc + stats->rjc); } /* ixgbe_update_stats_counters */