From nobody Sun Nov 13 07:02:31 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N93Kg5lMPz4fcY5; Sun, 13 Nov 2022 07:02:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N93Kg5Dqfz3jH4; Sun, 13 Nov 2022 07:02:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668322951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h0UR30gflTz4oqV7EVsOfXDArO3VPC1Jg9bAL//xiCg=; b=nNiYiEi2gHteHvw6TC4dazyWW59TR9iW700oaNjYVZx3WUSblAisHMnTU+FaciTXJhSl+w 1Gpb4wuiCJlrc0hMCGChjdK75IGzaezBEu+/cUym76G8xjIOnuJvf6ZKM54a2Jet8VTUY/ qqbIBSTr77pOo4L5axh9yMhIHHNR7vOh0znG3kYNWLrOVSqwazJL8UxWZTqIn350j9DCcJ eJ5/FUlRWjJLx6jjQNTXguiWvGNxabSO+4xEnvtlwg0PAMSy9SyeWos4ap7Dpdg2u+Sqm+ KEOtF6fjUX5rUcrOyxlh1QGN9+VWJf7VzJ0ConJEQ9ClV7T4vUyBy8jQwzkrPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668322951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h0UR30gflTz4oqV7EVsOfXDArO3VPC1Jg9bAL//xiCg=; b=UtnLutb/ic0q9t1H10LntXvSii7X46Q+HR3DNdE8gQmacoehsiw4K2T2MDx9spbo40202a 3TDyQCp35T6BNgnTJV3rOKuId7fNDkl+vKoaMNIEXxSALOuPvl5KMTg9Bjt4wTE/iQANS1 NYqHtUxiI3UUiMJ85N+KUJAegbdI5cJyuS9LfxIa+BtHScrtMFwKdwHeqDBCgnZR8eb+no qm0tz4ToDnOmDHatr1smf+inlIVPTH0+XWk6kuoFn0rlv02HmNhSyouXcBGyDAOi0JSe04 AcDpTS4g8n4JnXUvGpe5enoXcXOSG+t6PSeqhMg+1x8qec+jinda9Ubi90Strw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1668322951; a=rsa-sha256; cv=none; b=jSlYy2fKbUPwux+Sz+7vdTC22u8WwheB1DZZ9z/vJBMbE/9XMruOYgmWGUamIveb3eWHvM 4jy13NLR1sab2wt81KbJ6YRSNoac3BINcdFdWe5PiSO8HU9kTTVYKarg16C8AfVfm7opDt hzyhhJjYTtaYPdsQjDtnolQB6CKBlAxF47KWrXcqRssT5zThqsg6EoSVV8V9/m5FV2dTuo +/HcYnE9SS2avPecGGc2yfBz6ePaIZ2wBhc/vVE6ngjjY0IzF/DAqYw1vLw51YoLQb9fra w9q5A46mpUOmoRk/bW+784FH9moW6Mg3eo78uqp5pwPGeFwRerCspZWWuIUfwg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4N93Kg4KjYztJh; Sun, 13 Nov 2022 07:02:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2AD72VoH023979; Sun, 13 Nov 2022 07:02:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2AD72VOV023978; Sun, 13 Nov 2022 07:02:31 GMT (envelope-from git) Date: Sun, 13 Nov 2022 07:02:31 GMT Message-Id: <202211130702.2AD72VOV023978@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kirk McKusick Subject: git: 78f412987605 - main - Enable taking snapshots on UFS/FFS filesystems using journaled soft updates. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mckusick X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 78f41298760509f5c2b5865b2158c801d4023363 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by mckusick: URL: https://cgit.FreeBSD.org/src/commit/?id=78f41298760509f5c2b5865b2158c801d4023363 commit 78f41298760509f5c2b5865b2158c801d4023363 Author: Kirk McKusick AuthorDate: 2022-11-13 06:56:03 +0000 Commit: Kirk McKusick CommitDate: 2022-11-13 06:56:03 +0000 Enable taking snapshots on UFS/FFS filesystems using journaled soft updates. All the needed infrastructure updates have been made to allow snapshots to be taken on UFS/FFS filesystems that are using journaled soft updates. The most immediate benefit is the ability to use a snapshot to take a consistent filesystem dump on a live filesystem using the -L option to dump(8). Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D36491 --- sbin/newfs/newfs.8 | 4 +--- sbin/tunefs/tunefs.8 | 4 +--- sys/ufs/ffs/ffs_snapshot.c | 9 --------- 3 files changed, 2 insertions(+), 15 deletions(-) diff --git a/sbin/newfs/newfs.8 b/sbin/newfs/newfs.8 index a065563f86d1..9421971a74f5 100644 --- a/sbin/newfs/newfs.8 +++ b/sbin/newfs/newfs.8 @@ -205,9 +205,7 @@ is running. Running a full fsck on a UFS filesystem is the equivalent of running a scrub on a ZFS filesystem. .Pp -Presently it is not possible to take a snapshot on a UFS filesystem -running with journaled soft updates. -Thus it is not possible to reliably dump mounted filesystems or +Presently it is not possible to run background fsck on filesystems enabled for journaling. .It Fl k Ar held-for-metadata-blocks Set the amount of space to be held for metadata blocks in each cylinder group. diff --git a/sbin/tunefs/tunefs.8 b/sbin/tunefs/tunefs.8 index b9a581df6784..0264c3e5f772 100644 --- a/sbin/tunefs/tunefs.8 +++ b/sbin/tunefs/tunefs.8 @@ -131,9 +131,7 @@ is running. Running a full fsck on a UFS filesystem is the equivalent of running a scrub on a ZFS filesystem. .Pp -Presently it is not possible to take a snapshot on a UFS filesystem -running with journaled soft updates. -Thus it is not possible to reliably dump mounted filesystems or +Presently it is not possible to run background fsck on filesystems enabled for journaling. .It Fl J Cm enable | disable Turn on/off gjournal flag. diff --git a/sys/ufs/ffs/ffs_snapshot.c b/sys/ufs/ffs/ffs_snapshot.c index bcdf94a10cda..7ee5dd2bfa43 100644 --- a/sys/ufs/ffs/ffs_snapshot.c +++ b/sys/ufs/ffs/ffs_snapshot.c @@ -226,15 +226,6 @@ ffs_snapshot(struct mount *mp, char *snapfile) ump = VFSTOUFS(mp); fs = ump->um_fs; sn = NULL; - /* - * At the moment, journaled soft updates cannot support - * taking snapshots. - */ - if (MOUNTEDSUJ(mp)) { - vfs_mount_error(mp, "%s: Snapshots are not yet supported when " - "running with journaled soft updates", fs->fs_fsmnt); - return (EOPNOTSUPP); - } MNT_ILOCK(mp); flag = mp->mnt_flag; MNT_IUNLOCK(mp);