From nobody Thu Nov 10 19:15:17 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N7WkZ0P8vz4dnmd; Thu, 10 Nov 2022 19:15:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N7WkY6xJbz41Zf; Thu, 10 Nov 2022 19:15:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668107718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ay5YQgGdlegrzygAuxgQwTs3l6hozW039ftIC8ydnv4=; b=x0TPDAOKaK0P12HrHymybit+9KMLM5jfNIhvM42gMKysMT1ofJwH1vFPrC+PgNKjAd3xbg PyXgezjp3Z9NTPMQf26OOT53LqEh1cNQC7JZezo6fXqpVHca8MKvRBSgOgeDnW6MjftGEv WVA8PbfDIZ9NTnkdNn2wgVzCthg6YRDCwzGp3HTel2bkUJc0bsfnCYwsTzBam52MI6UiCf QfFV9+duKqSFpOxB9pAojVB7u2yKWxmmuAQfA4gRNMq65f2ektxdDnIJydLQSdVKwR28Bf TFERIDtGvpFjR6ASf/Ouc2vAoH1Hur8Aw0hHKJyAqGHm6rvxvlGW+Fvq8THg6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668107718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ay5YQgGdlegrzygAuxgQwTs3l6hozW039ftIC8ydnv4=; b=xLuCZBIFjevqZNetvpL59teMlSpCvbeWxwZyq8gsXhbFSMgf2kL7d5uADztaX9tE/wqlQ8 QvneFvzNP1YKS8h0MbkRDzLk0x+E3J6/0a9hyhl7OTZxpLZ3JLaOaO/x17Ckyq0PWAlnW2 lT46svbH5/GuaipNzfWl7A2XfYrLqRgv9eohJF5jckt6yTxNZXGZSsM28BK+JCYGzJfrZB ncM31G/V9NzQqN3GWKGcFjl6/Ykg3UeBlbUNzXl5l/oLFT3/wLAQ43muyo8Zd7Z5ByHpSk oLcrzhA+vxSOcst8e0plYQDaegux50KqLtkoZDal4BZeOU9oLfuOjQ+MaYAHjw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1668107718; a=rsa-sha256; cv=none; b=j0bS5JhOetKoN63Onud18r7+I6U2+jUhHgD0asxTdH83EzjLkfo3WIH9BqiwLNR8TtLVjW Yl7dR0kn4cjR8B2ZKWYhIpJbQ50vTSiXhzY6INsMgy8BwN1l/+Ae8q4/izabqPrAltsWUS hRfLO+TKFXX7EjyW593C4w7ah55uk7/i2ZYxyFLsSKCuw7+JDtYT4AL5axNGmu4teA25iI U+nWHT4HO0hphIaCm42X9vawWiRXkfLAO4qLevcWRk4l3wX7ugKlas8TipqAIp/HdXAkaD 0uuyIuvHsDHBZxb3lJY9dETrk3OHgepxlZAYvP+EWGTbL0aOfOsWU1M74c72IA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4N7WkY615Yz1CZn; Thu, 10 Nov 2022 19:15:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2AAJFHVM001028; Thu, 10 Nov 2022 19:15:17 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2AAJFHWU001027; Thu, 10 Nov 2022 19:15:17 GMT (envelope-from git) Date: Thu, 10 Nov 2022 19:15:17 GMT Message-Id: <202211101915.2AAJFHWU001027@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: 5fbf51588d20 - stable/13 - Remove a write-only variable. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 5fbf51588d2011dfc650a13f7b18311e4f3d5296 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=5fbf51588d2011dfc650a13f7b18311e4f3d5296 commit 5fbf51588d2011dfc650a13f7b18311e4f3d5296 Author: John Baldwin AuthorDate: 2021-05-11 21:56:23 +0000 Commit: John Baldwin CommitDate: 2022-11-10 18:26:22 +0000 Remove a write-only variable. While refactoring an earlier series of changes during review, the 'saved_data' variable stopped being used at the bottom of if_ioctl(). Suggested by: brooks Reviewed by: brooks, imp, kib Fixes: d17e0940f79f Rework compat shims in ifioctl(). Sponsored by: DARPA Differential Revision: https://reviews.freebsd.org/D30197 (cherry picked from commit ed93deba1106da2cd4755a61612c37bb67edc914) --- sys/net/if.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/net/if.c b/sys/net/if.c index 1f768ed1d4aa..aebda6d9e3ea 100644 --- a/sys/net/if.c +++ b/sys/net/if.c @@ -2922,7 +2922,6 @@ ifioctl(struct socket *so, u_long cmd, caddr_t data, struct thread *td) struct ifgroupreq ifgr; struct ifmediareq ifmr; } thunk; - caddr_t saved_data; u_long saved_cmd; struct ifconf32 *ifc32; struct ifdrv32 *ifd32; @@ -2949,7 +2948,6 @@ ifioctl(struct socket *so, u_long cmd, caddr_t data, struct thread *td) #ifdef COMPAT_FREEBSD32 saved_cmd = cmd; - saved_data = data; switch (cmd) { case SIOCGIFCONF32: ifc32 = (struct ifconf32 *)data;