From nobody Thu Nov 10 14:18:50 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N7P8X3DkLz4dbxn; Thu, 10 Nov 2022 14:18:52 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N7P8X2Jwpz4Hwg; Thu, 10 Nov 2022 14:18:52 +0000 (UTC) (envelope-from bapt@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668089932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CwLN8EuJjqoLI7svAZtPKFbOwiDBt5ZPHM3Q6hEtRI4=; b=vePJ4hdPgyPlxa2MjGqZlu0a2kPoJR6LIIRmVGXUf9VLmj6swgDOedvT/2SeS/e8dYhKFy tktdTCECddPY53hjwMUixbkrZkQh0hFayR51H4LHltOEzGU0kLdk1rgiD6l7NrM5wQcg5H vUHQ9a82pLj7tOj1WxNW0eRg0jnnAgSg50ofMsyfrDgvnJTqZSxD1PPvT9BaytDMKclzWO eO3X48nfaW15bntQRsaAve99I8kRnAz8v90BU3vKL2zxpQDx9JQePit0nyhqw47e2zcZLX YNxrDH7BG4oahoYqkkk04JWE/22X7AMaNcFOAUwPMEDmTADXMf70VkWKbnbnCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668089932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CwLN8EuJjqoLI7svAZtPKFbOwiDBt5ZPHM3Q6hEtRI4=; b=LOwgjXTkJo3HJlPTGg9ve7QeIvJ2AyUL25Rqr5pL5iX1/dIdANLqFRqzkxXcysw1+UWRxC EkNR5rGf0PDSPdvooZP3/EpHVee8ZRq+EKzEVqZXhLHb2Uo9bjw19DoWGikYZSQUBFYa6Y hjUHr0thEdY+G8pt/BkmCZqcft7KskrnyOlNg6acgDyjZSdnzvfceemZhlLUS4JLKhpvRh QjgZxZj/Hj/D4t+p4WQMSjztzE55+lRQ8oYU0WBSdUrR0Gr3ixdrN1akzlf7jbCINciy3O iI/wx3ObfLHxl8t2nAhgYzSJ1FTR2YFfxfUk2fiNsaDbyfdSShwJhKOEKqibNQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1668089932; a=rsa-sha256; cv=none; b=sCNXIvDQ+3R/GA1xi+dRSB/HKciHvwcx1NBOKaOrd/b0EIpqu8LFd1fp00YDurhvKyasVe 4gV9HR8Upb3xmfPPCNpR55tckq0EQmpieI7VYCgGGu+yvGu28oKyyrOLzCjNT6QjcWjnMe miZaTrs/FvOqWHjUv5CJmMUZPL/HKA8hvD3ppwgz6gUJ4EYLTw9d0MzTHYhlHk36e84oKt jQHaVTCVGooDoPU8znSYehXNwI73cD0QpreBYVukWUYMTpPoChNPvqysohNhJ/vvG554hZ 8I2Zv5S4z/ae2XKEPUO9CBIUWpi8UVSclt0vZytZoE1pSPz2Zi8GylOaSuKTAw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from aniel.nours.eu (nours.eu [176.31.115.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4N7P8X0WVJzZ5v; Thu, 10 Nov 2022 14:18:52 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id 61FFD6A8F8; Thu, 10 Nov 2022 15:18:50 +0100 (CET) Date: Thu, 10 Nov 2022 15:18:50 +0100 From: Baptiste Daroussin To: Matteo Riondato Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0b1adc42a15c - main - rc.sendmail: remove unused script Message-ID: <20221110141850.pcbfdvzxeggn6zxm@aniel.nours.eu> References: <202211091557.2A9FvdQ4072042@gitrepo.freebsd.org> <20221109174947.ykci234inrgiz7wi@ubertino.local> <4C690EC7-3D87-416B-934F-452801EE0EC8@FreeBSD.org> <20221110140106.rwup6yssxwaikp4d@ubertino.local> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221110140106.rwup6yssxwaikp4d@ubertino.local> X-ThisMailContainsUnwantedMimeParts: N On Thu, Nov 10, 2022 at 09:01:06AM -0500, Matteo Riondato wrote: > On 2022-11-09 at 14:29 EST, Baptiste Daroussin wrote: > > Le 9 novembre 2022 18:49:47 GMT+01:00, Matteo Riondato > > a écrit : > > > The one lingering issue I see is that there is now no documentation > > > for the rc.conf sendmail_* variables: they were documented in > > > rc.sendmail.8 and rc.conf.5 referred to it, but your previous commit > > > 6a2d6a569b1350f46998a2446fc89059b160fd13 removed that reference from > > > rc.conf.8, and this commit removes rc.sendmail.8. > > > > > > (Sorry for the noise if you're already working on it). > > > > I prefer too much noise than something forgotten in silence and actually > > this is no noise > > > > Such documentation is supposed to be in rc.conf(5). It would probably > > be a good idea to push the documentation there. > > > > If someone is interested be my guest, otherwise I will look into it in > > the next couple of weeks. > > Thank you for taking care of this one so quickly. > > A few rough corners I still see: > > 1) sendmail_cert_create should perhaps be set to NO in rc.conf, or the call > to sendmail_cert_create() in rc.d/sendmail should also depend on some form > of sendmail being enabled. The former action seems easier. Don't know, this has always been like this for a while. > > 2) the role of rc.d/othermta is quite bizarre, especially now that it checks > for a non-existing script (/etc/rc.sendmail). I wonder whether it should be > retired, together with the rc.conf variable mta_start_script (which now is > set to a non-existing script). It feels like a relic from a long gone past. https://lists.freebsd.org/archives/freebsd-arch/2022-November/000264.html It is a relic from the past (unused for 20 years) > > 3) the comments on some of the sendmail_* variables in rc.conf mention a > generic "MTA", but perhaps they should say "sendmail", as that's not the > one-and-only MTA. I am open to proposals/patches Bapt