From nobody Tue Nov 08 04:23:33 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N5w2v1ccqz4hJRf for ; Tue, 8 Nov 2022 04:23:51 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic314-21.consmr.mail.gq1.yahoo.com (sonic314-21.consmr.mail.gq1.yahoo.com [98.137.69.84]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4N5w2t4QwKz3qfM for ; Tue, 8 Nov 2022 04:23:50 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667881427; bh=qOsdwMW58828Dv1MQs7DpK7M6uBNkBqUH5bodvvG6AM=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=mvPdq3+VmPkFHOSfnCfeu2PnyNtuReyI9xhO5axBvj9yhH2LwEdXUiIl8XVpoTahGZorbUYtCxE2GRX8iAhmRsdyUAo4qDx6aK8PXXoUypLNv6XpAjIvJFDoASw/J0pMmJbGX114hywfHZ2TWREHe6D2DOTM0X6yErgqfs0+9GqUVcuCvT3wl0kH+Z8HKNP62AarFDT1OQ39dWokLituL4EcCogBQ9KVzjlWkq1Fmp6CDxcYvSTC2SG4nog4+N2F3qt/hPgyIt3gR3fR8Kosf6aFZeBVTXnaviwdV6cVG3DxcXa9+MjVrM+d1heeWrhyavvLFTTfggn9kJm/vmBHpw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667881427; bh=Li948xD4kTxKANvx5IJQx79sYgDkqZ4TEXWXKMM9tUk=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=mTU+h+tVANH8T/9ZbIxjm9B2lrIpHCmgRm+7LysdmlXUZG9XBAFq9pyLa6ZZovyI7SwlMYzs6Y8NbUCDo7fd5eew6RvpSeEOe+S9r7XPYE4keqoebXunQdSupTmhF8vTjpVD+5YKzT00qT0Kzy4zos8Brtz6WmzxxuRnoSEukKj2ftO1hWc4LWTIYWBpG5qPdeknExr34SBVlOiAGvkoV+Pjsas6OGf8fmGuteWMDthu/pU0HWv8Dd0Hcb5qSXgyPKwjkRKke7S6QXgmc4kTW7Wl6IKWdDISr2U4HPX3Srkep3NswIW+QH+TlSGrA8Grr5Ix1QYqroYZr2KY1o/JHA== X-YMail-OSG: ic_DCeoVM1mZ4CAn0mudoYu8cDNOpzt.j3qSkxw54Qz0oqrElWYDlCMKcjSLjij ziaAtPwo.T2He9_DewssQ.sWQptqL1wh2a9EoawUSNom7GGFBb71no0ajkxKMj6BVPxh1kct2dmW q8sNhuwIXCPliFt5w.xTCUT7PL8uQuOPGCZFDzyBwZOOr0QuQ39BcFRQMK42iRUNKzp57g8FDwY1 MFNfY6dXdwUEGOeTrew3gAL4E8m7Rh927_HKZzJia.HzrYQ5KXnv_gxF7mzVZwj9XfMduoGu3RN_ 4Yy4BYw7LEJT1b7O2G_uuzqvZNzqA9CrmpsmRHRjiIAePkfWSrspNnLF0kyDnsMrTnL_wu.DKdYZ OwlOklz_7vH2SqoU3u5Odmve0cwhEDhOpNHnoLmySCQKAf8FYPPJAPacKas_Oq1eUWxBNsMizbk_ rt03Gkwp0NPpEH7WTjMhCCCIt4S0XxNYvghEq6BsFPr8tbIyW5UOgNZVMhtpma2NWm63BzpgRTvE U4QOs_RitIpspmWL3Z6P_5uub5XiQAtKQFqZlnlOeXwoyjwLSSsBc8DGyd9ltEb2FlxTOtwUqgpl 0hB1s6ZQjPLB3DBDSpt.10pwDLJ9up.6QOXR3pesWTpy4t9zyoQKixIScQphQzCos7JFbi9yPBk7 GR9WKWBzd9qNWq7J75aOALEEY.KaDuC6NN24JUlIWsZ5BASyRjygKO2fXFZbRNfQhv8MpYssilL6 M9tTqqQyw._SKk7FTBDDE4eesJXmLiUrM4oac0Tw1NjVt.slWv7dJ_9_s84oeWagsuIwbgzx3PMq JbtyejRD59qySpPvqLvKzrPrFNHb3xDr4ZEeQ_0C8drknYkJ7xD8wZFhMiWNmGhw1319fYLrtmc8 Pvg6R9O1_Go_qM_0L8kVuAfs1KIizJPeE2P_kK61Pi_2mdam3LZ0gG25W1bjOhEehPoxzjPpwYj8 r0rBTZul_cGhzJUViZ5EHWyOZm47MhD6TIMYYX3GvEiijlkBkbK6X2qz2VMLmaZi1qv_NT.yQm8E q0guYKxM.09msb0.Sy1Kkfat9uM.C_wqu093FMjUrVq14005mcKnM1m5tmtGygC_JtHFuFLfwc.o qImPShM8eolmXdbz580DC4.G7LAqzdf2TZ1_6qZzUwFM70vdkHLW_Uoylwi9U5VVlt7GCPNp0g5j MSrCjhAyLDWjFh6_gmFqqqEY8RcmLpCtW50AJHzi0vnK.e15ij2XYlw75Gs20f7lmJix5_VuvYJJ lE6ztOVhfRVkis6527m7nQz5JG_jOVhZpR3SwYPeJPcS6f_vbQCbLgKHSi10fzkeDLDzstztLzOl Iqr1iz0OxLjELXWjK6hAngskS4VIP1HeZ2mfB7al2PMEvXwaOO1CvrmKer_jwZEWkpQUILZfiWmw 0HcawswLQBvztNV3GxidKpMeI.fzVrh8sBZrq_Pg1bYhkLfhJ3h4UiVekwOhXOf.FZjvpdwK4j_u Dk2o_.H6rKamAOmNXuNeWQCzD9XjZ.ozvumcIzZbUUZuih81bwmdhy7Xxkw0U.HJu6moMXxKvPDx aftsgjLvf4vL4yvpP3DW069zYyOxqjT3TZZWHLmnukfSUOjSQbCli4SfsEvX7eQ1ceUtRcmA4FsB hAHPc4Ta8lY5oNBxud465YELJbKwnlbfYYHzlCj7TojedtQELLQE9_FDTZmE0p6LdbPuv1KhaO_b S51UjtlVIVp.xWYtRxVZG45twk0sKDDN2FPnCWp6u8jHFDurrk1467Gvy4_cAQhv_m_ZVtPq2gMF ky.ym0ATx3wej2AF2six01YboXx2YzkHgqm3VHtp8oFcSNh0nNuLpcZ2G9OmmeWexNldcnIpA6VG j6egCGHkMhpWV_Bj9cTDNvt8ScWB3HzGiDpaYudFF9dD_oEyxmPj7HAUR4psd5v0jMFA4X74_5oO m.7PEJ7Ug9.NCS9ULtu2r8PqG5cEjrOrCWJX7AIavxFsc0Vz4Q8x4j9px3LZBBJLjZ1R0twYJO5N LK95zuTsa7DicL6XCPTOxfdMg8XKNS.A42Oxi9qUheNANBOaGJCORSNagSEgbfUTYgVDZ4loPmHC CNZPDLt_hSyfpY40XEADWNXbCz9905g9aciW1KfKaKzFfrahJRYGXg8aEgYMbTle8IiAQ0TxFqE5 Dg76pmpknZ3kBxMLPodHLU688dKgqS2shoF8ZAEV0aNbISsFYAyAonjYoOr5O2sCqPQQYU8s_jya c.WKqd2SFJKNxRNhcAyc3twFQuf343zJnt.DNO8SqWKSFsBn_DRnNdmoJIEd2qZX2I8k820p.zck - X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.gq1.yahoo.com with HTTP; Tue, 8 Nov 2022 04:23:47 +0000 Received: by hermes--production-ne1-6bcfb7fb87-xm7g8 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID af8eba40329f2feb8af2a64a8d4a2729; Tue, 08 Nov 2022 04:23:45 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.200.110.1.12\)) Subject: Re: 3bf53c4c8f53 - main - release(7): Enable zpoolupgrade rc script in ZFS based VM images From: Mark Millard In-Reply-To: <6699F3B1-3CCB-4A03-A4EB-86D34ECD28BB@panasas.com> Date: Mon, 7 Nov 2022 20:23:33 -0800 Cc: Li-Wen Hsu , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <4B38B373-B935-40FD-B1A2-AA85B6F5C9F1@yahoo.com> References: <202211070350.2A73oo64051412@gitrepo.freebsd.org> <9A7B38D3-9BC4-4B45-A71D-0604F7F4887A@panasas.com> <6699F3B1-3CCB-4A03-A4EB-86D34ECD28BB@panasas.com> To: Ravi Pokala X-Mailer: Apple Mail (2.3731.200.110.1.12) X-Rspamd-Queue-Id: 4N5w2t4QwKz3qfM X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US] X-ThisMailContainsUnwantedMimeParts: N On Nov 7, 2022, at 11:34, Ravi Pokala wrote: > -----Original Message----- > From: Li-Wen Hsu > Date: 2022-11-06, Sunday at 22:48 > To: Ravi Pokala > Cc: , , = > Subject: Re: 3bf53c4c8f53 - main - release(7): Enable zpoolupgrade rc = script in ZFS based VM images >=20 > On Mon, Nov 7, 2022 at 1:33 PM Ravi Pokala = wrote: >>=20 >> Hi Li-Wen, >>=20 >> If I'm reading this (and 72a1cb05cd23) correctly, this will run = `zpool upgrade' on the "zroot" pool on every boot. That's fine for the = first time a VM image is used, since presumably the root pool and the = bootloader were generated from the same sources. But if the root pool is = subsequently upgraded by the running VM, don't we need to make sure the = bootloader is also upgraded? Otherwise, don't we run into the = possibility of this new `zpoolupgrade' script enabling features which = are not supported by the bootloader? >>=20 >> There should be some mechanism for upgrading the bootloader, or else = something else that runs on the first boot from the VM image should = disable `zpoolupgrade' so it is only run the first time. >>=20 >> Thanks, >>=20 >> Ravi (rpokala@) >=20 > The zpoolupgrade rc script has "KEYWORD: firstboot" so it is only > executed when the ${firstboot_sentinel} file exists, it works in = the > same way as growfs and zpoolreguid rc scripts. I've been thinking > renaming these to firstboot_* as others provided by > sysutils/firstboot-* from ports, but I think it's also fine to keep > the consistency for now. >=20 > Ah! I completely missed the 'firstboot' keyword. That sounds much = better! >=20 > That said, Mark Millard brought up a good point about only enabling = features supported by RELEASE bootloaders. >=20 > Thanks, >=20 > Ravi (rpokala@) Reviewing the zpool features, there is at least one for which: "This feature becomes active as soon as it is enabled and will never return to being enabled." (or analogous). There are ones for which: "READ-ONLY COMPATIBLE no" Some have both statuses, for example, head_errlog. However, the loader may do so little that its stage avoids the general "READ-ONLY COMPATIBLE no" status for some features. =3D=3D=3D Mark Millard marklmi at yahoo.com