From nobody Mon Nov 07 11:15:14 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N5TDT2czGz4gjMq; Mon, 7 Nov 2022 11:15:37 +0000 (UTC) (envelope-from Alexander@leidinger.net) Received: from mailgate.Leidinger.net (mailgate.leidinger.net [IPv6:2a00:1828:2000:313::1:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-256) client-digest SHA256) (Client CN "mailgate.leidinger.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N5TDS0BmGz3xcN; Mon, 7 Nov 2022 11:15:36 +0000 (UTC) (envelope-from Alexander@leidinger.net) Received: from outgoing.leidinger.net (p508d4280.dip0.t-ipconnect.de [80.141.66.128]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256 client-signature ECDSA (P-256) client-digest SHA256) (Client CN "outgoing.leidinger.net", Issuer "R3" (verified OK)) by mailgate.Leidinger.net (Postfix) with ESMTPSA id 5579428180; Mon, 7 Nov 2022 12:15:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leidinger.net; s=outgoing-alex; t=1667819720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=NVKVEh5fVTD0DdEY752jE+mQTtfOORp6HcUWf+G89GI=; b=GMRPIgAivE3bOufIDLjAvhyEWS09tYJG1qwRndXF98scroYXbqsUaK2DSrDE3MVZvY2F9G X85SLOrpccgJ2/8BX4enTBxDWmqYPNc4YZPgKexz6YVTvDgug+mAt5nkDde2kRGAsS8LIv Flo1gPKwthEydh22IxlW4iq3ZsYcofvqkoU+mNBEGn+oemLUAea2PnQUG0BXIMemMaA/JG xO7g1z/1iti87oX9B3rtpzW50c+NKe24NjkjT0Hm617lB6rKnupog1yDuqBDlazZgVnGMl fHLj+N+cqqUN29LNbAxO+p3ZAa0DTzbjhDAKvpDC/sWGh/J9gD2BwNDRIukJNA== Received: from webmail.leidinger.net (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (Client did not present a certificate) by outgoing.leidinger.net (Postfix) with ESMTPS id 37AAC470B; Mon, 7 Nov 2022 12:15:15 +0100 (CET) Date: Mon, 07 Nov 2022 12:15:14 +0100 Message-ID: <20221107121514.Horde.nulS9Wg1s3yzAsXXkuJRBa9@webmail.leidinger.net> From: Alexander Leidinger To: Li-Wen Hsu Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 72a1cb05cd23 - main - rc(8): Add a zpoolupgrade rc.d script In-Reply-To: <202211070339.2A73dJlO027991@gitrepo.freebsd.org> Accept-Language: de,en Content-Type: multipart/signed; boundary="=_oy-tqzi5u_E8mvyoMqvqEaH"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 X-Rspamd-Queue-Id: 4N5TDS0BmGz3xcN X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=leidinger.net header.s=outgoing-alex header.b=GMRPIgAi; dmarc=pass (policy=quarantine) header.from=leidinger.net; spf=pass (mx1.freebsd.org: domain of Alexander@leidinger.net designates 2a00:1828:2000:313::1:5 as permitted sender) smtp.mailfrom=Alexander@leidinger.net X-Spamd-Result: default: False [-6.09 / 15.00]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.993]; DMARC_POLICY_ALLOW(-0.50)[leidinger.net,quarantine]; R_DKIM_ALLOW(-0.20)[leidinger.net:s=outgoing-alex]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[leidinger.net:+]; MIME_TRACE(0.00)[0:+,1:+,2:~]; MID_RHS_MATCH_FROMTLD(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:34240, ipnet:2a00:1828::/32, country:DE]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N This message is in MIME format and has been PGP signed. --=_oy-tqzi5u_E8mvyoMqvqEaH Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Quoting Li-Wen Hsu (from Mon, 7 Nov 2022 03:39:19 GMT): > The branch main has been updated by lwhsu: > > URL:=20=20 >=20https://cgit.FreeBSD.org/src/commit/?id=3D72a1cb05cd230ce0d12a7180ae65d= dbba2e0cb6d > > commit 72a1cb05cd230ce0d12a7180ae65ddbba2e0cb6d > Author: Li-Wen Hsu > AuthorDate: 2022-11-07 03:30:09 +0000 > Commit: Li-Wen Hsu > CommitDate: 2022-11-07 03:30:09 +0000 > > rc(8): Add a zpoolupgrade rc.d script > > If a zpool is created by makefs(8), its version is 5000, i.e., all > feature flags are off. Introduce an rc script to run `zpool upgrade` > over the assigned zpools on the first boot. This is useful to the > ZFS based VM images built from release(7). > diff --git a/share/man/man5/rc.conf.5 b/share/man/man5/rc.conf.5 > index f9ceabc83120..43fa44a5f1cb 100644 > --- a/share/man/man5/rc.conf.5 > +++ b/share/man/man5/rc.conf.5 > @@ -24,7 +24,7 @@ > .\" > .\" $FreeBSD$ > .\" > -.Dd August 28, 2022 > +.Dd November 7, 2022 > .Dt RC.CONF 5 > .Os > .Sh NAME > @@ -2109,6 +2109,13 @@ A space-separated list of ZFS pool names for=20=20 >=20which new pool GUIDs should be > assigned upon first boot. > This is useful when using a ZFS pool copied from a template, such=20=20 >=20as a virtual > machine image. > +.It Va zpool_upgrade > +.Pq Vt str > +A space-separated list of ZFS pool names for which version should=20=20 >=20be upgraded > +upon first boot. > +This is useful when using a ZFS pool generated by > +.Xr makefs 8 > +utility. For someone who knows ZFS well, it is clear that only a zpool upgrade=20=20 is=20done. Not so experienced people may assume there is a combination=20= =20 of=20zpool upgrade and zfs upgrade (more so for people which do not know=20= =20 what=20the difference is). Maybe you want to add some explicit=20=20 documentation,=20that zfs upgrade + feature flags needs to be done by=20=20 hand. And=20this brings me to a second topic, we don't have an explicit list=20= =20 of=20features which are supported by the bootloader (I had a look at the=20= =20 zfs=20and the boot related man pages, if I overlooked a place, then the=20= =20 other=20places should reference this important part with some text). Bye, Alexander. --=20 http://www.Leidinger.net=20Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF http://www.FreeBSD.org netchild@FreeBSD.org : PGP 0x8F31830F9F2772BF --=_oy-tqzi5u_E8mvyoMqvqEaH Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIzBAABCAAdFiEER9UlYXp1PSd08nWXEg2wmwP42IYFAmNo6MIACgkQEg2wmwP4 2IbJNBAAh3DGxNxUgXQB5028KYHm4A8H58o6alhWPLTc6aNfC43CZqNcKqJuWbsH 62tB/Vfje/diinkuKrx3DYsrSyn6dWQhFoqojpcfHDeOVlfdukksjOmR4Os6x8DL h2xCnz6KIOzLBjNzOu9ynsWxa+LixwyEusHhgybEq8BqG4uA7miMsYwyxlFMV+NY 1RYtL8rXyWk9uX6M9TvFu+Xzsg+umzKiDG93+dJZ9GUUbMzQKgwhnfrsszYS/pDB h3wNh+ZmxCc9efNB9iq+Wpas29ZpelqR6RThlpyTkNpxJ0UYg/p8YLoX85/gGPF+ ctRRue7NHAxtmvkPbX0CLU/AB8e9KeQ2MLfUgNz0DnESqBOdXMkPOVLvVtPZwWgx FresPImHmfCTyDZLZlA4eIglfrQEry5kO0Nu3BscmVhyUV3F1eYLFnT/3+b737yD gOHIHOswJkQMeHd6OQxISBWnl1+1EivHEY8Vu98RSAoGVyKtRX+GZ3DHgM9zcgW2 Cg7/OlcZxz+HJ4OUmJpmPLITSISZ5H6iBhBxt4NzaDRJs3Hd6Cnm9F1OfHumrTNa Wue34Lb2lGYtkj1Ewh++t3R6Hd3R9IR9WLDMNj5e4VSxelqpYjRW7KSiuA2Oog2D fIzrqEiGo+xVHjZgDMAssbBVmBFZM+/y93UDVOYThdlWjO62jCk= =alMg -----END PGP SIGNATURE----- --=_oy-tqzi5u_E8mvyoMqvqEaH--