From nobody Thu Nov 03 14:39:51 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N35xz4ftZz4h929; Thu, 3 Nov 2022 14:39:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N35xz3q8Xz3g5f; Thu, 3 Nov 2022 14:39:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1667486391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vBle/N/YxUnSbrS8YvtRK8jNkiIVT1dgU/sGOgreT2A=; b=VNWXsgfong4kJ9dLVitQRaKkvRgYWJHCU1Obgiq/J5g9f6OMIXwWL2xKsgnmLLYu5ZlNql nY9HRoUX5utOrCsvVp80n1dVy7ZDya9oPWTBk5Byb7m8Ob9UMv+hjxiCYpp5N0WJ+iwGi9 g+dNQ/GULjHiwngA51H+Nc4/1jpp0R5TM/t0N8P2xFAtMPOKBYuwtEU/k3IAyvKC0Oa9ny aeQUn+Q4IsODiX9cmzfv0vNCATi/S15cUphOtPMrOk0ICnSicl4hXAlgz5CE0fecDYSdHt AR2BbjbJTNnNUK8Wd2gpN8BTGhUaTTbIi0D4Nyc0f+ZQBLZkKZqbnXql8kFjuA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4N35xz2XftzfYw; Thu, 3 Nov 2022 14:39:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2A3EdpVQ089509; Thu, 3 Nov 2022 14:39:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2A3EdpMw089508; Thu, 3 Nov 2022 14:39:51 GMT (envelope-from git) Date: Thu, 3 Nov 2022 14:39:51 GMT Message-Id: <202211031439.2A3EdpMw089508@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 909e2e1b6c34 - main - ping: Remove a vestigial notdef List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 909e2e1b6c340af2581be30aaa38bc8d97c55532 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1667486391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vBle/N/YxUnSbrS8YvtRK8jNkiIVT1dgU/sGOgreT2A=; b=TgM2yVRxMR7nqN4uwlXRaM7fib3STkU7p5azhmf1ypQ4vWIIBqoa4GLzmdXIXD6QOaLSjw yhuM/v/vHgNrb1MvMx4SUT03k6gccGjY1c7ZIaweh24dE2wZs5rKyICaNDVXa13qCPxaoy 6G+gGZ8/VzOk5DMXvmRMpZ6RLQrhNXTUjBFy2ij2POU9Af/H0OuGwq5YKip7KPiLCK4MKL r/D7e+LsHYuJciBDp041KO0kWjsmzMjy7QUQ5jh1gQ55spIaNfudI5NsUF9kQg1B9Sbc+i Nr/4gZ8UzDApmBYwjsrz9qPWccj5kX9g448NiM7XACIn7a3cwHWs8qwEvfvJDg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1667486391; a=rsa-sha256; cv=none; b=wX9YMf1rnogCL8R2f/NjyV21+r5CK2ehUv+RaHmM6ocYUBJipY4XOACRYeHt3wPPREP0SD jZDgX/U63/Qzqc4rbvDmxJDo203IHpK6omROWJj2Td+qXMwy86vgNTIlrwZAvThyPNNqAs +IJJAt2Anf2VQsUkFBnRkH5qZfQ6PkW4eYeDe8yPyshmAdXW5m8Ag5wmBouJpp/MUcC3ke Zbky14H9h1rXwyqm6FSM2Y3yvMqUHyvRMA5UPRQnZt1+HYVcQbCVs4+3Bh0tl3GxTjwHz+ bXoGn31Tcm263Um/iiVLP6zBPfwoSKXpqwW+Pup254BH+Y2QHdhwS+fqdVzM8g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=909e2e1b6c340af2581be30aaa38bc8d97c55532 commit 909e2e1b6c340af2581be30aaa38bc8d97c55532 Author: Jose Luis Duran AuthorDate: 2022-11-01 08:01:36 +0000 Commit: Mark Johnston CommitDate: 2022-11-03 14:39:32 +0000 ping: Remove a vestigial notdef It was once a function on 4.3BSD, pr_type() [1], used to convert an ICMP "type" field to a printable string. In 4.4BSD it was superseded by pr_icmph() [2]. NetBSD [3] and OpenBSD [4] have already removed it. [1]: https://minnie.tuhs.org/cgi-bin/utree.pl?file=4.3BSD/usr/src/etc/ping.c [2]: https://minnie.tuhs.org/cgi-bin/utree.pl?file=4.4BSD/usr/src/sbin/ping/ping.c [3]: https://github.com/NetBSD/src/commit/203dfd34867991fd002f747d74a96f26ae80d41c [4]: https://github.com/openbsd/src/commit/9bbbbbb75d24e3d166ddd0cb6cb4417b78561309 Reviewed by: markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D37247 --- sbin/ping/ping.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/sbin/ping/ping.c b/sbin/ping/ping.c index cfef81f76099..4c4326f98f61 100644 --- a/sbin/ping/ping.c +++ b/sbin/ping/ping.c @@ -1484,22 +1484,6 @@ finish(void) exit(2); } -#ifdef notdef -static char *ttab[] = { - "Echo Reply", /* ip + seq + udata */ - "Dest Unreachable", /* net, host, proto, port, frag, sr + IP */ - "Source Quench", /* IP */ - "Redirect", /* redirect type, gateway, + IP */ - "Echo", - "Time Exceeded", /* transit, frag reassem + IP */ - "Parameter Problem", /* pointer + IP */ - "Timestamp", /* id + seq + three timestamps */ - "Timestamp Reply", /* " */ - "Info Request", /* id + sq */ - "Info Reply" /* " */ -}; -#endif - /* * pr_icmph -- * Print a descriptive string about an ICMP header.