git: 0d6600b579be - main - Set mm before passing it to the UEFI firmware
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 21 May 2022 11:06:21 UTC
The branch main has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=0d6600b579be769b85f049ef421023316f21b5c3 commit 0d6600b579be769b85f049ef421023316f21b5c3 Author: Andrew Turner <andrew@FreeBSD.org> AuthorDate: 2022-05-21 10:45:41 +0000 Commit: Andrew Turner <andrew@FreeBSD.org> CommitDate: 2022-05-21 10:45:41 +0000 Set mm before passing it to the UEFI firmware When reading the UEFI memory map we pass in a pointer to the memory to hold the map. Unfortunately it wasn't initialised before the first use so clang decided it was undefined behaviour so the entire loop was removed. This leads to everything in bi_load after this to also be removed as dead code. The next function after bi_load in the binary is efi_copy_init. The above caused us to enter efi_copy_init with a return address of the start of the function. Because of this it would enter an infinite loop of calling the function, allocating memory, then returning to the start of the function. PR: 264021 --- stand/efi/loader/bootinfo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/stand/efi/loader/bootinfo.c b/stand/efi/loader/bootinfo.c index ca7a2c8ce4b8..c7b682819a98 100644 --- a/stand/efi/loader/bootinfo.c +++ b/stand/efi/loader/bootinfo.c @@ -347,6 +347,7 @@ bi_load_efi_data(struct preloaded_file *kfp, bool exit_bs) */ sz = 0; + mm = NULL; /* * Matthew Garrett has observed at least one system changing the