From nobody Wed May 11 07:41:21 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 76C751AC2FAC; Wed, 11 May 2022 07:41:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kyn0K6Cgvz4b3Y; Wed, 11 May 2022 07:41:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652254882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2xaFEoo99kHeAt1ofzqbCkAYLrwcGkws6prUFZnYIdA=; b=hn2bY5YYf6Bm3i8u1gjX3CjtPap4i28f/jquws5gGP5o0M9pIq3WZGnoTG1oCh8mwq33BQ cQAryRyhFDVOm9lmW5jSXvB36JnFT3WC2HiCGRJ4bmiOqA1qRajjW6JgeU8CNGBTJTU0qG fT2YCJsUnpa/36+tityt1I13jHq5+cT1AMINTW1mY4Na1NEOgiGmQlQV6gZFqZzVpJbPMq 7i2joU+UTsefo5+aq583hbvzExc7fhB9cWGYOhWtcsCSeXLsIPXd8tysWqZrJvswPzLnyW +jkQh31MhJS9xd+josgpra2IDfTO8jX1dHux2l5IByTV56ZDnEBep9o87X6Egg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 569CD15A79; Wed, 11 May 2022 07:41:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 24B7fLwF042161; Wed, 11 May 2022 07:41:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 24B7fLXE042154; Wed, 11 May 2022 07:41:21 GMT (envelope-from git) Date: Wed, 11 May 2022 07:41:21 GMT Message-Id: <202205110741.24B7fLXE042154@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dmitry Chagin Subject: git: 586ed321068b - main - kdump: Decode cpuset_t. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dchagin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 586ed321068b883e33df0e41ca913c074e6ea53d Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652254882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2xaFEoo99kHeAt1ofzqbCkAYLrwcGkws6prUFZnYIdA=; b=jLPmghq/S20EMAy0pH+Cb6IU/tepld4sytYXxR0jZw5j56kI9LV9dgn++aivrEUtQJSzF1 Q9O843dFDriXqYAMdrVanXpTL3UA4Gl/WqpEHZUDK4Uatam10/enGFQx9rfhCJwypFSJFg 0NGGeyZfzCFp6D+3HQ8P+xbn4QZ1RowOX0f+AimXwKLLHqsIHvjZSiWf0pvZysrGiLZFVw VwwuIa+LeOavQjRyMLLrE2ejE20xyQncqN7pz2yQFupkkA6VIIQsOE817LLsLr2q4Yuos0 7JO58ZXB0cWQ7psSevgHh4jGUYqjjr3pR0DiU2ErcdvRKLubbsAxhqUGtYyJqw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1652254882; a=rsa-sha256; cv=none; b=ewE1A7FDttZA1xIV376X2VOOuPeg1G6XiHou/nbRUq92NNsJ/W9g7BjCwiuoiFPL8a3vQu T/MH7pnioZaTxmnaZEhbtnlqWc5x9ZjBdm57b9bWlYXWz3HPfXFtcLByG1i9WcEUbNCUSR zoEqlP1jkit+VPvuheV7dOx0iMunwssNZUTkqdLPQkqYl3KGlkg4o/dYCnlnVlpA/XXLCU mMxr+SUwIxmPRxWPvr1Wa+U+kKcc3pNqynk5Q+xuzr54sms9E4t9VIMbx3F+9P4NPv1a2a Q+xumh8Tqro226Di/MRdqyL/amBUExAveKe/xj5ArMOxCYfM3P/Hx+6n7g1t6A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by dchagin: URL: https://cgit.FreeBSD.org/src/commit/?id=586ed321068b883e33df0e41ca913c074e6ea53d commit 586ed321068b883e33df0e41ca913c074e6ea53d Author: Dmitry Chagin AuthorDate: 2022-05-11 07:40:39 +0000 Commit: Dmitry Chagin CommitDate: 2022-05-11 07:40:39 +0000 kdump: Decode cpuset_t. Reviewed by: jhb Differential revision: https://reviews.freebsd.org/D34982 MFC after: 2 weeks --- sys/kern/kern_cpuset.c | 10 ++++++++++ sys/sys/ktrace.h | 2 ++ usr.bin/kdump/kdump.c | 40 +++++++++++++++++++++++++++++++++++++++- 3 files changed, 51 insertions(+), 1 deletion(-) diff --git a/sys/kern/kern_cpuset.c b/sys/kern/kern_cpuset.c index b02f33dddf1b..56d92687a693 100644 --- a/sys/kern/kern_cpuset.c +++ b/sys/kern/kern_cpuset.c @@ -34,6 +34,7 @@ __FBSDID("$FreeBSD$"); #include "opt_ddb.h" +#include "opt_ktrace.h" #include #include @@ -61,6 +62,7 @@ __FBSDID("$FreeBSD$"); #include #include #include +#include #include #include @@ -1995,6 +1997,10 @@ kern_cpuset_getaffinity(struct thread *td, cpulevel_t level, cpuwhich_t which, cp++; } } +#ifdef KTRACE + if ( KTRPOINT(td, KTR_STRUCT)) + ktrcpuset(mask, size); +#endif } out: free(mask, M_TEMP); @@ -2028,6 +2034,10 @@ kern_cpuset_setaffinity(struct thread *td, cpulevel_t level, cpuwhich_t which, struct proc *p; int error; +#ifdef KTRACE + if (KTRPOINT(td, KTR_STRUCT)) + ktrcpuset(mask, sizeof(cpuset_t)); +#endif error = cpuset_check_capabilities(td, level, which, id); if (error != 0) return (error); diff --git a/sys/sys/ktrace.h b/sys/sys/ktrace.h index d00981a93d24..f417fdf8a22a 100644 --- a/sys/sys/ktrace.h +++ b/sys/sys/ktrace.h @@ -307,6 +307,8 @@ void ktrcapfail(enum ktr_cap_fail_type, const cap_rights_t *, ktrstruct("stat", (s), sizeof(struct stat)) #define ktrstat_error(s, error) \ ktrstruct_error("stat", (s), sizeof(struct stat), error) +#define ktrcpuset(s, l) \ + ktrstruct("cpuset_t", (s), l) extern u_int ktr_geniosize; #ifdef KTRACE extern int ktr_filesize_limit_signal; diff --git a/usr.bin/kdump/kdump.c b/usr.bin/kdump/kdump.c index 845e2000a4c2..0f4ac9a0c262 100644 --- a/usr.bin/kdump/kdump.c +++ b/usr.bin/kdump/kdump.c @@ -48,8 +48,11 @@ __FBSDID("$FreeBSD$"); #define _WANT_KEVENT32 #endif #define _WANT_FREEBSD11_KEVENT +#define _WANT_FREEBSD_BITSET #include #include +#include +#include #include #include #include @@ -119,6 +122,7 @@ void ktrfault(struct ktr_fault *); void ktrfaultend(struct ktr_faultend *); void ktrkevent(struct kevent *); void ktrstructarray(struct ktr_struct_array *, size_t); +void ktrbitset(char *, struct bitset *, size_t); void usage(void); #define TIMESTAMP_NONE 0x0 @@ -1967,6 +1971,30 @@ ktrstat(struct stat *statp) printf(" }\n"); } +void +ktrbitset(char *name, struct bitset *set, size_t setlen) +{ + int i, maxi, c = 0; + + if (setlen > INT32_MAX) + setlen = INT32_MAX; + maxi = setlen * CHAR_BIT; + printf("%s [ ", name); + for (i = 0; i < maxi; i++) { + if (!BIT_ISSET(setlen, i, set)) + continue; + if (c == 0) + printf("%d", i); + else + printf(", %d", i); + c++; + } + if (c == 0) + printf(" empty ]\n"); + else + printf(" ]\n"); +} + void ktrstruct(char *buf, size_t buflen) { @@ -1977,6 +2005,7 @@ ktrstruct(char *buf, size_t buflen) struct itimerval it; struct stat sb; struct sockaddr_storage ss; + struct bitset *set; for (name = buf, namelen = 0; namelen < buflen && name[namelen] != '\0'; @@ -1992,7 +2021,7 @@ ktrstruct(char *buf, size_t buflen) goto invalid; /* sanity check */ for (i = 0; i < (int)namelen; ++i) - if (!isalpha(name[i])) + if (!isalpha(name[i]) && name[i] != '_') goto invalid; if (strcmp(name, "caprights") == 0) { if (datalen != sizeof(cap_rights_t)) @@ -2016,6 +2045,15 @@ ktrstruct(char *buf, size_t buflen) if (datalen != ss.ss_len) goto invalid; ktrsockaddr((struct sockaddr *)&ss); + } else if (strcmp(name, "cpuset_t") == 0) { + if (datalen < 1) + goto invalid; + set = malloc(datalen); + if (set == NULL) + errx(1, "%s", strerror(ENOMEM)); + memcpy(set, data, datalen); + ktrbitset(name, set, datalen); + free(set); } else { printf("unknown structure\n"); }