Re: git: 868bf82153e8 - main - if: avoid interface destroy race
- In reply to: Kristof Provost : "git: 868bf82153e8 - main - if: avoid interface destroy race"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 06 May 2022 12:46:23 UTC
On 5/6/22 13:56, Kristof Provost wrote: > The branch main has been updated by kp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=868bf82153e8ff22f09a8860c872149e0fb6bdef > > commit 868bf82153e8ff22f09a8860c872149e0fb6bdef > Author: Kristof Provost <kp@FreeBSD.org> > AuthorDate: 2022-03-27 18:23:25 +0000 > Commit: Kristof Provost <kp@FreeBSD.org> > CommitDate: 2022-05-06 11:55:08 +0000 > > if: avoid interface destroy race > > When we destroy an interface while the jail containing it is being > destroyed we risk seeing a race between if_vmove() and the destruction > code, which results in us trying to move a destroyed interface. > > Protect against this by using the ifnet_detach_sxlock to also covert > if_vmove() (and not just detach). > > PR: 262829 > MFC after: 3 weeks > Differential Revision: https://reviews.freebsd.org/D34704 > --- > sys/net/if.c | 22 ++++++++++++++++++++-- > tests/sys/net/if_clone_test.sh | 29 +++++++++++++++++++++++++++++ > 2 files changed, 49 insertions(+), 2 deletions(-) > There are more issues like this: https://reviews.freebsd.org/D28136 --HPS