Re: git: 28903f396af4 - main - ng_pppoe: introduce new sysctl net.graph.pppoe.lcp_pcp

In reply to: Gleb Smirnoff : "Re: git: 28903f396af4 - main - ng_pppoe: introduce new sysctl net.graph.pppoe.lcp_pcp"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Eugene Grosbein <eugen_at_freebsd.org>
Date: Mon, 02 May 2022 21:09:35 UTC

03.05.2022 3:53, Gleb Smirnoff wrote:

> So some packets sent by ng_ppp(4) need to be specially tagged so that vlan(4)
> understands them. Why do we make this tagging in ng_pppoe(4) rather than in
> ng_ppp(4)?

This is limited to PPPoE intentionally because of troubles that may happen
in case of unintentional reorder of PPP frames due to different Class of Service.

It was tested for PPPoE case and believed to be safe in case of controlled transport network.
It was not tested in general case of PPP over GRE (pptp) or other PPP-in-IP incapsulations,
so I decided it's better to be safe than sorry.

OTOH, I doubt it may be really useful for cases other than PPPoE.