From nobody Sun May 01 17:27:38 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2E8101ABAB29; Sun, 1 May 2022 17:27:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KrtTR0c3Nz4rf7; Sun, 1 May 2022 17:27:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651426059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3lYiOp/4bmf498LmhELBqj/PMJNvokamRdy02qYuw4A=; b=ZWo6HEaiD0fRnJnHPSqDuYvaFZx7jxDyrxRZiBaV+8BGmNvZv9A1YXQFl0lEzWH2glTzji 5n7z5yHb8lwF/rEX/oyzu10A3F3Hsn43vMYZMSuW66T26IunJKNoueVqO51NWcvSxXF3D1 omyG1a/4/gBxf/zVPd8BO5Pc1ChYfqABObRQkVrwlt6DZ1C1mXMfAo90rU6iO5ZI6+Wg7V feVW0BXqqUmakIdjAP28YPwA/hHL29gRbTqZKr+8WRD2mb2ggPpieyo5yjAkMU3aSTLyhr gXaG03HFKcUGYqRgEeC7aPrAzMi4fQYErQqNTRAmJQrS+Eo1yHfoa7/r6GVhvw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id DFFA619958; Sun, 1 May 2022 17:27:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 241HRcPN061980; Sun, 1 May 2022 17:27:38 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 241HRcUI061979; Sun, 1 May 2022 17:27:38 GMT (envelope-from git) Date: Sun, 1 May 2022 17:27:38 GMT Message-Id: <202205011727.241HRcUI061979@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: b65803ba5773 - main - cam iosched: default to no read bias in dynamic ioscheduling List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b65803ba5773d5fb37fa2403105db199569a5811 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1651426059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3lYiOp/4bmf498LmhELBqj/PMJNvokamRdy02qYuw4A=; b=PIiHejd4U+RRpQs4wLi51oPBWwfUD9x0fhDAqX68nYjOQpTni4iVbidiCWHeJ5eaY8LAx2 UlB3BynUnjnC+SpwDDWQAbZ91xHDeQmdtfdnJendoPXGoQstYA9nXk5xDpK3kYi2+1kdFp uvJrgE9XRcgMRfESwWhVHFHPEyH53dJMtGa1JgdOTkJZOFb7UrDUU8bMQwDIlhTSHg0X2H gh8VS24Qx8Kt3rIJ7N2G5GpjaQZf9L8nrsCQxe5C48cBzFLfmDR9rza/TNpkyavfc0BSYc ESULvdzKA0zUS9IhOreH/6TTUrXFHs4jQ71YB3dQl/wFaR0rNj2qIbaik7N6MA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1651426059; a=rsa-sha256; cv=none; b=ScseKJfbcxR4wWRDl8MumuCwKqhIcU8F3T9M+QvfuJc/Ns5Koml+uBkrNeF0E7ysjfrjpE xnzeAHUbJdBq5gXX2KqtUdbGuI9ls7lsob19UvhBJD8+q/+McQUu7fl3F0Hy/V1672VGfV W+8ScaoBKD7Zxjobs37eiGwW5qzeQo3HN7ZX6Z56p/Dgm89NYTollTWpY61uHiUPLpDpz4 KnNDUR2OBPLMSzk2wtz//Vza/F7a3WH4uy9a3I7YwrfxzVL57KaiWF5XTupF/s0JHE1g21 JUr9JBS2R3mSEObVJlqDwd2J8HCK6KfvvLCFy/gtqEgp7Lo321TxPFwUM17k6w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=b65803ba5773d5fb37fa2403105db199569a5811 commit b65803ba5773d5fb37fa2403105db199569a5811 Author: Warner Losh AuthorDate: 2022-05-01 17:18:23 +0000 Commit: Warner Losh CommitDate: 2022-05-01 17:27:34 +0000 cam iosched: default to no read bias in dynamic ioscheduling When we're doing dynamic I/O scheduling, don't default to a read bias of 100. Default it to 0 so turning on dynamic scheduling only does scheduling tweaks that are requested. The other limiters are off by default, and need no further adjustment. Sponsored by: Netflix --- sys/cam/cam_iosched.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/cam/cam_iosched.c b/sys/cam/cam_iosched.c index 7ddfabbe5125..21a948b69c69 100644 --- a/sys/cam/cam_iosched.c +++ b/sys/cam/cam_iosched.c @@ -1149,8 +1149,8 @@ cam_iosched_init(struct cam_iosched_softc **iscp, struct cam_periph *periph) #ifdef CAM_IOSCHED_DYNAMIC if (do_dynamic_iosched) { bioq_init(&(*iscp)->write_queue); - (*iscp)->read_bias = 100; - (*iscp)->current_read_bias = 100; + (*iscp)->read_bias = 0; + (*iscp)->current_read_bias = 0; (*iscp)->quanta = min(hz, 200); cam_iosched_iop_stats_init(*iscp, &(*iscp)->read_stats); cam_iosched_iop_stats_init(*iscp, &(*iscp)->write_stats); @@ -1234,7 +1234,7 @@ void cam_iosched_sysctl_init(struct cam_iosched_softc *isc, SYSCTL_ADD_INT(ctx, n, OID_AUTO, "read_bias", CTLFLAG_RW, - &isc->read_bias, 100, + &isc->read_bias, 0, "How biased towards read should we be independent of limits"); SYSCTL_ADD_PROC(ctx, n,