From nobody Wed Jun 29 09:37:34 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3D97487332A; Wed, 29 Jun 2022 09:37:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LXxFq1ClMz3P2m; Wed, 29 Jun 2022 09:37:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1656495455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BU77yc2Jrn4A1gvg8nINNtWVO4OSVhWSeiR4pYn08ao=; b=x2yydmz7UnVXw5H76JzHEx5EHKPBMVVdRGmEzkfayNelVNCNDiT54YY23eVL2t9XOLIGGe F7uJfnmHE3VrXB5sP+sa0JxHsxYFVdCzl4Ecf//UqCZMD/3E1spmO47FGofz35GNntLbeO hRLbKJwuCTaM38Qkdah5/SUQUPQ+WDMbCG0q5HgoFkBfpeIB7AJl0Qs4y6WCxw5sdnJDAK Y9oXsHg70Qo2m7+1v2P2P+mGjL3aD0K9xBsUtBkROTU22su/kXBtDK4BZRVNZl8Pd1jK68 2p96dkLJP+g/T7VKf29tThoijoWXIgi5vsBHI0HrEYknlvrFPHeQL0x+UQ3owg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 09A80719E; Wed, 29 Jun 2022 09:37:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 25T9bYK3014951; Wed, 29 Jun 2022 09:37:34 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 25T9bYql014950; Wed, 29 Jun 2022 09:37:34 GMT (envelope-from git) Date: Wed, 29 Jun 2022 09:37:34 GMT Message-Id: <202206290937.25T9bYql014950@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 026502d9edd8 - main - UFS quotaoff: start write before unbusying List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 026502d9edd84c0e18110c4c35d03852a1146c8e Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1656495455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BU77yc2Jrn4A1gvg8nINNtWVO4OSVhWSeiR4pYn08ao=; b=H5UkDgndndPOdK/qloI34yoKMEaPZxxHn7cQY9pF9//wKrN3tcFHQz4n3yFvz/upR/zbKG imx4yDfBZ2aEniZoILuvuWxQGwHBni0v+7shf0ywKCXN0zimoc9Jd/rg0lJSSSK18s9F0m rq64hh1bxf88QIrgdeV6Yh5ArGXXmkgv8WPajtcx7hbrhXUJTzTsPNXEyrsoM8Jp1AkA1T jBFxfR9nImrSZ2fT08sUqmlREprUFNsW0/jmqKhckSvgtlgaEMT/VS6NL1WhzrH8Pl/0Wx G/OgHOvMS9eJV9rai09ECyBQuXsVMJIq23XRQJC12z/kSHaODe+u1IzMGJXCOA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1656495455; a=rsa-sha256; cv=none; b=aJT6kU6+NjUGu6FVaX7NA1zITocWM8gbMvfpBUU9doLTwiFWvl5Adp6gwhxs+ZaSI08WdC HmfXBW3FDWpxCJyCkFI8WLSUKuHLGqgf2wjkF7qZpF/kqKvgyxsc+1KmbTBU0ltU+ilYOl B4WJv2FnHW/mWck0thTcsaqXqEOb1qad8APK4b4SSxnSjE5kHerATksVWK7g9W4ZpakCt5 sWaTTd8L2wukWfnGyQvSMszi3smiVIm6D1Vsp7oCRTAexcUzCe650GUE8Iv1CtrEmR9kTd VqcPUxo6VLYNSaw2QGYBAw8CKsNaOYVe9Yrp6yh5TJ6ZA2PTmF4pV269XI8yXg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=026502d9edd84c0e18110c4c35d03852a1146c8e commit 026502d9edd84c0e18110c4c35d03852a1146c8e Author: Konstantin Belousov AuthorDate: 2022-06-27 17:16:29 +0000 Commit: Konstantin Belousov CommitDate: 2022-06-29 09:36:59 +0000 UFS quotaoff: start write before unbusying Otherwise the mount point could be unmounted meantime. Reported and tested by: pho Reviewed by: jah Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D35638 --- sys/ufs/ufs/ufs_vfsops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/ufs/ufs/ufs_vfsops.c b/sys/ufs/ufs/ufs_vfsops.c index 33ef7bc2c3d1..ef0ff43a56cc 100644 --- a/sys/ufs/ufs/ufs_vfsops.c +++ b/sys/ufs/ufs/ufs_vfsops.c @@ -129,9 +129,9 @@ ufs_quotactl(mp, cmds, id, arg, mp_busy) vfs_ref(mp); KASSERT(*mp_busy, ("%s called without busied mount", __func__)); + vn_start_write(NULL, &mp, V_WAIT | V_MNTREF); vfs_unbusy(mp); *mp_busy = false; - vn_start_write(NULL, &mp, V_WAIT | V_MNTREF); error = quotaoff(td, mp, type); vn_finished_write(mp); break;