git: ee847258e369 - stable/13 - linux(4): Eliminate bogus comment.
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 17 Jun 2022 19:37:10 UTC
The branch stable/13 has been updated by dchagin: URL: https://cgit.FreeBSD.org/src/commit/?id=ee847258e3691118ef00bbec0ff7c85471018b60 commit ee847258e3691118ef00bbec0ff7c85471018b60 Author: Dmitry Chagin <dchagin@FreeBSD.org> AuthorDate: 2021-07-20 11:39:56 +0000 Commit: Dmitry Chagin <dchagin@FreeBSD.org> CommitDate: 2022-06-17 19:33:12 +0000 linux(4): Eliminate bogus comment. For the caller is no need for access checking here, as the caller must take care of EFAULT handling. Moreover, this check would be superfluous, since EFAULT is extremily rare, and we prefer the fast path. MFC after: 2 weeks (cherry picked from commit 80b8d6b144c2f22dda252efe0d9fc70a1c8e15b7) --- sys/compat/linux/linux_futex.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/compat/linux/linux_futex.c b/sys/compat/linux/linux_futex.c index 2ee18c26cf24..f69b13585022 100644 --- a/sys/compat/linux/linux_futex.c +++ b/sys/compat/linux/linux_futex.c @@ -115,7 +115,6 @@ LIN_SDT_PROBE_DEFINE3(futex, futex_requeue, requeue, "uint32_t *", LIN_SDT_PROBE_DEFINE1(futex, futex_wait, sleep_error, "int"); LIN_SDT_PROBE_DEFINE4(futex, futex_atomic_op, decoded_op, "int", "int", "int", "int"); -LIN_SDT_PROBE_DEFINE0(futex, futex_atomic_op, missing_access_check); LIN_SDT_PROBE_DEFINE1(futex, futex_atomic_op, unimplemented_op, "int"); LIN_SDT_PROBE_DEFINE1(futex, futex_atomic_op, unimplemented_cmp, "int"); LIN_SDT_PROBE_DEFINE0(futex, linux_futex, unimplemented_clockswitch); @@ -591,9 +590,6 @@ futex_atomic_op(struct thread *td, int encoded_op, uint32_t *uaddr) LIN_SDT_PROBE4(futex, futex_atomic_op, decoded_op, op, cmp, oparg, cmparg); - /* XXX: Linux verifies access here and returns EFAULT */ - LIN_SDT_PROBE0(futex, futex_atomic_op, missing_access_check); - switch (op) { case FUTEX_OP_SET: ret = futex_xchgl(oparg, uaddr, &oldval);