From nobody Sun Jun 12 11:43:38 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 01E8583E9C4; Sun, 12 Jun 2022 11:43:47 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4LLXsF3Vw8z4s5H; Sun, 12 Jun 2022 11:43:45 +0000 (UTC) (envelope-from hps@selasky.org) Received: from [10.36.2.165] (unknown [178.232.223.95]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id D7AE32601E7; Sun, 12 Jun 2022 13:43:43 +0200 (CEST) Message-ID: Date: Sun, 12 Jun 2022 13:43:38 +0200 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: git: 9fd0d9b16e93 - main - ktls: Remove the KERN_TLS option from the i386 and amd64 LINT-NOIP kernel configurations. Content-Language: en-US To: "Bjoern A. Zeeb" Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202206111932.25BJW6w6040018@gitrepo.freebsd.org> From: Hans Petter Selasky In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4LLXsF3Vw8z4s5H X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 88.99.82.50 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-0.39 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; NEURAL_HAM_MEDIUM(-0.98)[-0.979]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.78)[0.777]; NEURAL_SPAM_LONG(0.11)[0.109]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:88.99.0.0/16, country:DE]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[178.232.223.95:received] X-ThisMailContainsUnwantedMimeParts: N On 6/11/22 22:04, Bjoern A. Zeeb wrote: > On Sat, 11 Jun 2022, Hans Petter Selasky wrote: > >> The branch main has been updated by hselasky: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=9fd0d9b16e93ff2a3bd375a98763dca0150dcee0 >> >> >> commit 9fd0d9b16e93ff2a3bd375a98763dca0150dcee0 >> Author:     Hans Petter Selasky >> AuthorDate: 2022-06-11 19:29:42 +0000 >> Commit:     Hans Petter Selasky >> CommitDate: 2022-06-11 19:31:28 +0000 >> >>    ktls: Remove the KERN_TLS option from the i386 and amd64 LINT-NOIP >> kernel configurations. >> >>    Kernel TLS depends on INET or INET6 being enabled. > > That is only a short-term solution hiding the actual problem and will > now propably never be fixed again like these device drivers which were > on that list ofr ages... +1 There is a plan to replace config at some point. I believe this is a limitation of sys/conf/files, that it doesn't provide a good way to handle conflicts. There are many ifdef KERN_TLS, so just skipping one file for building won't help. https://hackmd.io/w1Tf8mmVQVuZok7-LNEhgw --HPS > > >>    Reported by:    bz@ >>    MFC after:      1 week >>    Sponsored by:   NVIDIA Networking >> --- >> sys/amd64/conf/LINT-NOIP | 1 + >> sys/i386/conf/LINT-NOIP  | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/sys/amd64/conf/LINT-NOIP b/sys/amd64/conf/LINT-NOIP >> index e951a0878b29..0d4ec1e8c1ac 100644 >> --- a/sys/amd64/conf/LINT-NOIP >> +++ b/sys/amd64/conf/LINT-NOIP >> @@ -6,6 +6,7 @@ makeoptions MKMODULESENV+="WITHOUT_INET_SUPPORT=" >> makeoptions MKMODULESENV+="WITHOUT_INET6_SUPPORT=" >> nooptions INET >> nooptions INET6 >> +nooptions KERN_TLS >> nodevice age >> nodevice alc >> nodevice ale >> diff --git a/sys/i386/conf/LINT-NOIP b/sys/i386/conf/LINT-NOIP >> index 2f21766eb69e..1c91dae98baa 100644 >> --- a/sys/i386/conf/LINT-NOIP >> +++ b/sys/i386/conf/LINT-NOIP >> @@ -5,6 +5,7 @@ makeoptions MKMODULESENV+="WITHOUT_INET_SUPPORT=" >> makeoptions MKMODULESENV+="WITHOUT_INET6_SUPPORT=" >> nooptions INET >> nooptions INET6 >> +nooptions KERN_TLS >> nodevice age >> nodevice alc >> nodevice ale >> >