From nobody Fri Jun 03 05:45:34 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E97641B6F39D; Fri, 3 Jun 2022 05:45:36 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LDsL86FXSz4bSJ; Fri, 3 Jun 2022 05:45:36 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654235136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OVqYg8C9FHTQgV0ZgVQGPE0Ef4zEKSvJs1cs+5frN/g=; b=fTaqNR5IyAO6l7HNJVHVNRAjqGFBVLVyul2tx+WarvDNe0rixuXcsOcE8nMjDl3DA/oUHb Ir/oXYpr1zxlMfoBnYM3pUAPMUt2BPjL+/eoretcm9mIQuheotbQNLEsJtc2MO2BthhfBD /ootwkZ8ILgKlx/WpZmI0LFOL0gnSgvo6iBg4Y4HRI1Nm5cof0JYswmwU9IDltqbGBJuyI BtO78GVWjQJlP0yr51gA+f/4exPql2e3cPlx3AOb0qS3LjXX6hM8YuLJj8MgH7/f6/D/5J bwfbveyIkngBK8bCg8inP2eS881FUAezyfJtZzHAcloJ+ogJBkC8cTXv0hIfwg== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 9D0632DE0B; Fri, 3 Jun 2022 05:45:36 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id D409E44976; Fri, 3 Jun 2022 07:45:34 +0200 (CEST) From: Kristof Provost To: Kubilay Kocak Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: a37e0e6de652 - main - pf: fix more syncookie memory leaks Date: Fri, 03 Jun 2022 07:45:34 +0200 X-Mailer: MailMate (1.14r5852) Message-ID: <3C8AD404-31EC-49C6-B9D2-2F8888E22C7D@FreeBSD.org> In-Reply-To: References: <202206021818.252IIAdK087215@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654235136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OVqYg8C9FHTQgV0ZgVQGPE0Ef4zEKSvJs1cs+5frN/g=; b=CILcW9+EryfMOIbcmgCWDH6OO22OmaVBbJf46RI3ucAj/LoEp39ramltIQY0f4BCTQZ6i0 0KocLBeOWdILTrDoageEkZ+ku6Nh+XnbaYZJQ9Aih1ezGHWFgH2rVHcpzme6+gxRnvdYQ8 AI7eUAFxlYdG6wqPiMHuWVMYc90vD9qRW7Y+G8nu/F7aW0CaXynbAkSVlpMNGYZ3OCLUPj oyz44afy/JOZeVQJDsWzfgMniSzVhIblnZ8i9SGslKmhqUZS/UyIm2+FLobnr0u6ec2HO7 mlUz1k/F9SbMjnotHKO+r+yvW/vnIgyofrhncQPRG7GCG7wtv8fZhhGrcTVo1w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1654235136; a=rsa-sha256; cv=none; b=YgEDrQVPTa3IqNJo3uQpuSDFJgT7E3PVpcnnOhTP/Q/YUH1kXWFqK81EEVjA5m8MM/3/4p N332HnRQKdKmV8O5cfm4ztnBUT2slgoxxJdt9gFSXCzwaGC+mE748gPA7mrL4EKLVJKsK0 TKzEeh2DDzUMONv/VY5OhLTMPHHYy7tGH+FQ9hySAYCnM4nkrwsVI6ipAaTSPHpUq3VUIl Ms8SEr2rSQsZG+dkxS37VDZ5GcaIvxGKtjWMKf8v6bZ5J/N7IopmGKRK8HRxIG5E+/p47H iBvteSJArEAWQL05HOcQBEldjBpOmjmBy5WnZ+xm+vBMA4LipJTHrjlIwuK8eQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 3 Jun 2022, at 3:36, Kubilay Kocak wrote: > On 3/06/2022 4:18 am, Kristof Provost wrote: >> The branch main has been updated by kp: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3Da37e0e6de6527a7eaddea8e= 28f5e4b3427fba1a4 >> >> commit a37e0e6de6527a7eaddea8e28f5e4b3427fba1a4 >> Author: Franco Fichtner >> AuthorDate: 2022-06-02 16:27:43 +0000 >> Commit: Kristof Provost >> CommitDate: 2022-06-02 18:17:25 +0000 >> >> pf: fix more syncookie memory leaks >> Allocate memory for packed nvlists in M_NVLIST, as nvlist_pac= k() does >> this as well, and we use the same variable interchangable with th= e >> memory we allocate. When we free it we can end up freeing from th= e wrong >> zone, leaking memory. >> Reviewed by: kp >> Differential Revision: https://reviews.freebsd.org/D35385 > > Hi Kristof, > > Are stable{13,12} affected or only introduced in main? > They are. This should be MFC=E2=80=99d, but I forgot to tag it. It=E2=80=99= s already on my todo list though. Kristof