From nobody Fri Jul 29 18:48:16 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Lvc3P2wH5z4Y1r6; Fri, 29 Jul 2022 18:48:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lvc3N1prCz3s9k; Fri, 29 Jul 2022 18:48:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659120496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9xMBmj6ClXcrT3AUpoEOv2atOOXoWUh6CqlFaf2n59Y=; b=r5oSoNOrSrHSCFaKxgcy6JHjODhdcRxqBiRtpGiFTuKP1aPWYz56wA20tIxc0JbEgPqoO9 UgkIJvptxj6o3NNNhWsWHuRu6y5LGPpadZOBEr7uqei55BrJfZLy7hhgxc2Ld7Ah2AAYIO 2npkY12ipUPI/+R4G66Hm991eDsYgwEk8YiA1REuj0CR3ksItLD9ghNhINEqao9pvStUgm GuIRKHZgCHyi1WQIeIIf1+lv0qD/2BVxfp9+Q7P6knZiV3asFQpypxDn6MJcTY4gTZ2TKx eu2PaY4KfZ7MmXMkepjR2/+PasPD38C1MIo/T4XcvWg8DMvFPwqHl/WjZt0vWg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Lvc3N0tM5zlxt; Fri, 29 Jul 2022 18:48:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 26TImGsD025147; Fri, 29 Jul 2022 18:48:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 26TImGO6025146; Fri, 29 Jul 2022 18:48:16 GMT (envelope-from git) Date: Fri, 29 Jul 2022 18:48:16 GMT Message-Id: <202207291848.26TImGO6025146@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: c456a060ecc5 - stable/12 - Fix unused variable warning in if_pfsync.c List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: c456a060ecc56d1a51d8a60c265ae2ac39c8da4b Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659120496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9xMBmj6ClXcrT3AUpoEOv2atOOXoWUh6CqlFaf2n59Y=; b=hH5na3kKH1JBcSnAmn2y9Be+q+zoiE9Hexv0FlkiBw/RskIYou3FwHlamebWoCanvTZc0r 9/Rg1CT9SU0eWpIjDpu9WmHNel5lfX3t7S2LsPYVc+uwO7d5g5rqwE6/5pNMcOawHOzRe3 6UksugOgMbNwhmK7XjjJlfZSS+Et2F9An+FGdPdG13XsBWWDFQUq8+XVdgpf/yh2/h7D1d lcRZW6XC7ClQam0fmuHUA6cZ7is9d+ANBDOM/eMBIgTZtl2wN+2m60I7xx5vDDDgTcKUdj V5uuXVak5hTP+btHuYAsosfdjKPnvwSnczn0DLCDAjTq+0xtkgyW+k+N4C6lJg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1659120496; a=rsa-sha256; cv=none; b=exhR4qy6l7kT73Kf7t+l5P3CnvWEtQOpRFRCRam3RSjhr/NNsbyWXo1qaa1MJiS/A+7B/d Dco2om4EnlL5PVNX3C+BKR/tefe210KWxb/MiyQOVhLzxVvSZ3JwGHtmns0u/sKI+CC9G8 OMkTu3NvsqNYQekPuPksnYj1sr7KCtoSHWTNWVcVJMjsz5D6BvHsnLEppyW0fbCo4t3xMH VF8vX4eTrb8HeR+oFEC90pCd4/zSLHzUcpzcqRqhQ5XetLAIDWYvFC8kR5sNhzYGRNQbEO KVI0fHfdofEVpfsr3ajWZNX9kWm2KKCQpDUqDeuzV8yE1sREpoDuegCVyI4gSQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=c456a060ecc56d1a51d8a60c265ae2ac39c8da4b commit c456a060ecc56d1a51d8a60c265ae2ac39c8da4b Author: Dimitry Andric AuthorDate: 2022-07-25 18:15:51 +0000 Commit: Dimitry Andric CommitDate: 2022-07-29 18:35:36 +0000 Fix unused variable warning in if_pfsync.c With clang 15, the following -Werror warning is produced: sys/netpfil/pf/if_pfsync.c:2153:9: error: variable 'sent' set but not used [-Werror,-Wunused-but-set-variable] int i, sent = 0; ^ The 'sent' variable was used in the for loop later in the pfsync_bulk_update() function, but refactoring in 4fc65bcbe3fb7 got rid of it. Remove the variable since it no longer serves any purpose. MFC after: 3 days (cherry picked from commit fb48e998501f8d1defecffb772121a4141cdc2b6) --- sys/netpfil/pf/if_pfsync.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c index 470c2f176328..da1d17452cb0 100644 --- a/sys/netpfil/pf/if_pfsync.c +++ b/sys/netpfil/pf/if_pfsync.c @@ -2149,7 +2149,7 @@ pfsync_bulk_update(void *arg) { struct pfsync_softc *sc = arg; struct pf_kstate *s; - int i, sent = 0; + int i; PFSYNC_BLOCK_ASSERT(sc); CURVNET_SET(sc->sc_ifp->if_vnet); @@ -2190,7 +2190,6 @@ pfsync_bulk_update(void *arg) pfsync_bulk_update, sc); goto full; } - sent++; } } PF_HASHROW_UNLOCK(ih);