From nobody Fri Jul 29 18:47:09 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Lvc252kZGz4Y1NM; Fri, 29 Jul 2022 18:47:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lvc25290Jz3n1p; Fri, 29 Jul 2022 18:47:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659120429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/veouLYe5Xcu7s64dL5/kSDU64uNfyKmaC28FUbmnvw=; b=riyfiiPbuJQIGiLDxMx30b8AWwo/SsqET/zJ6anBRZjAWLkl1BGoc0xNXhpGQ9Hem+Sb4m ACX8UG7EcOeIIaQe8xdyZWYBY+IemON/5mBulRjjFaNfgP3KCKmRKqSAowM9+599ygCz2K HRmr4ED24p/eNsnyFpA0bqc3q9yxRHhzPy27U6Sje+OeFUunO1k2QE3CXLE9RSKA1rcMeW sq0LM66JbeYT6aT1yn+LL4yPJiBQOQ5gVLTi9lb6AXocLEpqkd9CtOnohOq7JngQG07Rkj Beyy1y9aDu0M2XAeh+kT96VI3TJ/FTCg5V6Udj/c2/8hSyFIr9OvfLNh5N953w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Lvc251Bllzm1Z; Fri, 29 Jul 2022 18:47:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 26TIl90d023716; Fri, 29 Jul 2022 18:47:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 26TIl9ie023715; Fri, 29 Jul 2022 18:47:09 GMT (envelope-from git) Date: Fri, 29 Jul 2022 18:47:09 GMT Message-Id: <202207291847.26TIl9ie023715@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: 96a32ccaa99c - stable/13 - Fix unused variable warning in if_pfsync.c List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 96a32ccaa99cededf33d488942683d93a69b006e Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659120429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/veouLYe5Xcu7s64dL5/kSDU64uNfyKmaC28FUbmnvw=; b=dS6r2l2SZJaxeqlu1LQjq8LxwbTxonal2LMsOACnfqMwSBseWGpGRY85u9LTt0Esigag16 1ia0CfBe5eMcQ38Zb7y3cjcgS1CcCy2uSLIFfqhFvgDLvZsqb6BLn88KUeV8wtaqiSIiWG xj8i318BKsSW59cqmK5ek19nhNkccPzk8GgcEdq5YljVyF2Z6MqeFSEgzBt+MYp9maPtaf 7B4Sq6jTyqti4AVT7q89NisCsDwpcmK+RixppjrNYb67H599H/WjoLfFuABH1kZv/lp0fk ovUqb8cagGayotXpatSMJG1qeWanbA2tKninHQ4JWuVr0tkiLAqSpSqt3XOLjA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1659120429; a=rsa-sha256; cv=none; b=ojRt2Rq79lzp8wkBI7JMUKR3M5DbBLjiPYSxmpB1Ym/mEsDzDv+aSTezD80sENuxw2jHuz N6u1bOG/oZZ9NmS/73FHy3BHb2wKb5NAKsPBcdW3rTR5s2KAuVB5WdxL87JrFmEU/PD4E5 jJnEARoO6TxHn2EehEIz7SMqtr6XY7WIr3A99i/7OnwrPc7Ji0hIAplsCoykdOwZZbJDh2 d6OZ6gOVrLK2o8cU89oJhuWgb7DdGBFwHyGhEsqsXKvGtwhuznXfy1MM6zbm9fDwV9XAqB Mn+WdmCvZqhC1qFHSGDpE36iTdWW2tH8L3cotYx/VwdpTKg8xxNpByorREhPtg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=96a32ccaa99cededf33d488942683d93a69b006e commit 96a32ccaa99cededf33d488942683d93a69b006e Author: Dimitry Andric AuthorDate: 2022-07-25 18:15:51 +0000 Commit: Dimitry Andric CommitDate: 2022-07-29 18:28:07 +0000 Fix unused variable warning in if_pfsync.c With clang 15, the following -Werror warning is produced: sys/netpfil/pf/if_pfsync.c:2153:9: error: variable 'sent' set but not used [-Werror,-Wunused-but-set-variable] int i, sent = 0; ^ The 'sent' variable was used in the for loop later in the pfsync_bulk_update() function, but refactoring in 4fc65bcbe3fb7 got rid of it. Remove the variable since it no longer serves any purpose. MFC after: 3 days (cherry picked from commit fb48e998501f8d1defecffb772121a4141cdc2b6) --- sys/netpfil/pf/if_pfsync.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c index 11ac0f6951bd..998f8a4f5521 100644 --- a/sys/netpfil/pf/if_pfsync.c +++ b/sys/netpfil/pf/if_pfsync.c @@ -2150,7 +2150,7 @@ pfsync_bulk_update(void *arg) { struct pfsync_softc *sc = arg; struct pf_kstate *s; - int i, sent = 0; + int i; PFSYNC_BLOCK_ASSERT(sc); CURVNET_SET(sc->sc_ifp->if_vnet); @@ -2191,7 +2191,6 @@ pfsync_bulk_update(void *arg) pfsync_bulk_update, sc); goto full; } - sent++; } } PF_HASHROW_UNLOCK(ih);