From nobody Mon Jul 25 19:51:09 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ls9dp02bTz4Wb2h; Mon, 25 Jul 2022 19:51:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ls9dn6jtmz3jwC; Mon, 25 Jul 2022 19:51:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658778669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lkNfxYhtbrfo8pImZaVazJluqefhYvDHa0ds5liDDYo=; b=GbG2V0lhlTwUUgGcMJSpRGirKlpuYNtJaDW3FSHNbxzNOcUtB6XiZyr3CFWtXWzNl3wNgl yCxG0I39+b2RM4NFu4BTq3v7DLJEXPa4OHk92H5xUQVamQQKUzKjl2lPjco5+7e6Ila7D9 GxVOkCECHkGBSsBeW0yyqdViGOne94SNEkQdbrEwC1HDHm0kPTUMMnG5o5y1P3IjIFtzHc zw3nyZhrEhblajS7AAwwf+bKiEW7lO4/I0Qk7MO8cipWeiAuvkeTa3wdyw5bJcQAe/IxSJ mtyIkZS0rbvwxL9o75WSEEhbW7bmKJ6gwNX2SC8aCMYsXR1kbwHZM5oZq61sog== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ls9dn5XxNz18Rl; Mon, 25 Jul 2022 19:51:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 26PJp9td003333; Mon, 25 Jul 2022 19:51:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 26PJp96X003332; Mon, 25 Jul 2022 19:51:09 GMT (envelope-from git) Date: Mon, 25 Jul 2022 19:51:09 GMT Message-Id: <202207251951.26PJp96X003332@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dimitry Andric Subject: git: 766f3c8032a9 - main - Adjust function definitions in if_pfsync.c to avoid clang 15 warnings List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 766f3c8032a95f344823bea70bb7f794f9939d33 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658778669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lkNfxYhtbrfo8pImZaVazJluqefhYvDHa0ds5liDDYo=; b=PKSEA7GwGaVDJwuEIB0GVQLiPeYicp9d5JooDtmvMHh7ANyOP3qVpRFuty/BCt2HAZ9OKj 4P/LPBjuNL+LMXQvOMKwoKWYpZNCybfLC6VdLMGMr77OlKr/gGYbWf2/+KhdeNZ2hBObyE CCxeT+pJkaIf5lgko7ymIQanJ5PovQag/KuiAiSsO0uzAilx2H1NVtUkjLXCnxMBesNgvf 8zZlVCIyZe/k8ddgeqcePoyvn56Vdp4dnoodp8yo2oZILoCfeE47jHtO+XjvJQZr/CFLxU wTgOOVc9vHeHX0tJWW0raazb2ZD7YzowQhs966popxHKVCNns5/NYkvXrGhQkw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1658778669; a=rsa-sha256; cv=none; b=OOcjWskJ1yMj9Emad9UcTP3QAVK0VUOiK2qMF9HQqfyq1se2/iQ21OWawscGIs7PdzgFuD MEUpYC5CXCCbzqrc7D3ocqTwyvzk3PMyJnlIHXHnZg+YM8wCrP6+jouPS74pD2b4Vxdi3+ 5qEXYh4/C8WbUUOHbdEvDSBf1Ucd01kjftScRD5WIeHMogTa36zaWaYHjjLhoxqY30FSIb rIonsbDK3x+0P60vykUQYmmTBtAGYfr2NqxgbdxJTqGYEKyAOcpXDpKzdMINwfPQIWWtmy 8NtNGlhVIdWGER4JWR2oMX+BGwTskle5inLc9VdRRzOpRgG/oNUPtnUX8/1sGA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=766f3c8032a95f344823bea70bb7f794f9939d33 commit 766f3c8032a95f344823bea70bb7f794f9939d33 Author: Dimitry Andric AuthorDate: 2022-07-25 18:53:32 +0000 Commit: Dimitry Andric CommitDate: 2022-07-25 18:53:53 +0000 Adjust function definitions in if_pfsync.c to avoid clang 15 warnings With clang 15, the following -Werror warnings are produced: sys/netpfil/pf/if_pfsync.c:2439:21: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] pfsync_pointers_init() ^ void sys/netpfil/pf/if_pfsync.c:2453:23: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] pfsync_pointers_uninit() ^ void sys/netpfil/pf/if_pfsync.c:2503:12: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] pfsync_init() ^ void sys/netpfil/pf/if_pfsync.c:2524:14: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] pfsync_uninit() ^ void This is because pfsync_pointers_init(), pfsync_pointers_uninit(), pfsync_init(), and pfsync_uninit() are declared with (void) argument lists, but defined with empty argument lists. Make the definitions match the declarations. MFC after: 3 days --- sys/netpfil/pf/if_pfsync.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c index 5f082576a3f9..180bf4440455 100644 --- a/sys/netpfil/pf/if_pfsync.c +++ b/sys/netpfil/pf/if_pfsync.c @@ -2436,7 +2436,7 @@ static struct protosw in_pfsync_protosw = { #endif static void -pfsync_pointers_init() +pfsync_pointers_init(void) { PF_RULES_WLOCK(); @@ -2450,7 +2450,7 @@ pfsync_pointers_init() } static void -pfsync_pointers_uninit() +pfsync_pointers_uninit(void) { PF_RULES_WLOCK(); @@ -2500,7 +2500,7 @@ VNET_SYSUNINIT(vnet_pfsync_uninit, SI_SUB_PROTO_FIREWALL, SI_ORDER_FOURTH, vnet_pfsync_uninit, NULL); static int -pfsync_init() +pfsync_init(void) { #ifdef INET int error; @@ -2521,7 +2521,7 @@ pfsync_init() } static void -pfsync_uninit() +pfsync_uninit(void) { pfsync_detach_ifnet_ptr = NULL;