From nobody Sun Jul 24 11:01:55 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LrKxb2jwdz4XXKD; Sun, 24 Jul 2022 11:01:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LrKxb1zH1z3bQr; Sun, 24 Jul 2022 11:01:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658660515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bz3T/3cpBk1Wzdoizke6ak7a1wVDUD2mALh8TAolB4U=; b=Kizd/lhccBim2bqxYBgyLxkD64Qjuw5Uc7Kqwxaue0OehUx/PzJ3zOlbBHyyrVywzEuryU nPMxh9s7Wb92pTnIjmhsqw6161/iSzo44LxaXTt6rU1ppkcmqVP3pSjgMxOGpOblsiuqGx Z5Y4G/sE1cUJB7n8yitc6hk/JuST1Df2PxNGsYUcBkrtxx3WSdoyGGvVtniZxvzRsweQv5 XskCWJqtIUPjVZYRKaifkUEfDRNyEBHiRTRW1Tbl5Eiz/wWrahtvcfmrs/XLcKRfuS2Zbg bwmfkACdgOj97X7Ut/BSSdWw4rFaT1Mp7rq9C0Z5dAePSRm4RPaMNTzWUfuW3g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4LrKxb0sBdzGYv; Sun, 24 Jul 2022 11:01:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 26OB1tiO040926; Sun, 24 Jul 2022 11:01:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 26OB1thp040925; Sun, 24 Jul 2022 11:01:55 GMT (envelope-from git) Date: Sun, 24 Jul 2022 11:01:55 GMT Message-Id: <202207241101.26OB1thp040925@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: 38fb2140abc2 - stable/13 - Adjust ipfw_iface_{init,destroy}() definitions to avoid clang 15 warning List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 38fb2140abc2601064d32a8df23ff7c2c2acbbe2 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658660515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bz3T/3cpBk1Wzdoizke6ak7a1wVDUD2mALh8TAolB4U=; b=UWJPnAdDhubeVhzIaoPaZbhHwB1QV+BbkT5HmD2zUDzodnsdYU86VO8SMeFcku1qrQnB1R qafDjHoH0w/nTQkIP6UWPfhpMGmmwj9I+9mPS3oTazV7WvYNBQ8ckkCeV0rXe+Stzy36Ds RD6qGpop61skVQgH6tLO8gMyCXXyANOIdH6viKQe7J6exQxv+fMOP837tHd+p9R+stBOMU NBuFvZ4G0mjxBESqY/101mVYytPgWZBEFQHDIdkjDwRTStwBpdPW/CwBxGwkgIGqFqY6kU 1bLyMkcp8TfiZe9fwQzd2zaeQhu0oPMMUzEvo9/4V6/UUCCmW6IEcHCPRqXWYA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1658660515; a=rsa-sha256; cv=none; b=RccyRrDUe8ar/fE9cFUnRimY85IVjNRUiEee2V5xKwzsX81yQ0G3NSiYN7HXu+LZ41PaWu Shk8OPERZpdqSXHcaOqf0gryb3l0f9abC/VPooMXW83YKf5HyTZkGZHT4Z7gnSW8MAM8Ka W8sUhgQCw4g1Nk0DRdbahTCafGip5NCkY93st/CvRcM7xNDLaleUuHO3X5vsHZdqE9kQvG L2GfEGS3IZbzBeD1H6SiRq2pLCF/PqirpkXldkUk2cx6ku6v2fKS/YL2RkmBDFZLHU60Zy iw8H1Yp8WGlMrCwJHqOV3ieVbEo8lw7Qcu7yME+AD8P0rxUhCm4ozhiL2cljuA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=38fb2140abc2601064d32a8df23ff7c2c2acbbe2 commit 38fb2140abc2601064d32a8df23ff7c2c2acbbe2 Author: Dimitry Andric AuthorDate: 2022-07-21 19:37:09 +0000 Commit: Dimitry Andric CommitDate: 2022-07-24 11:00:09 +0000 Adjust ipfw_iface_{init,destroy}() definitions to avoid clang 15 warning With clang 15, the following -Werror warnings are produced: sys/netpfil/ipfw/ip_fw_iface.c:206:16: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] ipfw_iface_init() ^ void sys/netpfil/ipfw/ip_fw_iface.c:219:19: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] ipfw_iface_destroy() ^ void This is because ipfw_iface_init() and ipfw_iface_destroy() are declared with (void) argument lists, but defined with empty argument lists. Make the definitions match the declarations. MFC after: 3 days (cherry picked from commit 1eea6b9097834484f2238298f550bb418901c313) --- sys/netpfil/ipfw/ip_fw_iface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/netpfil/ipfw/ip_fw_iface.c b/sys/netpfil/ipfw/ip_fw_iface.c index 30a943bd8761..4abcc766f6ca 100644 --- a/sys/netpfil/ipfw/ip_fw_iface.c +++ b/sys/netpfil/ipfw/ip_fw_iface.c @@ -203,7 +203,7 @@ ipfw_kiflookup(char *name) * mutex init. */ int -ipfw_iface_init() +ipfw_iface_init(void) { mtx_init(&vnet_mtx, "IPFW ifhandler mtx", NULL, MTX_DEF); @@ -216,7 +216,7 @@ ipfw_iface_init() * Unregister khandlers iff init has been done. */ void -ipfw_iface_destroy() +ipfw_iface_destroy(void) { IPFW_DEL_SOPT_HANDLER(1, scodes);