From nobody Wed Jul 20 19:23:18 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Lp5GC2prtz4Wlpl; Wed, 20 Jul 2022 19:23:31 +0000 (UTC) (envelope-from garyj@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lp5GC0dRgz3RMd; Wed, 20 Jul 2022 19:23:31 +0000 (UTC) (envelope-from garyj@gmx.de) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1658344999; bh=7df1bc1S8gMAT3/a4YTv+3i280ubc9UH95ny4UN+k4s=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References: Reply-To; b=gFRTUz1jUaGf6FfyhQc2lObr2y40A1LqMGeO5HvHvlbGCqpli4+w4cl409ZiJi+m3 /9Vi82jSKaGNtd2I0cjIlHpeooQkvCpHow03eMENHV+OdITDvnL+1dCofqs6M4TLyt Vin6/Th3nsnW4E3JjMZnPj/JGi/X/1IkDWS6EmOA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from ernst.home ([91.2.60.68]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MacSe-1ndXh71keg-00c9sT; Wed, 20 Jul 2022 21:23:19 +0200 Date: Wed, 20 Jul 2022 21:23:18 +0200 From: Gary Jennejohn To: Warner Losh Cc: Toomas Soome , Dmitry Chagin , src-committers , "" , dev-commits-src-main@freebsd.org Subject: Re: git: 84bf2bbbecc3 - main - stand: constrain zlib/gzip CFLAGS better Message-ID: <20220720212318.2b27beaa@ernst.home> In-Reply-To: References: <202207081750.268Ho5kZ066824@gitrepo.freebsd.org> <244CD526-C7D0-4D42-9DAB-6EA690DFD3A7@me.com> Reply-To: garyj@gmx.de X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:tz1JeKOaxZSulWXBU4XXAbWYRFCohhmb70uVLCkxg+4i/dEEhEt 1KMZkKpcTiY1pgzI/zNE9yGcWUuEIKYvxDkNSqyEyzeidT5L4437WQKIZIfPab2nFNZelrI TnNcNROUdCvZRlxCQAog2ekmlAOL869vPMPZWypZrz7rTQLHtDvhGL9pPXi6hPNRf5bjRAc 9pt1xao8eYfmourRRopmQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:1g2bHpI0fOM=:wjM5VbULl9t8pVH2ujxKp/ p9BuJvb+yG8eBQQBSqLcUjVNnde78jIA2UEMM5yAHRMq8IPuXFMutsFwPDnu5Ulyp5vZ+fL72 bKWzPJ50QJKWhLDYuTOekKbGhVO56It6hgmql6gj+W1WcRlWT0w76p0KmkrRBuhksB/qe4Jt7 V6b+Nk2R4OrTdVKRRoOsaftiJV4MI9QVzfGpFt1w7TD/bFNlIr6WnHuc+/a1u5Kh6wouSel8Z R7PP9u2oOsM4vknFJ9QLhlzkAxGsuGH3DvL4ST6LsXu2vMqFJlgLTFt2tMqxTLO1m10WQkUdx pyUZOHDogGMTYXb+4I15PwfQOACj1zyHM6hj4pd2udl+O6z9XvE7B8pSAofG1lCISZ+4Abwhr jwc42QvqkiX0IDbSkDg1lk6+8beCcFL024tV1o+LCfYrTSIhlRrcavKAeDYdofQ2Q9x7rjrx2 P+mJluSohPx1i6SlhJoG5qwRmkvKotYMPlSnZST4NlhFRR88fGpC021htOzkubmJnlG4Enskr slhh706SafW1lIq+V1aS59IVFjErllF07RCeYz4oMnlFCA2ML9tZVm96c9Ap379XQe4GoMgnS WIsecR5mAZtDCdQjEG2nGF7ujXmkEf3fNwaVX++aCdtbhA6RWgMh1I8YN7E2Nt8dBi5HQ+zCr +H0Qs73wX675JT3OC0xEML01WW4FeCiiUHy8dyaVg6cpsjvAG+D1aZQV9yaEqVyr16Sp0ky0g /zaZTYnCB0CV2TpwTHgmYosIQCS1/gmxqQFJ6bPoujfQIF2s1QJvTE6Ilg0rFMj/iJKYL1Cr/ +c03Nj0Vmdy/pLoFJ7A0dgcMkdtjWQSN+11slURq4TCTjFdtvq0+xoS89BL9e4LnSPpgJO61W jJd5OKK8ezi5JdeTDxD/RIZ2NDsZ2TMJzQGiJ+01q47rUStuJaeJy7C8jau2BAULFK3VORn5L p/fcWOckvR4+zL8qMqr6pN0fEIiu8ymezwihmnUyPtrz19ul8sKy6x52Pt/8lodT0XQYHGOHh g+nIzlo9iZYdfRZQdGxIlK2aOrTr7ACLrB+7igcfCtYRY1X/1bTwBsfi8I0Uh+DNqBFfOTJGy zJ44IucDDXbq2u7K1AjUymcVCpiF0hkxDXV X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4Lp5GC0dRgz3RMd X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Wed, 20 Jul 2022 12:12:57 -0600 Warner Losh wrote: > On Wed, Jul 20, 2022 at 12:06 PM Warner Losh wrote: > > >> >> +CFLAGS.${i}+=3D${ZLIB_CFLAGS} > >> >> +SRCS+=3D ${i} > >> >> +.endfor > >> >> > >> >> # lz4 decompression functionality > >> >> .PATH: ${SRCTOP}/sys/cddl/contrib/opensolaris/common/lz4 > >> >> @@ -168,9 +170,8 @@ SRCS+=3D time.c > >> >> .PATH: ${SRCTOP}/sys/ufs/ffs > >> >> SRCS+=3Dffs_subr.c ffs_tables.c > >> >> > >> >> -CFLAGS.dosfs.c+=3D -I${LDRSRC} > >> >> -CFLAGS.tftp.c+=3D -I${LDRSRC} > >> >> -CFLAGS.ufs.c+=3D -I${LDRSRC} > >> > ^^^^^^^^^^^^ is this correct? at least it breaks builds with > >> > WITHOUT_LOADER_ZFS and WITHOUT_BOOT probably, see PR/260083 > >> > > >> > > >> > >> No, it is not correct. > >> > > > > My change is correct, theoretically. However, there's a layering viola= tion > > that means they are needed so it was premature. > > > > I'll fix a bandaide and do it better when I return from vacation. > > > > Doh! I don't have the right keys loaded in my ssh-agent, so I can't push > the change because the port forwarding on my router is broken and I can'= t > remotely login :( > > If someone could commit the change I suggested in > https://reviews.freebsd.org/D35860 that would be great! > Well, I can say that Warner's recommended change fixes building libsa for me. Couldn't build libsa earlier today without makeing some hackey changes to dosfs.c, tftp.c and ufs.c. =2D- Gary Jennejohn