From nobody Tue Jul 19 18:02:59 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LnRWm14c6z4Wgmw; Tue, 19 Jul 2022 18:03:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LnRWm0KWyz456g; Tue, 19 Jul 2022 18:03:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658253780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/dHQPNJ8oHPfxLikE4AVWwGzC8Sk10runy+ZPDXYjEM=; b=KjjXMpHN9x6yqVTPqPXQrNeVrN9yXRfMEDzqfLQ75MxlyE9Fq+jGsfSk/alRSJEGbmXZ2E mH/GZBugf7j9/BUHsUBjIdwv9kcuvapBCikPpuKS7bW/inFxp+AkW2uDyCaJi7cHYRTuPP WN+udL9ODPYsTMfOGx+eytJcESWNocH7UZoEszh2QpQ8arNST/HZ0dlxPebjcwPBL2SxF4 IYpIFc54ht48ghm1Jr1N+1ZlTJ2+WqsVlPwYFgS4XEnLrVOLIVeHEcYQ1rhH5+sQuIsj30 OeXy6Ropsy7c+N5SaSy7xWCBEFKa3lJBVRjGh2utZcw+YQtEkirCc3NTH3ZDmw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4LnRWl6F7qzSbx; Tue, 19 Jul 2022 18:02:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 26JI2xB8077935; Tue, 19 Jul 2022 18:02:59 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 26JI2xrM077934; Tue, 19 Jul 2022 18:02:59 GMT (envelope-from git) Date: Tue, 19 Jul 2022 18:02:59 GMT Message-Id: <202207191802.26JI2xrM077934@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: 0fe451036dad - stable/12 - Remove unused but set variable in cxgb_sge List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: 0fe451036dadbdffb980f6667e281429a6b22e4e Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658253780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/dHQPNJ8oHPfxLikE4AVWwGzC8Sk10runy+ZPDXYjEM=; b=shuuTPb3/EHjgBQCZAR2Y4gsv7pCOL53Nd4vF4V4duiShyDywbO4Z91Nl5lnJIO3zK8y6k OSdF2V077ohVCLyeu4QtugkEVvMgmWosI8ABNN+CYP/zCpXQWv1b2nR1GtTUmWotDY0YAC DJy+VfjFEQd/S5cPwdO0DvbHsFdOIM+ZTvteo0JcAscL+mLJK6s3kRBVwwsx6JU6Ixtnzs s99T582X/onPPPQgqIJdPZj1KUbArknvRtDVhBJ4UeDK78n2YRT6sC/0lDEAlE5983q55I bTAeMXyHfC4tWH4bpyCDWFov8fZE1lFHVL+MlABraKdNxDZ2l87adQtl5UA2Qw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1658253780; a=rsa-sha256; cv=none; b=N/gxwsoyHIV5cvfQroePUXmJBEFcZA6VP2lOV3u2Wl48NBz1rXsgiI++8RkDNrRAVMZfOk /zpWM44z9JnPRQkYFPuFtt0L34oS/D62Y94zQho/vlcQcI0Ppl4g5R9nBcTaN+bLsofwbo sXcyoY1+5JrlOkgZuqyMP37qMb6WD4Lw2Qg3x8yfjfKWv6TadqyPDvB6k6kwEkRQJP7Vru Ntx6xLZfd6gddp1c/bgF7Nx5N+IkVDR6NBAWJ3m+LFEVzqNSfaBnryhhfdt80YPvjJpSCO NwZKpfqa0rJTHTduUJw9cx2V5sQPH6JOJeUpDLLaKKqcHSzCZGJXMZhchdpffw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=0fe451036dadbdffb980f6667e281429a6b22e4e commit 0fe451036dadbdffb980f6667e281429a6b22e4e Author: Dimitry Andric AuthorDate: 2022-07-16 18:16:36 +0000 Commit: Dimitry Andric CommitDate: 2022-07-19 18:01:54 +0000 Remove unused but set variable in cxgb_sge Clang 15 warns: sys/dev/cxgb/cxgb_sge.c:1290:21: error: variable 'txsd' set but not used [-Werror,-Wunused-but-set-variable] struct tx_sw_desc *txsd = &txq->sdesc[txqs->pidx]; ^ It appears 'txsd' is a leftover from a previous refactoring (see 3f345a5d09b6), but is no longer used for anything, and can be removed without any functional change. MFC after: 3 days Reviewed by: np Differential Revision: https://reviews.freebsd.org/D35833 (cherry picked from commit cab040039d6fe1b2a6de8f2ba2cc882c313d3c75) --- sys/dev/cxgb/cxgb_sge.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/dev/cxgb/cxgb_sge.c b/sys/dev/cxgb/cxgb_sge.c index 5c5d1f902f30..7a6bd2a48ec0 100644 --- a/sys/dev/cxgb/cxgb_sge.c +++ b/sys/dev/cxgb/cxgb_sge.c @@ -1292,7 +1292,6 @@ write_wr_hdr_sgl(unsigned int ndesc, struct tx_desc *txd, struct txq_state *txqs { struct work_request_hdr *wrp = (struct work_request_hdr *)txd; - struct tx_sw_desc *txsd = &txq->sdesc[txqs->pidx]; if (__predict_true(ndesc == 1)) { set_wr_hdr(wrp, htonl(F_WR_SOP | F_WR_EOP | V_WR_DATATYPE(1) | @@ -1323,12 +1322,10 @@ write_wr_hdr_sgl(unsigned int ndesc, struct tx_desc *txd, struct txq_state *txqs fp += avail; txd++; - txsd++; if (++txqs->pidx == txq->size) { txqs->pidx = 0; txqs->gen ^= 1; txd = txq->desc; - txsd = txq->sdesc; } /*