From nobody Tue Jul 19 18:02:28 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LnRW858pWz4WgWK; Tue, 19 Jul 2022 18:02:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LnRW83kKXz43mb; Tue, 19 Jul 2022 18:02:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658253748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=whzpRLKdIamp9F18Mh6EIU24H1ouIZNHprmnwrGCKbA=; b=bIF1Zfr2iWBP3fNPpCkr0F52oLJBrJZ5p3yD0Hn7Ku5C1jBSjHQByBUPrIKmF5QJCNW6ui j2UdE1nlNbIEFrVDsnWUYomLScXve4vcp0+1rrU8PNYNDMVuZBtegBXlbeMx8dhEbKP2Qs L/WOv2VBJZDX37MWvboSV7ZlwjBPxr6PR6F4+nhWz8nQp6wbtiB6N8dboksVskZQ3XxJUz 3uNg/qd0Bogck3WjFrs5y6wg9Xqb0Y+pieRXYmO7AO24D0/jkkOq6OejgY5YcyIuDLOW6x d+tCzz3cj25xiYzTsEyqx5mJ6A8itWCacmZcF2es4/eSr9piXXI6erdXCUYdjA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4LnRW82d96zSbv; Tue, 19 Jul 2022 18:02:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 26JI2Sp9077657; Tue, 19 Jul 2022 18:02:28 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 26JI2S6G077656; Tue, 19 Jul 2022 18:02:28 GMT (envelope-from git) Date: Tue, 19 Jul 2022 18:02:28 GMT Message-Id: <202207191802.26JI2S6G077656@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: dae26c1153cb - stable/13 - Remove unused but set variable in cxgb_sge List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: dae26c1153cb1ac1bac4c333d9fb9b91584dace2 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658253748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=whzpRLKdIamp9F18Mh6EIU24H1ouIZNHprmnwrGCKbA=; b=Qi7nMydHI75F0PH7DY27J8GAJygXqSV1jLLQr0VJfqKjm+b/xXS3S5iOVaE0Y+5lUClKzv 4yKNuoD/R/b/apMIYVob9x4ggNje/uXz01bPbNJOFdEo38pBsMmT21TqwSSGb8VuismiKm Co1XBHC1dOhEraWwcym1/Dc5POh+nTL+mrNB+up5Rrzi5dZIZgfOnUqYyIF1wLEuxazswl z7ohCTGBX3RzIGGX/ztiWrL98blciI8QhFFxiSdhKZ+JhfyP6rtByjsMYrrULzbWFCCNhv Rbo1elHZ4rzimu+dGY+BmGWDauAEyW98oP7MHRUwFO4AH72VlWzEK5OxCV1+Ww== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1658253748; a=rsa-sha256; cv=none; b=N73Y/Rjqu6u8CiGGnlV3A0hCpb0Me91SueXqbgfSQsZslv8fHVgookX/ulB1aR4URGi2g6 65n1Wo6KQCC2j+pG65r5kNrI1h2jWpd92rruGFnZucZd1kdRr1tCEzL7cexCKWaDcz9y7C 6gHmK/aUDUde9zGKxsS99zbSBMQWkqnQTJRElag5D8oINSoRIwD2MMhh4DreETyOk13qHe 1D3BPV7luhWyDqKN6T9ZXmmLU7ZOWnHmumiqIEWgAvm24Df+1CKEFGVIYrbzdq26hHAgqw PJA4ZJyRt5e1POCAMB17Iya4cgPdJsL1W2oMHiE2xpVIMtnnSlIZ/MtoTzjbJg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=dae26c1153cb1ac1bac4c333d9fb9b91584dace2 commit dae26c1153cb1ac1bac4c333d9fb9b91584dace2 Author: Dimitry Andric AuthorDate: 2022-07-16 18:16:36 +0000 Commit: Dimitry Andric CommitDate: 2022-07-19 18:01:49 +0000 Remove unused but set variable in cxgb_sge Clang 15 warns: sys/dev/cxgb/cxgb_sge.c:1290:21: error: variable 'txsd' set but not used [-Werror,-Wunused-but-set-variable] struct tx_sw_desc *txsd = &txq->sdesc[txqs->pidx]; ^ It appears 'txsd' is a leftover from a previous refactoring (see 3f345a5d09b6), but is no longer used for anything, and can be removed without any functional change. MFC after: 3 days Reviewed by: np Differential Revision: https://reviews.freebsd.org/D35833 (cherry picked from commit cab040039d6fe1b2a6de8f2ba2cc882c313d3c75) --- sys/dev/cxgb/cxgb_sge.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/dev/cxgb/cxgb_sge.c b/sys/dev/cxgb/cxgb_sge.c index 1c4099604a77..bf3a5528a61e 100644 --- a/sys/dev/cxgb/cxgb_sge.c +++ b/sys/dev/cxgb/cxgb_sge.c @@ -1287,7 +1287,6 @@ write_wr_hdr_sgl(unsigned int ndesc, struct tx_desc *txd, struct txq_state *txqs { struct work_request_hdr *wrp = (struct work_request_hdr *)txd; - struct tx_sw_desc *txsd = &txq->sdesc[txqs->pidx]; if (__predict_true(ndesc == 1)) { set_wr_hdr(wrp, htonl(F_WR_SOP | F_WR_EOP | V_WR_DATATYPE(1) | @@ -1318,12 +1317,10 @@ write_wr_hdr_sgl(unsigned int ndesc, struct tx_desc *txd, struct txq_state *txqs fp += avail; txd++; - txsd++; if (++txqs->pidx == txq->size) { txqs->pidx = 0; txqs->gen ^= 1; txd = txq->desc; - txsd = txq->sdesc; } /*