From nobody Fri Jul 15 17:50:54 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LkzRh66zRz4TFCW; Fri, 15 Jul 2022 17:50:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LkzRh5gGLz3PgP; Fri, 15 Jul 2022 17:50:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1657907456; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ppq+aZncTMLaSjcnHQCf+D2a6pi8+rtbF5T3J7SDPms=; b=EH6/1SsxUcL2LYEvNJT7wyKex8LXRVnsQNcHjVsOwTxiexHxUXGYAvbqQjehmTJ9yAx7QR WZnwPWr3JSwA2sn/7XbAgV9PMRdJgJ2Rgf0yi5ce74VKHssRC07Gc0SHpdM6BbPuKkYRdw Rds9mEu1I+NCVgSXLqhnr+mnhiG0soJu8YAemntltpu7IAab2oZHCvp05Zst3sYPKtKPih iWrau37KYTIay4XHeMJjyOHNiMhi1poZng7NMMhWnwJUJnmV9CeMMYC/KdtJPuXNld8UWw fv50I6Iz6bRItnWcK8j58/q4FrYotYwPQJyNq9/YaOOJVt+494ImPRq0L6DtAw== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4LkzRh1KnVz14d1; Fri, 15 Jul 2022 17:50:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Fri, 15 Jul 2022 10:50:54 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: git: 66605ff791b1 - main - tcp: Undo the increase in sequence number by 1 due to the FIN flag in case of a transient error. Content-Language: en-US To: Richard Scheffenegger , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202207151636.26FGaHsM038397@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202207151636.26FGaHsM038397@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1657907456; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ppq+aZncTMLaSjcnHQCf+D2a6pi8+rtbF5T3J7SDPms=; b=xHt9mBrPcUpre55SVxYpGN4ArhyPTxD/x3PFZbebNC9OZHdUfiORf6CrW6J7O6YLYe8at4 5CPyIA7jDQ6xsi0+B3kzu/a9muC35sHdwVBB9u4YL/laoSp9Jy/zJCNqYFeViEMFptsSUv ptLOj51r1/Oo0bVuRRl2tzTt1hDFBgQ4N7DeWlZMcmhnZBhy4okKE3NOgsQaAA3pRK69R6 EFWiXYkyAL4yyzbMpcMLc/fvUyLisqmyw837QzCGxiXJ0UkqwezNBN5qs+sWNp6hZRxtWy oOgmsls5l77MZKqBiDJV7v2b8NaPeMHNRORPY6POAObVCMwKplXVnvwjo3KUeg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1657907456; a=rsa-sha256; cv=none; b=eW5eMv1+enpy0eUnUgp0q7Ync0g7VQ+SSR7JkXGdr+gzfJAz9MaqoRr6KAHha5Jlw50abx hn0O1qOFbJLpQBy05DMSCTl+vyZt9gZFomskXFF4k1XexA8rXfXbO83AA9EiWJzoOH5rXe 3rewtsomZu1yoVVdZeBagauxDDGswi7JbcSL4hNvlZNtPnV0y+1S1kXRTuMcFwlcMlMFN9 dCC+OJOTToIY08W4aF+RHONw+cxY8Pfl3IR2idU7VEDZxlEtXbHMiGCO+pYBD7sBkDt4mY F7JjrEH6a3DAUpWY72U86X3EXtiZ/5gz+WBQzO6LSpeeqP0wUPjlH0IPXu8Gdg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 7/15/22 9:36 AM, Richard Scheffenegger wrote: > The branch main has been updated by rscheff: > > URL: https://cgit.FreeBSD.org/src/commit/?id=66605ff791b12a2c3bb4570379db0e14d29fca4c > > commit 66605ff791b12a2c3bb4570379db0e14d29fca4c > Author: Richard Scheffenegger > AuthorDate: 2022-07-14 00:49:10 +0000 > Commit: Richard Scheffenegger > CommitDate: 2022-07-14 01:18:19 +0000 > > tcp: Undo the increase in sequence number by 1 due to the FIN flag in case of a transient error. > > If an error occurs while processing a TCP segment with some data and the FIN > flag, the back out of the sequence number advance does not take into account the > increase by 1 due to the FIN flag. > > Reviewed By: jch, gnn, #transport, tuexen > Sponsored by: NetApp, Inc. > Differential Revision: https://reviews.freebsd.org/D2970 Is this the source of bug 264257? -- John Baldwin