From nobody Thu Jul 14 19:50:19 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LkQ7y3m0Jz4T1cj; Thu, 14 Jul 2022 19:50:22 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LkQ7x4Cdxz3Q0K; Thu, 14 Jul 2022 19:50:21 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-lj1-x235.google.com with SMTP id m9so725181ljp.9; Thu, 14 Jul 2022 12:50:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7z2e/K9+ysmhqGZ2WFAMZuy1Myt2A2RRlVFCS4742CQ=; b=Lz+HZ3bTAtnNRhy1dHlWtPuODrXWU/cKduFRkr0a/DQjDIDhbv3JxefcxE9ycy/LTX wqX+xe7QeuqCwFHCBUxRo/LKPR4QRC6awaK4FFBrKm73E27hbrdju/m8Qb6bu9+Ypm/Q 5XKuQxp8HlRKGY2zzq7dd+iTVioFL8f6fsEGtP/cWEEZW56Rp/dH8LJtCDzEGkCT3tbh e7RhenUljcvVRcymIpJEb+EorCQGjwVjcV9WxiNsBSl6dNVoSY5IaO3+FpsNUqHzVY5Z 7vcS3PYClFQAqmsY5zJmdLhQ3a3pmfy8z+XZNeH0hzwdVpP20NYUebj57KwtKd1DhAXh c7KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7z2e/K9+ysmhqGZ2WFAMZuy1Myt2A2RRlVFCS4742CQ=; b=PWE1JqmjoYhrt5t8dt4FqaBSAtXikLPbLPnLsMyS/tiqef7S9NQMp5nN275J80sxF3 Tyx9RpwGmhpIpvWl46MdcByNIBT+g4QIdvT8SE+KVgbIey7HYyhnjeZ56i7xJS4s/wQH m3Ee74cGubNsNTOSwz02fcphnbnlZyZzoQ75GNnaNkiKTNpkee5BYCOopgKz4SnVN7Ip 8SiDmesti4utkxdwVHwN810CPsjboY3s2iJ4uvKIbfzuSJ4Op88H6LMoWosfqKtW9/T3 MVSucY6+LP0z6iOUQ9cf1G7cg0Ko8bY0SSkBRpko732U2gQ/0C5ivsWOv/YNr7Cnq3Cg VfgQ== X-Gm-Message-State: AJIora//tHQZtY0vheeSrIiIvbbf4TFbQATM4zTjoYOyQ4nnu00xEhll qIKBiHB+Ln99x2E3/Nz4VffnBTxepYlDWtmrnXrW0Sup X-Google-Smtp-Source: AGRyM1shtnhRn95pGTOC3RVj5f5MGZmhm7LiCSJr/YZWiyvJKLeBXSzZteWhDJ+jWqcKsojnfbpvUAQtQqaATWUe3nw= X-Received: by 2002:a2e:9c7:0:b0:25d:480f:85e8 with SMTP id 190-20020a2e09c7000000b0025d480f85e8mr5154078ljj.149.1657828219906; Thu, 14 Jul 2022 12:50:19 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Received: by 2002:a05:6520:244e:b0:1f8:f8e3:65ed with HTTP; Thu, 14 Jul 2022 12:50:19 -0700 (PDT) In-Reply-To: <202207141948.26EJmIBH047696@gitrepo.freebsd.org> References: <202207141948.26EJmIBH047696@gitrepo.freebsd.org> From: Mateusz Guzik Date: Thu, 14 Jul 2022 21:50:19 +0200 Message-ID: Subject: Re: git: 6cbc4ceb7aa0 - main - sched_ule: Use the correct atomic_load variant for tdq_lowpri To: Mark Johnston Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4LkQ7x4Cdxz3Q0K X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=Lz+HZ3bT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2a00:1450:4864:20::235 as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Spamd-Result: default: False [-2.97 / 15.00]; NEURAL_HAM_SHORT(-1.00)[-0.997]; NEURAL_HAM_MEDIUM(-0.82)[-0.820]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; NEURAL_HAM_LONG(-0.16)[-0.157]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::235:from]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; MID_RHS_MATCH_FROMTLD(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_LAST(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-ThisMailContainsUnwantedMimeParts: N On 7/14/22, Mark Johnston wrote: > The branch main has been updated by markj: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=6cbc4ceb7aa0042e969be7c782436391c579cc3a > > commit 6cbc4ceb7aa0042e969be7c782436391c579cc3a > Author: Mark Johnston > AuthorDate: 2022-07-14 19:34:02 +0000 > Commit: Mark Johnston > CommitDate: 2022-07-14 19:34:02 +0000 > > sched_ule: Use the correct atomic_load variant for tdq_lowpri > > Reported by: tuexen > Fixes: 11484ad8a2b0 ("sched_ule: Use explicit atomic accesses for tdq > fields") > --- > sys/kern/sched_ule.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/kern/sched_ule.c b/sys/kern/sched_ule.c > index d23e43a2fbcb..14d6e689081d 100644 > --- a/sys/kern/sched_ule.c > +++ b/sys/kern/sched_ule.c > @@ -1360,7 +1360,7 @@ sched_pickcpu(struct thread *td, int flags) > * expired and it is idle, run it there. > */ > if (THREAD_CAN_SCHED(td, ts->ts_cpu) && > - atomic_load_int(&tdq->tdq_lowpri) >= PRI_MIN_IDLE && > + atomic_load_char(&tdq->tdq_lowpri) >= PRI_MIN_IDLE && this reminds me that someone(tm) should add type checking to these > SCHED_AFFINITY(ts, CG_SHARE_L2)) { > if (cg->cg_flags & CG_FLAG_THREAD) { > /* Check all SMT threads for being idle. */ > > -- Mateusz Guzik