From nobody Thu Jul 07 09:33:46 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 6C9C710FBF5A; Thu, 7 Jul 2022 09:49:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lds8D155xz587f; Thu, 7 Jul 2022 09:49:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1657187388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xgECrqA2bGV0xwtOsHZ+82XV8uGZM0z1HAsBwSARiJs=; b=N81vb+8bsT2qPPxkKYKgnddYxb93sX0T4ri37exC0cnVfd3tvFtBDEYVVAsOvnlg+0zEm3 6ifBgxO5WnKvzGk4X7xf5mYejIL5tDW0/4hQr14CBwTYBecDpSTYj2qa+N1FXRlSF8F9va KbOEmSe6FPFkCdxmrR7rlOoMXg3mRIQ4vMQKH573B6CQwSTgFr0TFbBr0G0a6308/Ng1B0 oVi114DNOaEJ7YKxoXwO59TQrd/KQEP5fsHY+ydCeLDVZCIjZ74HkiYNyrTfPGOQGCFqhs Ie31vLl5/fqfpQM8R05ANDBoaSYuJ8zf2fahYoOyJgq27aWzLP6Ur0qfYnTwTA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ldrnk6BSMzdSt; Thu, 7 Jul 2022 09:33:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2679XkDs025869; Thu, 7 Jul 2022 09:33:46 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2679Xk3Z025868; Thu, 7 Jul 2022 09:33:46 GMT (envelope-from git) Date: Thu, 7 Jul 2022 09:33:46 GMT Message-Id: <202207070933.2679Xk3Z025868@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Turner Subject: git: 92f692fd249e - main - Only add gicv3 fdt children with a compatible property List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 92f692fd249e64ed4b25199310fafe41e2d9c74d Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1657187388; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xgECrqA2bGV0xwtOsHZ+82XV8uGZM0z1HAsBwSARiJs=; b=gEQQeHQDFRojNWefwxjJYV23F0LbfI0ig0lCSuoFT45eVLtg6v+uQx8YmEteZjUMcBqPuv D4cT8gyn8qdO4DIsxwWXaQB5/14wYttyh0cCjZBvj1HgH4kyjN1wpqKdyEIiMNgURTYiqU hxyHmo3CTiF+tEwlIoIo3W7fUhdOGBtkWY30vPCnCh8GXU5y5g/tBQ8HpiLliXOK85G3US bLXltYMIDYm41IyQ9DrOAS0Gd/GEJdOp27TC5+dh7wcnRcQ2PNM6JVLadHKw9ZFemeRx8C nOFoAes/hTf/YU+ZmmqgoUu3tEiImqyuPI2Nwc+nRyrwpEgycEyyUrTPIYHLJw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1657187388; a=rsa-sha256; cv=none; b=H/OZJwng7U95uoL96LNNmWfWG1k5+ZbcnXzvBsr0wowDXk0dYyrF5x+y9qSu0AVcbC6u+3 q+yH1rnSvEt6pmaS1JrhOddEG6b7Z+d2NRsf7yF3eyOaPo3eZPNZQy3wY4fVkWDj7UUXG1 JnMZSwcZLPW6aVVGLmlDqd9+HJ7YpHxnICjbQDGqJtY+qZW2v1u0Oiw/wC21YTbsfG/N44 EWAkxNiyvZYpgfWp6WoHyFGm4u8EqC352zmb8dPfnzSrN9fz2xgvawrqI4S7iXYAbnOq6T /JTLbv7naOEWsM/+2EC452LPkjA9dPyKBDuosptnozsgZY50khOhjaeMkgP7sQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=92f692fd249e64ed4b25199310fafe41e2d9c74d commit 92f692fd249e64ed4b25199310fafe41e2d9c74d Author: Andrew Turner AuthorDate: 2022-07-06 17:04:53 +0000 Commit: Andrew Turner CommitDate: 2022-07-07 09:29:10 +0000 Only add gicv3 fdt children with a compatible property Not all gicv3 fdt children have a compatible property. Those that don't are configuration data rather than something that should have a driver attach. Sponsored by: The FreeBSD Foundation --- sys/arm64/arm64/gic_v3_fdt.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sys/arm64/arm64/gic_v3_fdt.c b/sys/arm64/arm64/gic_v3_fdt.c index 41c6297649fb..0478bdc2962f 100644 --- a/sys/arm64/arm64/gic_v3_fdt.c +++ b/sys/arm64/arm64/gic_v3_fdt.c @@ -299,6 +299,14 @@ gic_v3_ofw_bus_attach(device_t dev) sizeof(size_cells)); /* Iterate through all GIC subordinates */ for (node = OF_child(parent); node > 0; node = OF_peer(node)) { + /* + * Ignore children that lack a compatible property. + * Some of them may be for configuration, for example + * ppi-partitions. + */ + if (!OF_hasprop(node, "compatible")) + continue; + /* Allocate and populate devinfo. */ di = malloc(sizeof(*di), M_GIC_V3, M_WAITOK | M_ZERO);