From nobody Tue Jan 25 06:03:05 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id AA7F41980864; Tue, 25 Jan 2022 06:03:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Jjbqs44Lvz4TgS; Tue, 25 Jan 2022 06:03:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643090585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NTDbktrj9PGwRhlJ7PRPGnJRjohY/fdM0l7/wyN1Af4=; b=N+hyruIBz1Bb24hKXHK41MbElMEWYyS8314XdKN90w0vNzfdfNPnDYifF7choAy0FGWcDz i4D7sDj2CjmNm3IdBRdxLDyE6QG0/m4y/6S/dz7F3L7t+ltnBPgFJvBbJ3hOEYfTgi3bNg KtQJdDbNASexQwqjgTl5+JW/o++0GU+ZkZf+HaIruQm9sUItgTZQBJadAWxKrCKTdhlOGR n/0wgM2yx9OX7dThcUzqegCq5G9jP+hxGVHXQ3WgiUS2pXu5eMYmZtcARmu1pqzikp7ATD sEzeChKzUsSOhZPHIUN62DDLkXmYO8j98Np1GCA27jxpGbW9VMGksKHw5OAWTg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 6CF6324577; Tue, 25 Jan 2022 06:03:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 20P635iW005029; Tue, 25 Jan 2022 06:03:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 20P635GC005028; Tue, 25 Jan 2022 06:03:05 GMT (envelope-from git) Date: Tue, 25 Jan 2022 06:03:05 GMT Message-Id: <202201250603.20P635GC005028@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ka Ho Ng Subject: git: 192c87bf7d64 - stable/13 - iscsi: Fix missing is_lock unlock after cam_simq_alloc() failed List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: khng X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 192c87bf7d64a1e3773ff33185e3430810992825 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643090585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NTDbktrj9PGwRhlJ7PRPGnJRjohY/fdM0l7/wyN1Af4=; b=Y/8hKdvom/ko9gUpxhCrmehVyZ59tANo8uQapAaXpVuqnXAHz5bLDgcFFo+oBc7rEwBvj/ VgHNsI/yo4uc0Oryfqd6RU0gwC6p/oAzQPPcrSp/1D6mitBcJM2U2TvSbFVuR7J6nP6tQC bYT4Y9Uea/cCYEepyBIp/U7jaUjWi4nNVnQucvDDsznUa+ob/URWyVI1C7aAC7oGxEPiR+ pCrI6iuEgWSdNGKNuHe456ktFufb7a+yeLMgpE72nag0VlLfBzT1vIFHejLIcyNgsk36i9 rL6buz6xYpo+3pmvgsWBttybxzTOSCylZpi1topwNhokiveMhUNzDnoNbVLpyA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1643090585; a=rsa-sha256; cv=none; b=HUfGLF8IyGLsX88sqzme+xUssDRaIRgmvJ/1g8V5+Xgl8AhlfmEvxURx/bo/XMKVFCDTzI dT+AxDyXDUEOWg6C8/jtoSHyLKhSD2eaIWjmUGM+fKwltjdwPb9pf+9cVJtTZ1RT4j8z9h J68NNhn95qspvxSr3DDlLYKfycByW7tmxmNKoD41ZHdTY8g1fC73ZbhT64vx2VCgR52zpm oUDIDgK24k8o1mELVxLszyebGAr2sbWcsqZS9Tkm9oNZtADiCW61osluCZ4n2fH7/vK46U X4gjTnHt9qfCWXZfEJ2kQYFSk6Yu9apbwMAAxTM0kS2vtGcw+ttHPr2t4XCpgg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by khng: URL: https://cgit.FreeBSD.org/src/commit/?id=192c87bf7d64a1e3773ff33185e3430810992825 commit 192c87bf7d64a1e3773ff33185e3430810992825 Author: Ka Ho Ng AuthorDate: 2022-01-21 21:34:15 +0000 Commit: Ka Ho Ng CommitDate: 2022-01-25 06:02:33 +0000 iscsi: Fix missing is_lock unlock after cam_simq_alloc() failed Sponsored by: The FreeBSD Foundation (cherry picked from commit fa669505340d54e401917aa6a3d7defb9fc203da) --- sys/dev/iscsi/iscsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/iscsi/iscsi.c b/sys/dev/iscsi/iscsi.c index cc860e3f68a8..ff3203039d5f 100644 --- a/sys/dev/iscsi/iscsi.c +++ b/sys/dev/iscsi/iscsi.c @@ -1540,6 +1540,7 @@ iscsi_ioctl_daemon_handoff(struct iscsi_softc *sc, ISCSI_SESSION_LOCK(is); is->is_devq = cam_simq_alloc(ic->ic_maxtags); if (is->is_devq == NULL) { + ISCSI_SESSION_UNLOCK(is); ISCSI_SESSION_WARN(is, "failed to allocate simq"); iscsi_session_terminate(is); return (ENOMEM);