Re: git: 9ce46cbc95d7 - main - ip_mroute: move ip_mrouter_done outside lock
- In reply to: Gleb Smirnoff : "Re: git: 9ce46cbc95d7 - main - ip_mroute: move ip_mrouter_done outside lock"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 24 Jan 2022 09:47:00 UTC
I must have copied it from some line above, now I see you recently refactored that part. Indeed, epoch_assert is called inside ip_input so I see no reason why not to remove RLOCK/RUNLOCK there. Will test it and update once ready. Thanks, Wojtek pon., 24 sty 2022 o 05:41 Gleb Smirnoff <glebius@freebsd.org> napisaĆ(a): > On Sun, Jan 23, 2022 at 07:24:36PM +0100, Wojciech Macek wrote: > W> This is an orginal fix. The issue was visible due to race between ip > W> input/output and mrouter uninit. > W> https://reviews.freebsd.org/D29946 > > Why did you add another net epoch tracker under different name? Just adding > NET_EPOCH_WAIT() to X_ip_mrouter_done() would provide the same effect > without > any modifications to the rest of the stack. > > -- > Gleb Smirnoff >