From nobody Mon Jan 24 04:41:17 2022
X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9AAE8198394C;
	Mon, 24 Jan 2022 04:41:20 +0000 (UTC)
	(envelope-from glebius@freebsd.org)
Received: from cell.glebi.us (glebi.us [162.251.186.162])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (2048 bits) client-digest SHA256)
	(Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4Jhy402WWqz3H0H;
	Mon, 24 Jan 2022 04:41:20 +0000 (UTC)
	(envelope-from glebius@freebsd.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
	by cell.glebi.us (8.16.1/8.16.1) with ESMTPS id 20O4fHeC013258
	(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
	Sun, 23 Jan 2022 20:41:17 -0800 (PST)
	(envelope-from glebius@freebsd.org)
Received: (from glebius@localhost)
	by cell.glebi.us (8.16.1/8.16.1/Submit) id 20O4fH08013257;
	Sun, 23 Jan 2022 20:41:17 -0800 (PST)
	(envelope-from glebius@freebsd.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f
Date: Sun, 23 Jan 2022 20:41:17 -0800
From: Gleb Smirnoff <glebius@freebsd.org>
To: Wojciech Macek <wma@semihalf.com>
Cc: Kristof Provost <kp@freebsd.org>, Wojciech Macek <wma@freebsd.org>,
        src-committers <src-committers@freebsd.org>,
        "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>,
        dev-commits-src-main@freebsd.org
Subject: Re: git: 9ce46cbc95d7 - main - ip_mroute: move ip_mrouter_done
 outside lock
Message-ID: <Ye4t7c+qWUlyWkbC@FreeBSD.org>
References: <202201210519.20L5J1mJ029323@gitrepo.freebsd.org>
 <7A991003-0F24-4C8C-81FD-84F39FC78D8A@FreeBSD.org>
 <C25EE57B-BE5A-4BC8-AD00-C8D0D582D073@FreeBSD.org>
 <CANsEV8cmZcQKh3U8w2S37cg9heFd=icuEmF7dVwrE486OM3Yug@mail.gmail.com>
 <Ye2FOvi32Xu23qIB@FreeBSD.org>
 <CANsEV8cEWc9GsTZk+Vm-_+9rsU-=yXLjRkZZz--dg7-ZJRgOnw@mail.gmail.com>
List-Id: Commit messages for all branches of the src repository <dev-commits-src-all.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all
List-Help: <mailto:dev-commits-src-all+help@freebsd.org>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-all+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-all+unsubscribe@freebsd.org>
Sender: owner-dev-commits-src-all@freebsd.org
X-BeenThere: dev-commits-src-all@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANsEV8cEWc9GsTZk+Vm-_+9rsU-=yXLjRkZZz--dg7-ZJRgOnw@mail.gmail.com>
X-Rspamd-Queue-Id: 4Jhy402WWqz3H0H
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-ThisMailContainsUnwantedMimeParts: N

On Sun, Jan 23, 2022 at 07:24:36PM +0100, Wojciech Macek wrote:
W> This is an orginal fix. The issue was visible due to race between ip
W> input/output and mrouter uninit.
W> https://reviews.freebsd.org/D29946

Why did you add another net epoch tracker under different name? Just adding
NET_EPOCH_WAIT() to X_ip_mrouter_done() would provide the same effect without
any modifications to the rest of the stack.

-- 
Gleb Smirnoff